From: "Arthur Zamarin" <arthurzam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/pkgcore/pkgcore:master commit in: src/pkgcore/ebuild/
Date: Sat, 29 Oct 2022 11:56:49 +0000 (UTC) [thread overview]
Message-ID: <1667044602.e7aeda0fdec527e99e40af05865689e27ed01cbd.arthurzam@gentoo> (raw)
commit: e7aeda0fdec527e99e40af05865689e27ed01cbd
Author: Arthur Zamarin <arthurzam <AT> gentoo <DOT> org>
AuthorDate: Sat Oct 29 11:45:24 2022 +0000
Commit: Arthur Zamarin <arthurzam <AT> gentoo <DOT> org>
CommitDate: Sat Oct 29 11:56:42 2022 +0000
URL: https://gitweb.gentoo.org/proj/pkgcore/pkgcore.git/commit/?id=e7aeda0f
ebuild.profiles: error out when using USE_EXAPND in package.mask
portage fails to parse this syntax when used for package.use files under
a profile, and pkgcore parses it incorrectly. So in case such syntax is
detected, error out (which will cause a ProfileError with pkgcheck).
Resolves: https://github.com/pkgcore/pkgcheck/issues/370
Signed-off-by: Arthur Zamarin <arthurzam <AT> gentoo.org>
src/pkgcore/ebuild/profiles.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/pkgcore/ebuild/profiles.py b/src/pkgcore/ebuild/profiles.py
index 34e839e9b..17805edaa 100644
--- a/src/pkgcore/ebuild/profiles.py
+++ b/src/pkgcore/ebuild/profiles.py
@@ -329,6 +329,9 @@ class ProfileNode(metaclass=caching.WeakInstMeta):
if len(l) == 1:
logger.error(f'{relpath!r}, line {lineno}: missing USE flag(s): {line!r}')
continue
+ if any(s.endswith(':') for s in l[1:]):
+ logger.error(f'{relpath!r}, line {lineno}: USE_EXPAND syntax is invalid in this context: {line!r}')
+ continue
d[a.key].append(misc.chunked_data(a, *split_negations(l[1:])))
return ImmutableDict((k, misc._build_cp_atom_payload(v, atom(k)))
next reply other threads:[~2022-10-29 11:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-29 11:56 Arthur Zamarin [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-06-13 16:40 [gentoo-commits] proj/pkgcore/pkgcore:master commit in: src/pkgcore/ebuild/ Arthur Zamarin
2023-12-26 17:45 Arthur Zamarin
2023-10-23 17:35 Arthur Zamarin
2023-06-30 20:08 Arthur Zamarin
2023-02-04 19:52 Arthur Zamarin
2023-01-17 20:50 Arthur Zamarin
2023-01-03 18:06 Arthur Zamarin
2022-12-26 17:28 Arthur Zamarin
2022-12-26 17:28 Arthur Zamarin
2022-12-26 17:28 Arthur Zamarin
2022-12-26 17:28 Arthur Zamarin
2022-12-26 17:28 Arthur Zamarin
2022-12-26 17:28 Arthur Zamarin
2022-12-25 17:40 Arthur Zamarin
2022-12-22 7:11 Arthur Zamarin
2022-12-22 7:11 Arthur Zamarin
2022-12-22 7:11 Arthur Zamarin
2022-12-22 7:11 Arthur Zamarin
2022-12-22 7:11 Arthur Zamarin
2022-12-13 19:58 Arthur Zamarin
2022-11-26 11:17 Arthur Zamarin
2022-10-16 16:38 Arthur Zamarin
2022-10-04 8:24 Arthur Zamarin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1667044602.e7aeda0fdec527e99e40af05865689e27ed01cbd.arthurzam@gentoo \
--to=arthurzam@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox