From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 7F05F158020 for ; Mon, 17 Oct 2022 20:31:32 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id BB94BE091C; Mon, 17 Oct 2022 20:31:31 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 9F9CCE091C for ; Mon, 17 Oct 2022 20:31:31 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 68196341042 for ; Mon, 17 Oct 2022 20:31:30 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 91C3F5A0 for ; Mon, 17 Oct 2022 20:31:28 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1666038670.f44d1becbe468a4e1c36a4819a6276b9ee0c9da2.sam@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: sys-libs/musl/ X-VCS-Repository: repo/gentoo X-VCS-Files: sys-libs/musl/musl-1.2.2-r8.ebuild sys-libs/musl/musl-1.2.3-r4.ebuild sys-libs/musl/musl-1.2.3.ebuild sys-libs/musl/musl-9999.ebuild X-VCS-Directories: sys-libs/musl/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: f44d1becbe468a4e1c36a4819a6276b9ee0c9da2 X-VCS-Branch: master Date: Mon, 17 Oct 2022 20:31:28 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 8fc32d4a-7b4f-477e-8552-343210b637b7 X-Archives-Hash: c0c58b54816f3e7b9590da510644b45e commit: f44d1becbe468a4e1c36a4819a6276b9ee0c9da2 Author: Ian Jordan gmail com> AuthorDate: Mon Oct 17 18:44:08 2022 +0000 Commit: Sam James gentoo org> CommitDate: Mon Oct 17 20:31:10 2022 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f44d1bec sys-libs/musl: Filter LTO After discussing my bug with dalias on #musl I was informed that LTO has a negative impact on Musl so fixing the issue I highlight rather than filtering wouldn't be the desired outcome for the user. This will also help crossdev users as a bonus as -flto applies to the crosstoolchain and can be hard to spot at first. Chat log to comfirm: immolo: I ran into the -flto issue while testing musl built with lto and the only thing I can find on it was a workaround in 2015. immolo: My question though is it even worth having lto enabled on musl in the first place as every distro just seems to filter it so there must be a reason dalias: not only is it not worth it. it's negative value dalias: makes musl larger and slower dalias: if you wanted libc.a to get LTO'd into static programs, that might have some value dalias: but LTO on libc.so is worse than worthless Closes: https://bugs.gentoo.org/877343 Thanks-to: dalias Signed-off-by: Ian Jordan gmail.com> Closes: https://github.com/gentoo/gentoo/pull/27824 Signed-off-by: Sam James gentoo.org> sys-libs/musl/musl-1.2.2-r8.ebuild | 1 + sys-libs/musl/musl-1.2.3-r4.ebuild | 1 + sys-libs/musl/musl-1.2.3.ebuild | 1 + sys-libs/musl/musl-9999.ebuild | 1 + 4 files changed, 4 insertions(+) diff --git a/sys-libs/musl/musl-1.2.2-r8.ebuild b/sys-libs/musl/musl-1.2.2-r8.ebuild index a7b1acd0c36c..2c16357eb55f 100644 --- a/sys-libs/musl/musl-1.2.2-r8.ebuild +++ b/sys-libs/musl/musl-1.2.2-r8.ebuild @@ -88,6 +88,7 @@ src_prepare() { } src_configure() { + filter-lto # bug #877343 tc-getCC ${CTARGET} just_headers && export CC=true diff --git a/sys-libs/musl/musl-1.2.3-r4.ebuild b/sys-libs/musl/musl-1.2.3-r4.ebuild index 1d60464d46a4..6f2527e85a39 100644 --- a/sys-libs/musl/musl-1.2.3-r4.ebuild +++ b/sys-libs/musl/musl-1.2.3-r4.ebuild @@ -104,6 +104,7 @@ src_prepare() { } src_configure() { + filter-lto # bug #877343 tc-getCC ${CTARGET} just_headers && export CC=true diff --git a/sys-libs/musl/musl-1.2.3.ebuild b/sys-libs/musl/musl-1.2.3.ebuild index a7b1acd0c36c..2c16357eb55f 100644 --- a/sys-libs/musl/musl-1.2.3.ebuild +++ b/sys-libs/musl/musl-1.2.3.ebuild @@ -88,6 +88,7 @@ src_prepare() { } src_configure() { + filter-lto # bug #877343 tc-getCC ${CTARGET} just_headers && export CC=true diff --git a/sys-libs/musl/musl-9999.ebuild b/sys-libs/musl/musl-9999.ebuild index 1d60464d46a4..6f2527e85a39 100644 --- a/sys-libs/musl/musl-9999.ebuild +++ b/sys-libs/musl/musl-9999.ebuild @@ -104,6 +104,7 @@ src_prepare() { } src_configure() { + filter-lto # bug #877343 tc-getCC ${CTARGET} just_headers && export CC=true