public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-commits] repo/proj/guru:dev commit in: sys-power/tlp/
@ 2022-07-25 10:04 Duje Mihanović
  0 siblings, 0 replies; 3+ messages in thread
From: Duje Mihanović @ 2022-07-25 10:04 UTC (permalink / raw
  To: gentoo-commits

commit:     e1f3a62fb8e77a2d5c53250717425d5d7efc899c
Author:     Duje Mihanović <duje.mihanovic <AT> skole <DOT> hr>
AuthorDate: Mon Jul 25 10:00:31 2022 +0000
Commit:     Duje Mihanović <duje.mihanovic <AT> skole <DOT> hr>
CommitDate: Mon Jul 25 10:00:31 2022 +0000
URL:        https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=e1f3a62f

sys-power/tlp: call udev_reload in pkg_postrm

Closes: https://bugs.gentoo.org/860786
Signed-off-by: Duje Mihanović <duje.mihanovic <AT> skole.hr>

 sys-power/tlp/tlp-1.5.0.ebuild | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sys-power/tlp/tlp-1.5.0.ebuild b/sys-power/tlp/tlp-1.5.0.ebuild
index 624b437c5..3ef6bd6d6 100644
--- a/sys-power/tlp/tlp-1.5.0.ebuild
+++ b/sys-power/tlp/tlp-1.5.0.ebuild
@@ -57,3 +57,7 @@ pkg_postinst() {
 	elog "- sys-apps/ethtool to allow disabling WoL"
 	elog "- sys-apps/smartmontools for disk drive health info in tlp-stat"
 }
+
+pkg_postrm() {
+	udev_reload
+}


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [gentoo-commits] repo/proj/guru:dev commit in: sys-power/tlp/
@ 2022-07-25 10:04 Duje Mihanović
  0 siblings, 0 replies; 3+ messages in thread
From: Duje Mihanović @ 2022-07-25 10:04 UTC (permalink / raw
  To: gentoo-commits

commit:     9d81af737546943170dd57ee7ee9da62180e5571
Author:     Duje Mihanović <duje.mihanovic <AT> skole <DOT> hr>
AuthorDate: Mon Jul 25 10:03:48 2022 +0000
Commit:     Duje Mihanović <duje.mihanovic <AT> skole <DOT> hr>
CommitDate: Mon Jul 25 10:03:48 2022 +0000
URL:        https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=9d81af73

sys-power/tlp: use optfeature

Signed-off-by: Duje Mihanović <duje.mihanovic <AT> skole.hr>

 sys-power/tlp/tlp-1.5.0.ebuild | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/sys-power/tlp/tlp-1.5.0.ebuild b/sys-power/tlp/tlp-1.5.0.ebuild
index 3ef6bd6d6..d2cc2f1fe 100644
--- a/sys-power/tlp/tlp-1.5.0.ebuild
+++ b/sys-power/tlp/tlp-1.5.0.ebuild
@@ -3,7 +3,7 @@
 
 EAPI=8
 
-inherit udev
+inherit udev optfeature
 
 DESCRIPTION="Optimize laptop battery life"
 HOMEPAGE="https://linrunner.de/tlp/"
@@ -53,9 +53,8 @@ src_install() {
 pkg_postinst() {
 	udev_reload
 
-	elog "Consider installing these optional dependencies:"
-	elog "- sys-apps/ethtool to allow disabling WoL"
-	elog "- sys-apps/smartmontools for disk drive health info in tlp-stat"
+	optfeature "disable Wake-on-LAN" sys-apps/ethtool
+	optfeature "see disk drive health info in tlp-stat" sys-apps/smartmontools
 }
 
 pkg_postrm() {


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [gentoo-commits] repo/proj/guru:dev commit in: sys-power/tlp/
@ 2022-09-02  2:11 Jay Faulkner
  0 siblings, 0 replies; 3+ messages in thread
From: Jay Faulkner @ 2022-09-02  2:11 UTC (permalink / raw
  To: gentoo-commits

commit:     4c77f8f888abd2553fc03a6c54d6c0a2a0424b69
Author:     Jay Faulkner <jay <AT> jvf <DOT> cc>
AuthorDate: Fri Sep  2 01:47:15 2022 +0000
Commit:     Jay Faulkner <jay <AT> jvf <DOT> cc>
CommitDate: Fri Sep  2 02:09:24 2022 +0000
URL:        https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=4c77f8f8

sys-power/tlp: Remove unneeded use flags

The systemd and elogind toggles in the tlp build only toggle
installation of unit file and sleep triggers. There's no need to
conditionally install those per PG#0301.

Signed-Off-By: Jay Faulkner <jay <AT> jvf.cc>

 sys-power/tlp/tlp-1.5.0.ebuild | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/sys-power/tlp/tlp-1.5.0.ebuild b/sys-power/tlp/tlp-1.5.0.ebuild
index 0fc6f0d01..bf18bbbb7 100644
--- a/sys-power/tlp/tlp-1.5.0.ebuild
+++ b/sys-power/tlp/tlp-1.5.0.ebuild
@@ -12,25 +12,22 @@ S="${WORKDIR}/TLP-${PV}"
 LICENSE="GPL-2"
 SLOT="0"
 KEYWORDS="~amd64"
-IUSE="bash-completion elogind systemd"
 RESTRICT="mirror"
+# It's uncertain if elogind/systemd is actually required, however, without the sleep
+# hooks working, which require one of them, it doesn't seem like this app is very useful.
 RDEPEND="virtual/udev
-		bash-completion? ( app-shells/bash app-shells/bash-completion )
-		elogind? ( sys-auth/elogind )
-		systemd? ( sys-apps/systemd )"
+		|| ( sys-auth/elogind sys-apps/systemd )"
 DEPEND="${RDEPEND}"
-REQUIRED_USE="?? ( elogind systemd )"
 
 src_install() {
 	emake \
 		DESTDIR="${D}" \
 		TLP_NO_INIT=1 \
-		TLP_NO_BASHCOMP=$(usex bash-completion 0 1) \
-		TLP_WITH_ELOGIND=$(usex elogind 1 0) \
-		TLP_WITH_SYSTEMD=$(usex systemd 1 0) \
+		TLP_WITH_ELOGIND=1 \
+		TLP_WITH_SYSTEMD=1 \
 		install install-man
 
-	chmod 444 "${D}/usr/share/tlp/defaults.conf" # manpage says this file should not be edited
+	fperms 444 "/usr/share/tlp/defaults.conf" # manpage says this file should not be edited
 	newinitd "${FILESDIR}/tlp.init" tlp
 	keepdir "/var/lib/tlp" # created by Makefile, probably important
 }


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-09-02  2:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-02  2:11 [gentoo-commits] repo/proj/guru:dev commit in: sys-power/tlp/ Jay Faulkner
  -- strict thread matches above, loose matches on Subject: below --
2022-07-25 10:04 Duje Mihanović
2022-07-25 10:04 Duje Mihanović

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox