public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Jay Faulkner" <jay@jvf.cc>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/proj/guru:dev commit in: sys-power/tlp/
Date: Fri,  2 Sep 2022 02:11:21 +0000 (UTC)	[thread overview]
Message-ID: <1662084564.4c77f8f888abd2553fc03a6c54d6c0a2a0424b69.jayf@gentoo> (raw)

commit:     4c77f8f888abd2553fc03a6c54d6c0a2a0424b69
Author:     Jay Faulkner <jay <AT> jvf <DOT> cc>
AuthorDate: Fri Sep  2 01:47:15 2022 +0000
Commit:     Jay Faulkner <jay <AT> jvf <DOT> cc>
CommitDate: Fri Sep  2 02:09:24 2022 +0000
URL:        https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=4c77f8f8

sys-power/tlp: Remove unneeded use flags

The systemd and elogind toggles in the tlp build only toggle
installation of unit file and sleep triggers. There's no need to
conditionally install those per PG#0301.

Signed-Off-By: Jay Faulkner <jay <AT> jvf.cc>

 sys-power/tlp/tlp-1.5.0.ebuild | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/sys-power/tlp/tlp-1.5.0.ebuild b/sys-power/tlp/tlp-1.5.0.ebuild
index 0fc6f0d01..bf18bbbb7 100644
--- a/sys-power/tlp/tlp-1.5.0.ebuild
+++ b/sys-power/tlp/tlp-1.5.0.ebuild
@@ -12,25 +12,22 @@ S="${WORKDIR}/TLP-${PV}"
 LICENSE="GPL-2"
 SLOT="0"
 KEYWORDS="~amd64"
-IUSE="bash-completion elogind systemd"
 RESTRICT="mirror"
+# It's uncertain if elogind/systemd is actually required, however, without the sleep
+# hooks working, which require one of them, it doesn't seem like this app is very useful.
 RDEPEND="virtual/udev
-		bash-completion? ( app-shells/bash app-shells/bash-completion )
-		elogind? ( sys-auth/elogind )
-		systemd? ( sys-apps/systemd )"
+		|| ( sys-auth/elogind sys-apps/systemd )"
 DEPEND="${RDEPEND}"
-REQUIRED_USE="?? ( elogind systemd )"
 
 src_install() {
 	emake \
 		DESTDIR="${D}" \
 		TLP_NO_INIT=1 \
-		TLP_NO_BASHCOMP=$(usex bash-completion 0 1) \
-		TLP_WITH_ELOGIND=$(usex elogind 1 0) \
-		TLP_WITH_SYSTEMD=$(usex systemd 1 0) \
+		TLP_WITH_ELOGIND=1 \
+		TLP_WITH_SYSTEMD=1 \
 		install install-man
 
-	chmod 444 "${D}/usr/share/tlp/defaults.conf" # manpage says this file should not be edited
+	fperms 444 "/usr/share/tlp/defaults.conf" # manpage says this file should not be edited
 	newinitd "${FILESDIR}/tlp.init" tlp
 	keepdir "/var/lib/tlp" # created by Makefile, probably important
 }


             reply	other threads:[~2022-09-02  2:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-02  2:11 Jay Faulkner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-07-25 10:04 [gentoo-commits] repo/proj/guru:dev commit in: sys-power/tlp/ Duje Mihanović
2022-07-25 10:04 Duje Mihanović

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1662084564.4c77f8f888abd2553fc03a6c54d6c0a2a0424b69.jayf@gentoo \
    --to=jay@jvf.cc \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox