From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 2C660158094 for ; Wed, 17 Aug 2022 21:20:16 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 288D9E077C; Wed, 17 Aug 2022 21:20:15 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 015B9E077C for ; Wed, 17 Aug 2022 21:20:14 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id D630B340F8B for ; Wed, 17 Aug 2022 21:20:13 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 73E8AD4 for ; Wed, 17 Aug 2022 21:20:12 +0000 (UTC) From: "Ionen Wolkens" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Ionen Wolkens" Message-ID: <1660771160.86ee2059ef3322c2f01aaeac896b1d8a2ccb51ac.ionen@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: dev-qt/qtwebengine/, dev-qt/qtwebengine/files/ X-VCS-Repository: repo/gentoo X-VCS-Files: dev-qt/qtwebengine/files/qtwebengine-6.3.1-favicon.patch dev-qt/qtwebengine/qtwebengine-6.3.1.ebuild X-VCS-Directories: dev-qt/qtwebengine/files/ dev-qt/qtwebengine/ X-VCS-Committer: ionen X-VCS-Committer-Name: Ionen Wolkens X-VCS-Revision: 86ee2059ef3322c2f01aaeac896b1d8a2ccb51ac X-VCS-Branch: master Date: Wed, 17 Aug 2022 21:20:12 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: f94a08f0-91d8-44e3-9eb9-968443862981 X-Archives-Hash: 81e3fa6cc2fc96b6ddb9ade60bd6f03e commit: 86ee2059ef3322c2f01aaeac896b1d8a2ccb51ac Author: Ionen Wolkens gentoo org> AuthorDate: Wed Aug 17 18:32:03 2022 +0000 Commit: Ionen Wolkens gentoo org> CommitDate: Wed Aug 17 21:19:20 2022 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=86ee2059 dev-qt/qtwebengine: backport :6 favicon display fix Not worth a revbump rebuild, but is still annoying and wanted to toss it here at least for future builds. Signed-off-by: Ionen Wolkens gentoo.org> .../files/qtwebengine-6.3.1-favicon.patch | 28 ++++++++++++++++++++++ dev-qt/qtwebengine/qtwebengine-6.3.1.ebuild | 1 + 2 files changed, 29 insertions(+) diff --git a/dev-qt/qtwebengine/files/qtwebengine-6.3.1-favicon.patch b/dev-qt/qtwebengine/files/qtwebengine-6.3.1-favicon.patch new file mode 100644 index 000000000000..8c9544b16935 --- /dev/null +++ b/dev-qt/qtwebengine/files/qtwebengine-6.3.1-favicon.patch @@ -0,0 +1,28 @@ +Backport dev branch fix for favicons sometime not showing in +some consumers like qutebrowser. Not currently included in +upcoming 6.3.2 so may be needed beyond 6.3.1. + +https://bugreports.qt.io/browse/QTBUG-103735 +https://github.com/qt/qtwebengine/commit/c5de1b2123 +--- a/src/core/favicon_driver_qt.cpp ++++ b/src/core/favicon_driver_qt.cpp +@@ -300,15 +300,15 @@ void FaviconDriverQt::DidStartNavigation(content::NavigationHandle *navigation_h + return; + + m_faviconUrls.reset(); +- m_completedHandlersCount = 0; +- m_latestFavicon = FaviconStatusQt(); + + if (!navigation_handle->IsSameDocument()) { ++ m_completedHandlersCount = 0; ++ m_latestFavicon = FaviconStatusQt(); + m_documentOnLoadCompleted = false; + m_manifestUrl = GURL(); +- } + +- m_viewClient->iconChanged(QUrl()); ++ m_viewClient->iconChanged(QUrl()); ++ } + + content::ReloadType reload_type = navigation_handle->GetReloadType(); + if (reload_type == content::ReloadType::NONE || IsOffTheRecord()) diff --git a/dev-qt/qtwebengine/qtwebengine-6.3.1.ebuild b/dev-qt/qtwebengine/qtwebengine-6.3.1.ebuild index 468f7bbc29d7..91f14a1f75cf 100644 --- a/dev-qt/qtwebengine/qtwebengine-6.3.1.ebuild +++ b/dev-qt/qtwebengine/qtwebengine-6.3.1.ebuild @@ -88,6 +88,7 @@ DEPEND="${RDEPEND} PATCHES=( "${FILESDIR}"/${P}-widevine.patch + "${FILESDIR}"/${P}-favicon.patch ) python_check_deps() {