public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "William Hubbs" <williamh@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: sys-cluster/kube-router/files/
Date: Thu, 28 Jul 2022 20:13:39 +0000 (UTC)	[thread overview]
Message-ID: <1659039077.37327358a8701680c926e62265c29b248eff50ad.williamh@gentoo> (raw)

commit:     37327358a8701680c926e62265c29b248eff50ad
Author:     William Hubbs <williamh <AT> gentoo <DOT> org>
AuthorDate: Thu Jul 28 20:11:17 2022 +0000
Commit:     William Hubbs <williamh <AT> gentoo <DOT> org>
CommitDate: Thu Jul 28 20:11:17 2022 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=37327358

sys-cluster/kube-router: make service script POSIX compatible

Closes: https://bugs.gentoo.org/852080
Signed-off-by: William Hubbs <williamh <AT> gentoo.org>

 sys-cluster/kube-router/files/kube-router.confd | 3 ++-
 sys-cluster/kube-router/files/kube-router.initd | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/sys-cluster/kube-router/files/kube-router.confd b/sys-cluster/kube-router/files/kube-router.confd
index a5f20a581c4c..601368deaf1e 100644
--- a/sys-cluster/kube-router/files/kube-router.confd
+++ b/sys-cluster/kube-router/files/kube-router.confd
@@ -2,7 +2,8 @@
 # KUBECONFIG=/etc/kubernetes/kube-router.kubeconfig
 
 # Leave empty to autodetect:
-# HOSTNAME=
+# HOSTNAME is a bashism, so change to HOSTNAME_OVERRIDE
+# HOSTNAME_OVERRIDE=
 
 # RUN_PROXY=true
 # RUN_FIREWALL=true

diff --git a/sys-cluster/kube-router/files/kube-router.initd b/sys-cluster/kube-router/files/kube-router.initd
index 9b96ec024f66..de39cd76de9b 100644
--- a/sys-cluster/kube-router/files/kube-router.initd
+++ b/sys-cluster/kube-router/files/kube-router.initd
@@ -12,7 +12,7 @@ command_args="--master=${K8S_APISERVER} --kubeconfig=${KUBECONFIG} \
               --run-service-proxy=${RUN_PROXY:-false} \
               --run-firewall=${RUN_FIREWALL:-false} \
               --run-router=${RUN_ROUTER:-false} \
-              ${HOSTNAME:+--hostname-override=}${HOSTNAME} \
+              ${HOSTNAME_OVERRIDE:+--hostname-override=}${HOSTNAME_OVERRIDE} \
               ${EXTRA_ARGS}"
 
 extra_commands="clear"
@@ -21,7 +21,7 @@ clear() {
     "${command}" --cleanup-config
 }
 
-if [[ -n "${KUBE_ROUTER_HEALTHCHECK_URI}" ]]; then
+if [ -n "${KUBE_ROUTER_HEALTHCHECK_URI}" ]; then
         healthcheck_delay=60
         healthcheck_timer=30
 


             reply	other threads:[~2022-07-28 20:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28 20:13 William Hubbs [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-07-28 20:13 [gentoo-commits] repo/gentoo:master commit in: sys-cluster/kube-router/files/ William Hubbs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1659039077.37327358a8701680c926e62265c29b248eff50ad.williamh@gentoo \
    --to=williamh@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox