From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 32609158094 for ; Tue, 19 Jul 2022 06:33:11 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 56B07E0788; Tue, 19 Jul 2022 06:33:10 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 33DA6E0788 for ; Tue, 19 Jul 2022 06:33:10 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 1031E34072E for ; Tue, 19 Jul 2022 06:33:09 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 86392535 for ; Tue, 19 Jul 2022 06:33:07 +0000 (UTC) From: "Anna Vyalkova" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Anna Vyalkova" Message-ID: <1658212381.dd644b2fb8960c0481c41efe0215eb109bd29ffd.cybertailor@gentoo> Subject: [gentoo-commits] repo/proj/guru:dev commit in: eclass/ X-VCS-Repository: repo/proj/guru X-VCS-Files: eclass/nim-utils.eclass X-VCS-Directories: eclass/ X-VCS-Committer: cybertailor X-VCS-Committer-Name: Anna Vyalkova X-VCS-Revision: dd644b2fb8960c0481c41efe0215eb109bd29ffd X-VCS-Branch: dev Date: Tue, 19 Jul 2022 06:33:07 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 17730e46-0aae-4c23-b15c-3e9b5520c61c X-Archives-Hash: 9abb90be7730267ccff1334629d35e3c commit: dd644b2fb8960c0481c41efe0215eb109bd29ffd Author: Anna (cybertailor) Vyalkova sysrq in> AuthorDate: Tue Jul 19 06:29:36 2022 +0000 Commit: Anna Vyalkova sysrq in> CommitDate: Tue Jul 19 06:33:01 2022 +0000 URL: https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=dd644b2f nim-utils.eclass: don't write NIMFLAGS to the config file There are issues with strings containing spaces. Signed-off-by: Anna (cybertailor) Vyalkova sysrq.in> eclass/nim-utils.eclass | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/eclass/nim-utils.eclass b/eclass/nim-utils.eclass index 743aa9877..bab1a55f4 100644 --- a/eclass/nim-utils.eclass +++ b/eclass/nim-utils.eclass @@ -25,11 +25,11 @@ if [[ ! ${_NIM_UTILS_ECLASS} ]]; then # @USER_VARIABLE # @DEFAULT_UNSET # @DESCRIPTION: -# Flags for the Nim compiler. All values (if any) must be double-quoted. +# Flags for the Nim compiler. Spaces need to be quoted or shell-escaped. # Example: # # @CODE@ -# # NIMFLAGS='-d:myFlag -d:myOpt:"value"' emerge category/package +# # NIMFLAGS="-d:myFlag -d:myOpt:'my value'" emerge category/package # @CODE@ # @ECLASS_VARIABLE: TESTAMENT_DISABLE_MEGATEST @@ -49,14 +49,14 @@ inherit multiprocessing toolchain-funcs xdg-utils # @FUNCTION: enim # @USAGE: [...] # @DESCRIPTION: -# Call nim, passing the supplied arguments. +# Call nim, passing the supplied arguments and NIMFLAGS. # This function dies if nim fails. It also supports being called via 'nonfatal'. # If you need to call nim directly in your ebuilds, this is the way it should # be done. enim() { debug-print-function ${FUNCNAME} "${@}" - set -- nim "${@}" + set -- nim "${@}" ${NIMFLAGS} echo "$@" >&2 "$@" || die -n "${*} failed" } @@ -173,7 +173,6 @@ nim_gen_config() { -d:"$(nim_get_buildtype)" --colors:"$(nim_get_colors)" --parallelBuild:"$(makeopts_jobs)" - $(printf "%s\n" ${NIMFLAGS}) EOF }