public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: sys-apps/dbus/files/, sys-apps/dbus/
Date: Mon, 20 Jun 2022 03:02:56 +0000 (UTC)	[thread overview]
Message-ID: <1655694140.d312126538f24aed777addc15e0a572f9e670f58.sam@gentoo> (raw)

commit:     d312126538f24aed777addc15e0a572f9e670f58
Author:     Andrew Udvare <audvare <AT> gmail <DOT> com>
AuthorDate: Mon Jun 20 02:59:41 2022 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Mon Jun 20 03:02:20 2022 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d3121265

sys-apps/dbus: minor shellcheck fixes

* [x]  Run shellcheck
* [x]  Use `$(...)` syntax instead of backticks
* [x]  Quote eval arguments

Bug: https://bugs.gentoo.org/845141
Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Andrew Udvare <audvare <AT> gmail.com>
Closes: https://github.com/gentoo/gentoo/pull/25988
Signed-off-by: Sam James <sam <AT> gentoo.org>

 sys-apps/dbus/{dbus-1.14.0-r3.ebuild => dbus-1.14.0-r4.ebuild} | 0
 sys-apps/dbus/files/80-dbus-r1                                 | 4 ++--
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys-apps/dbus/dbus-1.14.0-r3.ebuild b/sys-apps/dbus/dbus-1.14.0-r4.ebuild
similarity index 100%
rename from sys-apps/dbus/dbus-1.14.0-r3.ebuild
rename to sys-apps/dbus/dbus-1.14.0-r4.ebuild

diff --git a/sys-apps/dbus/files/80-dbus-r1 b/sys-apps/dbus/files/80-dbus-r1
index edef88a3c30c..3499a6a12eca 100644
--- a/sys-apps/dbus/files/80-dbus-r1
+++ b/sys-apps/dbus/files/80-dbus-r1
@@ -2,12 +2,12 @@
 
 # launches a session dbus instance
 
-dbuslaunch="`command -v dbus-launch 2>/dev/null`"
+dbuslaunch=$(command -v dbus-launch 2>/dev/null)
 if [ -n "$dbuslaunch" ] && [ -x "$dbuslaunch" ] && [ -z "$DBUS_SESSION_BUS_ADDRESS" ]; then
   if [ -n "$command" ]; then
     command="$dbuslaunch --exit-with-session $command"
   else
-    eval `$dbuslaunch --sh-syntax --exit-with-session`
+    eval "$($dbuslaunch --sh-syntax --exit-with-session)"
   fi
 fi
 


             reply	other threads:[~2022-06-20  3:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-20  3:02 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-02-28 14:44 [gentoo-commits] repo/gentoo:master commit in: sys-apps/dbus/files/, sys-apps/dbus/ Sam James
2025-02-28 13:27 Sam James
2025-02-09  8:20 Sam James
2023-09-02 16:21 Sam James
2022-09-12 18:04 Sam James
2022-04-22 23:54 Mike Gilbert
2022-03-27 23:09 Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1655694140.d312126538f24aed777addc15e0a572f9e670f58.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox