public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: media-sound/soundconverter/
Date: Tue, 31 May 2022 04:07:09 +0000 (UTC)	[thread overview]
Message-ID: <1653970020.5faee21836cdcd724ca89df47ae28620d5a56ad9.sam@gentoo> (raw)

commit:     5faee21836cdcd724ca89df47ae28620d5a56ad9
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Tue May 31 04:03:46 2022 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Tue May 31 04:07:00 2022 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5faee218

media-sound/soundconverter: add partial test infrastructure; minor QA touchups

Closes: https://bugs.gentoo.org/758197
Bug: https://bugs.gentoo.org/846092
Signed-off-by: Sam James <sam <AT> gentoo.org>

 .../soundconverter/soundconverter-4.0.3.ebuild     | 47 +++++++++++++++++++---
 1 file changed, 41 insertions(+), 6 deletions(-)

diff --git a/media-sound/soundconverter/soundconverter-4.0.3.ebuild b/media-sound/soundconverter/soundconverter-4.0.3.ebuild
index 9840037dc60f..334ca9cba906 100644
--- a/media-sound/soundconverter/soundconverter-4.0.3.ebuild
+++ b/media-sound/soundconverter/soundconverter-4.0.3.ebuild
@@ -7,7 +7,7 @@ DISTUTILS_SINGLE_IMPL=1
 DISTUTILS_USE_PEP517=setuptools
 PYTHON_COMPAT=( python3_{8..10} )
 PYTHON_REQ_USE="xml(+)"
-inherit distutils-r1 xdg
+inherit gnome2-utils distutils-r1 virtualx xdg
 
 MY_PV="${PV/_/-}"
 DESCRIPTION="A simple audiofile converter application for the GNOME environment"
@@ -16,8 +16,7 @@ SRC_URI="https://github.com/kassoulet/${PN}/archive/${MY_PV}.tar.gz -> ${P}.tar.
 
 LICENSE="GPL-3"
 SLOT="0"
-KEYWORDS="amd64 x86"
-
+KEYWORDS="~amd64 ~x86"
 IUSE="aac flac mp3 ogg opus vorbis"
 
 # gst-plugins-meta for any decoders, USE flags for specific encoders used by code
@@ -47,18 +46,54 @@ BDEPEND="
 	$(python_gen_cond_dep '
 		dev-python/python-distutils-extra[${PYTHON_USEDEP}]
 	')
+	test? (
+		media-plugins/gst-plugins-flac:1.0
+		media-libs/gst-plugins-bad:1.0
+		media-libs/gst-plugins-ugly:1.0
+		media-plugins/gst-plugins-lame:1.0
+		media-plugins/gst-plugins-faac:1.0
+		media-plugins/gst-plugins-opus:1.0
+	)
 "
 
+# Before PEP517: tests seem to hang and also fail to find fdkaacenc from gst?
+# After: need to trick it into finding the data (inc. glade files)
+RESTRICT="test"
+
 python_prepare_all() {
+	gnome2_environment_reset
 	distutils-r1_python_prepare_all
-	rm -v "${S}/CHANGELOG.old"
+
+	rm -v "${S}/CHANGELOG.old" || die
+
 	# workaround incorrect behavior when LINGUAS is set to an empty string
 	# https://bugs.launchpad.net/python-distutils-extra/+bug/1133594
 	! [[ -v LINGUAS && -z ${LINGUAS} ]] || rm po/*.po || die
 }
 
+src_test() {
+	virtx distutils-r1_src_test
+}
+
+python_test() {
+	export GSETTINGS_SCHEMA_DIR="${S}/data"
+	"${BROOT}${GLIB_COMPILE_SCHEMAS}" --allow-any-name "${S}"/data || die
+
+	"${EPYTHON}" tests/test.py || die
+}
+
 python_install_all() {
-	rm -v "${D}/usr/share/glib-2.0/schemas/gschemas.compiled"
-	mv -v "${D}/usr/share/doc/${PN}" "${D}/usr/share/doc/${P}"
+	rm -v "${ED}"/usr/share/glib-2.0/schemas/gschemas.compiled || die
+	mv -v "${ED}"/usr/share/doc/${PN} "${ED}"/usr/share/doc/${PF} || die
 	distutils-r1_python_install_all
 }
+
+pkg_postrm() {
+	xdg_pkg_postrm
+	gnome2_schemas_update
+}
+
+pkg_postinst() {
+	xdg_pkg_postinst
+	gnome2_schemas_update
+}


             reply	other threads:[~2022-05-31  4:07 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-31  4:07 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-04-14  2:57 [gentoo-commits] repo/gentoo:master commit in: media-sound/soundconverter/ Pacho Ramos
2024-06-16 10:16 Pacho Ramos
2024-06-16 10:16 Pacho Ramos
2023-08-17  2:55 Sam James
2023-05-03  5:05 Sam James
2022-07-29 21:39 David Seifert
2022-06-18 16:57 Agostino Sarubbo
2022-06-18 16:54 Agostino Sarubbo
2022-05-31  6:54 Sam James
2022-05-31  4:23 Sam James
2022-05-31  4:07 Sam James
2021-07-06 22:07 Pacho Ramos
2020-12-05 18:09 Pacho Ramos
2020-06-13 15:09 Pacho Ramos
2020-02-09 16:31 Michał Górny
2019-05-19 18:07 Mart Raudsepp
2019-05-19 15:48 Thomas Deutschmann
2019-04-20 17:46 Mikle Kolyada
2019-04-19 11:09 Mart Raudsepp
2019-03-26 18:52 Aaron Bauman
2018-07-31  7:12 Mart Raudsepp
2018-07-31  0:43 Thomas Deutschmann
2018-07-16 14:01 Mikle Kolyada
2018-06-21 15:04 Mart Raudsepp
2018-02-14 18:10 Mart Raudsepp
2018-02-14 16:57 Jason Zaman
2018-02-06 15:10 Thomas Deutschmann
2017-12-24 15:15 Mart Raudsepp
2016-03-06 20:52 Mikle Kolyada
2016-02-21 23:44 Pacho Ramos
2016-02-21  9:37 Pacho Ramos
2016-02-21  9:37 Pacho Ramos
2015-09-07 21:55 Mikle Kolyada
2015-09-05 14:36 Pacho Ramos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1653970020.5faee21836cdcd724ca89df47ae28620d5a56ad9.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox