From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: gnome-base/gnome-shell/, gnome-base/gnome-shell/files/
Date: Tue, 17 May 2022 21:59:14 +0000 (UTC) [thread overview]
Message-ID: <1652824732.042dabffb96f3b8fd74e0cbb14c524c81e7304df.sam@gentoo> (raw)
commit: 042dabffb96f3b8fd74e0cbb14c524c81e7304df
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Tue May 17 21:58:52 2022 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Tue May 17 21:58:52 2022 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=042dabff
gnome-base/gnome-shell: backport new Polkit patch (g_autoptr)
Closes: https://bugs.gentoo.org/844919
Signed-off-by: Sam James <sam <AT> gentoo.org>
.../gnome-shell/files/42.1-polkit-g_autoptr.patch | 53 ++++++++++++++++++++++
gnome-base/gnome-shell/gnome-shell-42.1-r1.ebuild | 3 ++
2 files changed, 56 insertions(+)
diff --git a/gnome-base/gnome-shell/files/42.1-polkit-g_autoptr.patch b/gnome-base/gnome-shell/files/42.1-polkit-g_autoptr.patch
new file mode 100644
index 000000000000..78d3de086260
--- /dev/null
+++ b/gnome-base/gnome-shell/files/42.1-polkit-g_autoptr.patch
@@ -0,0 +1,53 @@
+https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/1d0a08b5e25fea7b0e792ec9798e68a7c5606a75
+https://bugs.gentoo.org/844919
+
+From: =?UTF-8?q?Florian=20M=C3=BCllner?= <fmuellner@gnome.org>
+Date: Tue, 17 May 2022 15:36:43 +0200
+Subject: [PATCH] build: Do not redefine polkit autocleanup
+
+PolkitAgent recently added autocleanup functions itself, so check
+for their existence at configure time and only define our own when
+they don't exist upstream.
+
+https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5490
+
+Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2296>
+--- a/config.h.meson
++++ b/config.h.meson
+@@ -33,3 +33,6 @@
+
+ /* Define if fdwalk is available in libc */
+ #mesondefine HAVE_FDWALK
++
++/* Define if polkit defines autocleanup functions */
++#mesondefine HAVE_POLKIT_AUTOCLEANUP
+--- a/meson.build
++++ b/meson.build
+@@ -169,6 +169,13 @@ cdata.set('HAVE_FDWALK',
+ cc.has_function('fdwalk')
+ )
+
++polkit_has_autocleanup = cc.compiles(
++ '#define POLKIT_AGENT_I_KNOW_API_IS_SUBJECT_TO_CHANGE
++ #include <polkitagent/polkitagent.h>
++ void main(void) { g_autoptr(PolkitAgentListener) agent = NULL; }',
++ dependencies: polkit_dep)
++cdata.set('HAVE_POLKIT_AUTOCLEANUP', polkit_has_autocleanup)
++
+ buildtype = get_option('buildtype')
+ if buildtype != 'plain'
+ all_warnings = [
+--- a/src/shell-polkit-authentication-agent.h
++++ b/src/shell-polkit-authentication-agent.h
+@@ -14,8 +14,10 @@
+
+ G_BEGIN_DECLS
+
++#ifndef HAVE_POLKIT_AUTOCLEANUP
+ /* Polkit doesn't have g_autoptr support, thus we have to manually set the autoptr function here */
+ G_DEFINE_AUTOPTR_CLEANUP_FUNC (PolkitAgentListener, g_object_unref)
++#endif
+
+ #define SHELL_TYPE_POLKIT_AUTHENTICATION_AGENT (shell_polkit_authentication_agent_get_type())
+
+GitLab
diff --git a/gnome-base/gnome-shell/gnome-shell-42.1-r1.ebuild b/gnome-base/gnome-shell/gnome-shell-42.1-r1.ebuild
index db6f1390fcef..7a1cc841e4f9 100644
--- a/gnome-base/gnome-shell/gnome-shell-42.1-r1.ebuild
+++ b/gnome-base/gnome-shell/gnome-shell-42.1-r1.ebuild
@@ -140,6 +140,9 @@ PATCHES=(
"${FILESDIR}"/42.0-optional-bluetooth.patch
# Change favorites defaults, bug #479918
"${FILESDIR}"/40.0-defaults.patch
+
+ # Upstream backport, bug #844919
+ "${FILESDIR}"/42.1-polkit-g_autoptr.patch
)
src_prepare() {
next reply other threads:[~2022-05-17 21:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 21:59 Sam James [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-01-26 17:32 [gentoo-commits] repo/gentoo:master commit in: gnome-base/gnome-shell/, gnome-base/gnome-shell/files/ Pacho Ramos
2022-06-24 3:43 Sam James
2022-03-28 15:17 Matt Turner
2022-03-20 19:54 Matt Turner
2022-01-25 0:49 Sam James
2020-08-13 20:39 Mart Raudsepp
2020-07-12 21:32 Mart Raudsepp
2019-03-30 22:33 Mart Raudsepp
2019-02-28 22:39 Mart Raudsepp
2016-11-12 0:37 Gilles Dartiguelongue
2016-06-27 14:06 Alexandre Rostovtsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1652824732.042dabffb96f3b8fd74e0cbb14c524c81e7304df.sam@gentoo \
--to=sam@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox