From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 48D5E158090 for ; Wed, 4 May 2022 02:33:08 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 694ACE0788; Wed, 4 May 2022 02:33:07 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 4B6AEE0788 for ; Wed, 4 May 2022 02:33:07 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 1916A341B1D for ; Wed, 4 May 2022 02:33:06 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 81FEC448 for ; Wed, 4 May 2022 02:33:04 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1651631560.7bb73255629cc4999ff198fda276d593657609b8.sam@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: sys-auth/polkit/files/, sys-auth/polkit/ X-VCS-Repository: repo/gentoo X-VCS-Files: sys-auth/polkit/files/polkit-0.120_p20220221-pkexec-suid.patch sys-auth/polkit/polkit-0.120_p20220221-r1.ebuild X-VCS-Directories: sys-auth/polkit/files/ sys-auth/polkit/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 7bb73255629cc4999ff198fda276d593657609b8 X-VCS-Branch: master Date: Wed, 4 May 2022 02:33:04 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 2d20d597-5e16-4fe7-95db-e02a49258010 X-Archives-Hash: a22b20e3ad329b17544736b6b57fd132 commit: 7bb73255629cc4999ff198fda276d593657609b8 Author: Sam James gentoo org> AuthorDate: Wed May 4 02:32:40 2022 +0000 Commit: Sam James gentoo org> CommitDate: Wed May 4 02:32:40 2022 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7bb73255 sys-auth/polkit: backport pkexec help/version fix (fixes gparted) Closes: https://bugs.gentoo.org/827884 Signed-off-by: Sam James gentoo.org> .../files/polkit-0.120_p20220221-pkexec-suid.patch | 67 +++++++++++ sys-auth/polkit/polkit-0.120_p20220221-r1.ebuild | 129 +++++++++++++++++++++ 2 files changed, 196 insertions(+) diff --git a/sys-auth/polkit/files/polkit-0.120_p20220221-pkexec-suid.patch b/sys-auth/polkit/files/polkit-0.120_p20220221-pkexec-suid.patch new file mode 100644 index 000000000000..959656b158a1 --- /dev/null +++ b/sys-auth/polkit/files/polkit-0.120_p20220221-pkexec-suid.patch @@ -0,0 +1,67 @@ +https://gitlab.freedesktop.org/polkit/polkit/-/commit/7d4b52c4d71c46049d87a0775de695ea914f3f1b +https://gitlab.freedesktop.org/polkit/polkit/-/merge_requests/113 +https://bugs.gentoo.org/827884 + +From: Matt Turner +Date: Tue, 3 May 2022 12:54:37 +0000 +Subject: [PATCH] pkexec: Allow --version and --help even if not setuid root + +--- a/src/programs/pkexec.c ++++ b/src/programs/pkexec.c +@@ -514,27 +514,6 @@ main (int argc, char *argv[]) + /* Disable remote file access from GIO. */ + setenv ("GIO_USE_VFS", "local", 1); + +- /* check for correct invocation */ +- if (geteuid () != 0) +- { +- g_printerr ("pkexec must be setuid root\n"); +- goto out; +- } +- +- original_user_name = g_strdup (g_get_user_name ()); +- if (original_user_name == NULL) +- { +- g_printerr ("Error getting user name.\n"); +- goto out; +- } +- +- if ((original_cwd = g_get_current_dir ()) == NULL) +- { +- g_printerr ("Error getting cwd: %s\n", +- g_strerror (errno)); +- goto out; +- } +- + /* First process options and find the command-line to invoke. Avoid using fancy library routines + * that depend on environtment variables since we haven't cleared the environment just yet. + */ +@@ -595,6 +574,27 @@ main (int argc, char *argv[]) + goto out; + } + ++ /* check for correct invocation */ ++ if (geteuid () != 0) ++ { ++ g_printerr ("pkexec must be setuid root\n"); ++ goto out; ++ } ++ ++ original_user_name = g_strdup (g_get_user_name ()); ++ if (original_user_name == NULL) ++ { ++ g_printerr ("Error getting user name.\n"); ++ goto out; ++ } ++ ++ if ((original_cwd = g_get_current_dir ()) == NULL) ++ { ++ g_printerr ("Error getting cwd: %s\n", ++ g_strerror (errno)); ++ goto out; ++ } ++ + if (opt_user == NULL) + opt_user = g_strdup ("root"); + +GitLab diff --git a/sys-auth/polkit/polkit-0.120_p20220221-r1.ebuild b/sys-auth/polkit/polkit-0.120_p20220221-r1.ebuild new file mode 100644 index 000000000000..a1b8221ce450 --- /dev/null +++ b/sys-auth/polkit/polkit-0.120_p20220221-r1.ebuild @@ -0,0 +1,129 @@ +# Copyright 1999-2022 Gentoo Authors +# Distributed under the terms of the GNU General Public License v2 + +EAPI=7 + +inherit meson pam pax-utils systemd xdg-utils + +DESCRIPTION="Policy framework for controlling privileges for system-wide services" +HOMEPAGE="https://www.freedesktop.org/wiki/Software/polkit https://gitlab.freedesktop.org/polkit/polkit" +if [[ ${PV} == *_p* ]] ; then + MY_COMMIT="b10a1bdb697045db40774f2a9a8c58ae5c7189c3" + SRC_URI="https://gitlab.freedesktop.org/polkit/polkit/-/archive/${MY_COMMIT}/polkit-${MY_COMMIT}.tar.bz2 -> ${P}.tar.bz2" + S="${WORKDIR}"/${PN}-${MY_COMMIT} +else + SRC_URI="https://www.freedesktop.org/software/${PN}/releases/${P}.tar.gz" +fi + +LICENSE="LGPL-2" +SLOT="0" +KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~hppa ~ia64 ~loong ~mips ~ppc ~ppc64 ~riscv ~s390 ~sparc ~x86" +IUSE="+duktape examples gtk +introspection kde pam selinux systemd test" +#RESTRICT="!test? ( test )" +# Tests currently don't work with meson. See +# https://gitlab.freedesktop.org/polkit/polkit/-/issues/144 +RESTRICT="test" + +BDEPEND=" + acct-user/polkitd + app-text/docbook-xml-dtd:4.1.2 + app-text/docbook-xsl-stylesheets + dev-libs/glib + dev-libs/gobject-introspection-common + dev-libs/libxslt + dev-util/glib-utils + sys-devel/gettext + virtual/pkgconfig + introspection? ( dev-libs/gobject-introspection ) +" +DEPEND=" + dev-libs/glib:2 + dev-libs/expat + duktape? ( dev-lang/duktape:= ) + !duktape? ( dev-lang/spidermonkey:91[-debug] ) + pam? ( + sys-auth/pambase + sys-libs/pam + ) + !pam? ( virtual/libcrypt:= ) + systemd? ( sys-apps/systemd:0=[policykit] ) + !systemd? ( sys-auth/elogind ) +" +RDEPEND="${DEPEND} + acct-user/polkitd + selinux? ( sec-policy/selinux-policykit ) +" +PDEPEND=" + gtk? ( || ( + >=gnome-extra/polkit-gnome-0.105 + >=lxde-base/lxsession-0.5.2 + ) ) + kde? ( kde-plasma/polkit-kde-agent ) +" + +DOCS=( docs/TODO HACKING NEWS README ) + +QA_MULTILIB_PATHS=" + usr/lib/polkit-1/polkit-agent-helper-1 + usr/lib/polkit-1/polkitd" + +src_prepare() { + local PATCHES=( + # musl + "${FILESDIR}"/${PN}-0.118-make-netgroup-support-optional.patch + # In next release + "${FILESDIR}"/${P}-pkexec-suid.patch + + # Pending upstream + "${FILESDIR}"/${PN}-0.120-meson.patch + ) + + default + + # bug #401513 + sed -i -e 's|unix-group:wheel|unix-user:0|' src/polkitbackend/*-default.rules || die +} + +src_configure() { + xdg_environment_reset + + local emesonargs=( + --localstatedir="${EPREFIX}"/var + -Dauthfw="$(usex pam pam shadow)" + -Dexamples=false + -Dgtk_doc=false + -Dman=true + -Dos_type=gentoo + -Dsession_tracking="$(usex systemd libsystemd-login libelogind)" + -Dsystemdsystemunitdir="$(systemd_get_systemunitdir)" + -Djs_engine=$(usex duktape duktape mozjs) + $(meson_use introspection) + $(meson_use test tests) + $(usex pam "-Dpam_module_dir=$(getpam_mod_dir)" '') + ) + meson_src_configure +} + +src_compile() { + meson_src_compile + + # Required for polkitd on hardened/PaX due to spidermonkey's JIT + pax-mark mr src/polkitbackend/.libs/polkitd test/polkitbackend/.libs/polkitbackendjsauthoritytest +} + +src_install() { + meson_src_install + + if use examples ; then + docinto examples + dodoc src/examples/{*.c,*.policy*} + fi + + diropts -m 0700 -o polkitd + keepdir /usr/share/polkit-1/rules.d +} + +pkg_postinst() { + chmod 0700 "${EROOT}"/{etc,usr/share}/polkit-1/rules.d + chown polkitd "${EROOT}"/{etc,usr/share}/polkit-1/rules.d +}