From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 6D0BB158020 for ; Sun, 20 Nov 2022 00:21:30 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4A786E0A7C; Sun, 20 Nov 2022 00:21:29 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2FBC1E0A7C for ; Sun, 20 Nov 2022 00:21:29 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 20B2A341233 for ; Sun, 20 Nov 2022 00:21:28 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 6A8B3757 for ; Sun, 20 Nov 2022 00:21:26 +0000 (UTC) From: "Matt Turner" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Matt Turner" Message-ID: <1650497050.05b1f53a03e6e4ca9373cbd280c4e22ed234ac4f.mattst88@gentoo> Subject: [gentoo-commits] proj/catalyst:wip/mattst88 commit in: targets/support/ X-VCS-Repository: proj/catalyst X-VCS-Files: targets/support/create-iso.sh X-VCS-Directories: targets/support/ X-VCS-Committer: mattst88 X-VCS-Committer-Name: Matt Turner X-VCS-Revision: 05b1f53a03e6e4ca9373cbd280c4e22ed234ac4f X-VCS-Branch: wip/mattst88 Date: Sun, 20 Nov 2022 00:21:26 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 62e8cecb-8e9e-4701-8d58-77e6975af122 X-Archives-Hash: 728abf00c5a60484b4b09fad053a6438 commit: 05b1f53a03e6e4ca9373cbd280c4e22ed234ac4f Author: Daniel Cordero 0xdc io> AuthorDate: Tue Apr 19 17:40:15 2022 +0000 Commit: Matt Turner gentoo org> CommitDate: Wed Apr 20 23:24:10 2022 +0000 URL: https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=05b1f53a create-iso.sh: split iso-level arguments When enclosed in quotes and expanded with "${variable[@]}", the word is expanded to be a single argument, rather than two separate arguments. i.e. argv[2] = "-iso-level 3" instead of argv[2] = "-iso-level" argv[3] = "3" This lead to the failure: xorriso : FAILURE : -as mkisofs: Unrecognized option '-iso-level 3' xorriso : aborting : -abort_on 'FAILURE' encountered 'FAILURE' grub-mkrescue: error: `xorriso` invocation failed Fixes: 0b56dbe4 ("livecd: Use ISO level 3") Signed-off-by: Matt Turner gentoo.org> targets/support/create-iso.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/targets/support/create-iso.sh b/targets/support/create-iso.sh index 45ef1696..9991b930 100755 --- a/targets/support/create-iso.sh +++ b/targets/support/create-iso.sh @@ -194,7 +194,7 @@ case ${clst_hostarch} in amd64|arm64|ia64|ppc*|powerpc*|sparc*|x86) isoroot_checksum - extra_opts=("-joliet" "-iso-level 3") + extra_opts=("-joliet" "-iso-level" "3") case ${clst_hostarch} in sparc*) extra_opts+=("--sparc-boot") ;; esac From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 859AF15808D for ; Wed, 20 Apr 2022 23:26:46 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 52D43E0895; Wed, 20 Apr 2022 23:26:45 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 84A06E0895 for ; Wed, 20 Apr 2022 23:26:44 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 085C63411DE for ; Wed, 20 Apr 2022 23:26:43 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 7F2D03B0 for ; Wed, 20 Apr 2022 23:26:41 +0000 (UTC) From: "Matt Turner" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Matt Turner" Message-ID: <1650497050.05b1f53a03e6e4ca9373cbd280c4e22ed234ac4f.mattst88@gentoo> Subject: [gentoo-commits] proj/catalyst:master commit in: targets/support/ X-VCS-Repository: proj/catalyst X-VCS-Files: targets/support/create-iso.sh X-VCS-Directories: targets/support/ X-VCS-Committer: mattst88 X-VCS-Committer-Name: Matt Turner X-VCS-Revision: 05b1f53a03e6e4ca9373cbd280c4e22ed234ac4f X-VCS-Branch: master Date: Wed, 20 Apr 2022 23:26:41 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 2b3b4602-4443-4331-a321-17b08b053649 X-Archives-Hash: 62e70aaec26ccb4eb15391810d609a4c Message-ID: <20220420232641.K6hr8rvqDEiojfsaV9ET7djAXMbvzWV96wGYQ6rF47U@z> commit: 05b1f53a03e6e4ca9373cbd280c4e22ed234ac4f Author: Daniel Cordero 0xdc io> AuthorDate: Tue Apr 19 17:40:15 2022 +0000 Commit: Matt Turner gentoo org> CommitDate: Wed Apr 20 23:24:10 2022 +0000 URL: https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=05b1f53a create-iso.sh: split iso-level arguments When enclosed in quotes and expanded with "${variable[@]}", the word is expanded to be a single argument, rather than two separate arguments. i.e. argv[2] = "-iso-level 3" instead of argv[2] = "-iso-level" argv[3] = "3" This lead to the failure: xorriso : FAILURE : -as mkisofs: Unrecognized option '-iso-level 3' xorriso : aborting : -abort_on 'FAILURE' encountered 'FAILURE' grub-mkrescue: error: `xorriso` invocation failed Fixes: 0b56dbe4 ("livecd: Use ISO level 3") Signed-off-by: Matt Turner gentoo.org> targets/support/create-iso.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/targets/support/create-iso.sh b/targets/support/create-iso.sh index 45ef1696..9991b930 100755 --- a/targets/support/create-iso.sh +++ b/targets/support/create-iso.sh @@ -194,7 +194,7 @@ case ${clst_hostarch} in amd64|arm64|ia64|ppc*|powerpc*|sparc*|x86) isoroot_checksum - extra_opts=("-joliet" "-iso-level 3") + extra_opts=("-joliet" "-iso-level" "3") case ${clst_hostarch} in sparc*) extra_opts+=("--sparc-boot") ;; esac