From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 1AF3B15808B for ; Fri, 8 Apr 2022 18:04:31 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 05329E08CD; Fri, 8 Apr 2022 18:04:30 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 81A4CE08CD for ; Fri, 8 Apr 2022 18:04:28 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 2673E341213 for ; Fri, 8 Apr 2022 18:04:27 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 768F0389 for ; Fri, 8 Apr 2022 18:04:25 +0000 (UTC) From: "Matt Turner" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Matt Turner" Message-ID: <1649441060.e1b75bb5ecb953f5501cce82dabe07994aff338f.mattst88@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: gnome-base/gnome-control-center/files/, gnome-base/gnome-control-center/ X-VCS-Repository: repo/gentoo X-VCS-Files: gnome-base/gnome-control-center/files/42.0-online-accounts-Fix-goa-helper-on-X11.patch gnome-base/gnome-control-center/gnome-control-center-42.0-r1.ebuild gnome-base/gnome-control-center/gnome-control-center-42.0.ebuild X-VCS-Directories: gnome-base/gnome-control-center/files/ gnome-base/gnome-control-center/ X-VCS-Committer: mattst88 X-VCS-Committer-Name: Matt Turner X-VCS-Revision: e1b75bb5ecb953f5501cce82dabe07994aff338f X-VCS-Branch: master Date: Fri, 8 Apr 2022 18:04:25 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 71ef052e-10c1-43d1-af88-0aa142f8de85 X-Archives-Hash: 9ae94183a2e4d98365a644d3717102fe commit: e1b75bb5ecb953f5501cce82dabe07994aff338f Author: Matt Turner gentoo org> AuthorDate: Fri Apr 8 18:03:29 2022 +0000 Commit: Matt Turner gentoo org> CommitDate: Fri Apr 8 18:04:20 2022 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e1b75bb5 gnome-base/gnome-control-center: Add patch to fix goa-helper on X11 Signed-off-by: Matt Turner gentoo.org> ...2.0-online-accounts-Fix-goa-helper-on-X11.patch | 32 ++++++++++++++++++++++ ....ebuild => gnome-control-center-42.0-r1.ebuild} | 2 ++ 2 files changed, 34 insertions(+) diff --git a/gnome-base/gnome-control-center/files/42.0-online-accounts-Fix-goa-helper-on-X11.patch b/gnome-base/gnome-control-center/files/42.0-online-accounts-Fix-goa-helper-on-X11.patch new file mode 100644 index 000000000000..dfa56eab9e61 --- /dev/null +++ b/gnome-base/gnome-control-center/files/42.0-online-accounts-Fix-goa-helper-on-X11.patch @@ -0,0 +1,32 @@ +From 7fe322b9cedae313cd9af6f403eab9bfc6027674 Mon Sep 17 00:00:00 2001 +From: Jan Tojnar +Date: Mon, 28 Mar 2022 21:02:23 +0200 +Subject: [PATCH] online-accounts: Fix goa-helper on X11 +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +The handle_str contains the “x11:” prefix so strtol would return 0. +We need to pass it the numeric substring. + +Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1651 +--- + panels/online-accounts/gnome-control-center-goa-helper.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/panels/online-accounts/gnome-control-center-goa-helper.c b/panels/online-accounts/gnome-control-center-goa-helper.c +index 56513147e..533609cbc 100644 +--- a/panels/online-accounts/gnome-control-center-goa-helper.c ++++ b/panels/online-accounts/gnome-control-center-goa-helper.c +@@ -129,7 +129,7 @@ set_external_parent_from_handle (GtkApplication *application, + int xid; + + errno = 0; +- xid = strtol (handle_str, NULL, 16); ++ xid = strtol (handle_str + strlen (x11_prefix), NULL, 16); + if (errno != 0) + { + g_warning ("Failed to reference external X11 window, invalid XID %s", handle_str); +-- +2.35.1 + diff --git a/gnome-base/gnome-control-center/gnome-control-center-42.0.ebuild b/gnome-base/gnome-control-center/gnome-control-center-42.0-r1.ebuild similarity index 98% rename from gnome-base/gnome-control-center/gnome-control-center-42.0.ebuild rename to gnome-base/gnome-control-center/gnome-control-center-42.0-r1.ebuild index 43a08b3e178c..70008f3ef6ff 100644 --- a/gnome-base/gnome-control-center/gnome-control-center-42.0.ebuild +++ b/gnome-base/gnome-control-center/gnome-control-center-42.0-r1.ebuild @@ -118,6 +118,8 @@ BDEPEND=" " PATCHES=( + "${FILESDIR}"/${PV}-online-accounts-Fix-goa-helper-on-X11.patch + # Patches from gnome-40 branch on top of 40.0 # Makes some panels and dependencies optional # https://bugzilla.gnome.org/686840, 697478, 700145