From: "Matt Turner" <mattst88@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: gnome-base/gnome-control-center/files/, gnome-base/gnome-control-center/
Date: Fri, 8 Apr 2022 18:04:25 +0000 (UTC) [thread overview]
Message-ID: <1649441060.e1b75bb5ecb953f5501cce82dabe07994aff338f.mattst88@gentoo> (raw)
commit: e1b75bb5ecb953f5501cce82dabe07994aff338f
Author: Matt Turner <mattst88 <AT> gentoo <DOT> org>
AuthorDate: Fri Apr 8 18:03:29 2022 +0000
Commit: Matt Turner <mattst88 <AT> gentoo <DOT> org>
CommitDate: Fri Apr 8 18:04:20 2022 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e1b75bb5
gnome-base/gnome-control-center: Add patch to fix goa-helper on X11
Signed-off-by: Matt Turner <mattst88 <AT> gentoo.org>
...2.0-online-accounts-Fix-goa-helper-on-X11.patch | 32 ++++++++++++++++++++++
....ebuild => gnome-control-center-42.0-r1.ebuild} | 2 ++
2 files changed, 34 insertions(+)
diff --git a/gnome-base/gnome-control-center/files/42.0-online-accounts-Fix-goa-helper-on-X11.patch b/gnome-base/gnome-control-center/files/42.0-online-accounts-Fix-goa-helper-on-X11.patch
new file mode 100644
index 000000000000..dfa56eab9e61
--- /dev/null
+++ b/gnome-base/gnome-control-center/files/42.0-online-accounts-Fix-goa-helper-on-X11.patch
@@ -0,0 +1,32 @@
+From 7fe322b9cedae313cd9af6f403eab9bfc6027674 Mon Sep 17 00:00:00 2001
+From: Jan Tojnar <jtojnar@gmail.com>
+Date: Mon, 28 Mar 2022 21:02:23 +0200
+Subject: [PATCH] online-accounts: Fix goa-helper on X11
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+The handle_str contains the “x11:” prefix so strtol would return 0.
+We need to pass it the numeric substring.
+
+Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1651
+---
+ panels/online-accounts/gnome-control-center-goa-helper.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/panels/online-accounts/gnome-control-center-goa-helper.c b/panels/online-accounts/gnome-control-center-goa-helper.c
+index 56513147e..533609cbc 100644
+--- a/panels/online-accounts/gnome-control-center-goa-helper.c
++++ b/panels/online-accounts/gnome-control-center-goa-helper.c
+@@ -129,7 +129,7 @@ set_external_parent_from_handle (GtkApplication *application,
+ int xid;
+
+ errno = 0;
+- xid = strtol (handle_str, NULL, 16);
++ xid = strtol (handle_str + strlen (x11_prefix), NULL, 16);
+ if (errno != 0)
+ {
+ g_warning ("Failed to reference external X11 window, invalid XID %s", handle_str);
+--
+2.35.1
+
diff --git a/gnome-base/gnome-control-center/gnome-control-center-42.0.ebuild b/gnome-base/gnome-control-center/gnome-control-center-42.0-r1.ebuild
similarity index 98%
rename from gnome-base/gnome-control-center/gnome-control-center-42.0.ebuild
rename to gnome-base/gnome-control-center/gnome-control-center-42.0-r1.ebuild
index 43a08b3e178c..70008f3ef6ff 100644
--- a/gnome-base/gnome-control-center/gnome-control-center-42.0.ebuild
+++ b/gnome-base/gnome-control-center/gnome-control-center-42.0-r1.ebuild
@@ -118,6 +118,8 @@ BDEPEND="
"
PATCHES=(
+ "${FILESDIR}"/${PV}-online-accounts-Fix-goa-helper-on-X11.patch
+
# Patches from gnome-40 branch on top of 40.0
# Makes some panels and dependencies optional
# https://bugzilla.gnome.org/686840, 697478, 700145
next reply other threads:[~2022-04-08 18:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 18:04 Matt Turner [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-28 20:44 [gentoo-commits] repo/gentoo:master commit in: gnome-base/gnome-control-center/files/, gnome-base/gnome-control-center/ Mart Raudsepp
2019-03-30 21:56 Mart Raudsepp
2019-03-14 21:52 Mart Raudsepp
2019-02-28 20:29 Mart Raudsepp
2019-02-24 9:51 Mart Raudsepp
2017-12-08 19:05 Michał Górny
2017-07-14 2:46 Mart Raudsepp
2017-03-08 12:11 Mart Raudsepp
2016-11-02 23:39 Gilles Dartiguelongue
2016-11-01 11:18 Gilles Dartiguelongue
2015-11-14 13:48 Pacho Ramos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1649441060.e1b75bb5ecb953f5501cce82dabe07994aff338f.mattst88@gentoo \
--to=mattst88@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox