public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Lars Wendler" <polynomial-c@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: sys-libs/liburing/
Date: Mon, 28 Mar 2022 19:31:52 +0000 (UTC)	[thread overview]
Message-ID: <1648495894.8aeeba04d1e08aa74cf50e402eb37477e402ec33.polynomial-c@gentoo> (raw)

commit:     8aeeba04d1e08aa74cf50e402eb37477e402ec33
Author:     Jeremi Piotrowski <jpiotrowski <AT> microsoft <DOT> com>
AuthorDate: Thu Mar 24 11:17:22 2022 +0000
Commit:     Lars Wendler <polynomial-c <AT> gentoo <DOT> org>
CommitDate: Mon Mar 28 19:31:34 2022 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8aeeba04

sys-libs/liburing: pass --cxx paramter to configure

Provide the correct value to --cxx to fix cross-compilation. liburing uses the
value of the cxx variable for linking. This happens to work for native builds
but breaks when cross-compiling, as evidenced by the below output (from
Flatcar):

>>> Configuring source in /build/arm64-usr/var/tmp/portage/sys-libs/liburing-2.1-r1/work/liburing-2.1 ...
 * .arm64: running multilib-minimal_abi_src_configure
prefix                        /usr
includedir                    /usr/include
libdir                        /usr/lib64
libdevdir                     /usr/lib64
relativelibdir
mandir                        /usr/share/man
datadir                       /usr/share
stringop_overflow             yes
array_bounds                  yes
__kernel_rwf_t                yes
__kernel_timespec             yes
open_how                      no
statx                         yes
C++                           yes
has_ucontext                  yes
CC                            aarch64-cros-linux-gnu-gcc
CXX                           g++

...

aarch64-cros-linux-gnu-gcc -D_GNU_SOURCE -D__SANE_USERSPACE_TYPES__ -I../src/include/ -include ../config-host.h -O2 -pipe -mtune=generic -g -D_GNU_SOURCE -Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -L../src/ -o statx statx.c helpers.o -luring -Wstringop-overflow=0 -Warray-bounds=0
g++ -D_GNU_SOURCE -D__SANE_USERSPACE_TYPES__ -I../src/include/ -include ../config-host.h -O2 -pipe -mtune=generic -g -O2 -pipe -mtune=generic -g -D_GNU_SOURCE -Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -L../src/ -std=c++11 -o sq-full-cpp sq-full-cpp.cc helpers.o -luring -Wstringop-overflow=0 -Warray-bounds=0
/usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: Relocations in generic ELF (EM: 183)
/usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: Relocations in generic ELF (EM: 183)
/usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: Relocations in generic ELF (EM: 183)
/usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: Relocations in generic ELF (EM: 183)
/usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: Relocations in generic ELF (EM: 183)
/usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: Relocations in generic ELF (EM: 183)
/usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: helpers.o: error adding symbols: file in wrong format
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:165: sq-full-cpp] Error 1
make[1]: *** Waiting for unfinished jobs....

Bug: https://bugs.gentoo.org/836316
Signed-off-by: Jeremi Piotrowski <jpiotrowski <AT> microsoft.com>
Closes: https://github.com/gentoo/gentoo/pull/24733
Signed-off-by: Lars Wendler <polynomial-c <AT> gentoo.org>

 sys-libs/liburing/liburing-2.1-r1.ebuild | 1 +
 sys-libs/liburing/liburing-2.1-r2.ebuild | 1 +
 sys-libs/liburing/liburing-9999.ebuild   | 1 +
 3 files changed, 3 insertions(+)

diff --git a/sys-libs/liburing/liburing-2.1-r1.ebuild b/sys-libs/liburing/liburing-2.1-r1.ebuild
index ae14b067cbb3..ddf39035944f 100644
--- a/sys-libs/liburing/liburing-2.1-r1.ebuild
+++ b/sys-libs/liburing/liburing-2.1-r1.ebuild
@@ -45,6 +45,7 @@ multilib_src_configure() {
 		--libdevdir="${EPREFIX}/usr/$(get_libdir)"
 		--mandir="${EPREFIX}/usr/share/man"
 		--cc="$(tc-getCC)"
+		--cxx="$(tc-getCXX)"
 	)
 	# No autotools configure! "econf" will fail.
 	TMPDIR="${T}" ./configure "${myconf[@]}"

diff --git a/sys-libs/liburing/liburing-2.1-r2.ebuild b/sys-libs/liburing/liburing-2.1-r2.ebuild
index c65e7baf841c..cb5271810e69 100644
--- a/sys-libs/liburing/liburing-2.1-r2.ebuild
+++ b/sys-libs/liburing/liburing-2.1-r2.ebuild
@@ -51,6 +51,7 @@ multilib_src_configure() {
 		--libdevdir="${EPREFIX}/usr/$(get_libdir)"
 		--mandir="${EPREFIX}/usr/share/man"
 		--cc="$(tc-getCC)"
+		--cxx="$(tc-getCXX)"
 	)
 	# No autotools configure! "econf" will fail.
 	TMPDIR="${T}" ./configure "${myconf[@]}"

diff --git a/sys-libs/liburing/liburing-9999.ebuild b/sys-libs/liburing/liburing-9999.ebuild
index c7427bfe9a0d..87e93eac4554 100644
--- a/sys-libs/liburing/liburing-9999.ebuild
+++ b/sys-libs/liburing/liburing-9999.ebuild
@@ -40,6 +40,7 @@ multilib_src_configure() {
 		--libdevdir="${EPREFIX}/usr/$(get_libdir)"
 		--mandir="${EPREFIX}/usr/share/man"
 		--cc="$(tc-getCC)"
+		--cxx="$(tc-getCXX)"
 	)
 	# No autotools configure! "econf" will fail.
 	TMPDIR="${T}" ./configure "${myconf[@]}"


             reply	other threads:[~2022-03-28 19:31 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28 19:31 Lars Wendler [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-11-01  9:55 [gentoo-commits] repo/gentoo:master commit in: sys-libs/liburing/ Florian Schmaus
2024-10-31 18:39 Florian Schmaus
2024-10-25 11:52 Arthur Zamarin
2024-10-25 11:52 Arthur Zamarin
2024-10-15  1:45 Sam James
2024-09-28 10:27 Arthur Zamarin
2024-09-26  8:26 Arthur Zamarin
2024-09-07  6:13 Arthur Zamarin
2024-08-22 10:11 Florian Schmaus
2024-08-22  9:51 Florian Schmaus
2024-05-06 12:45 Florian Schmaus
2024-05-06 12:40 Florian Schmaus
2023-12-12  8:25 Florian Schmaus
2023-06-10 11:00 Florian Schmaus
2023-06-10 11:00 Florian Schmaus
2023-03-03 17:24 Arthur Zamarin
2023-03-03 17:24 Arthur Zamarin
2023-03-03 17:24 Arthur Zamarin
2023-03-03 17:18 Arthur Zamarin
2023-02-19 12:46 Florian Schmaus
2023-02-13  7:35 Florian Schmaus
2023-01-25 19:20 Arthur Zamarin
2022-11-04  9:17 Florian Schmaus
2022-11-04  9:13 Florian Schmaus
2022-09-19  6:41 Agostino Sarubbo
2022-09-19  6:40 Agostino Sarubbo
2022-09-18 20:30 Arthur Zamarin
2022-09-18 16:19 Arthur Zamarin
2022-09-18 16:11 Arthur Zamarin
2022-09-18 16:11 Arthur Zamarin
2022-09-18 16:11 Arthur Zamarin
2022-07-02 12:21 Agostino Sarubbo
2022-07-02 12:20 Agostino Sarubbo
2022-07-02 12:08 Arthur Zamarin
2022-07-02  7:18 Jakov Smolić
2022-07-02  7:04 Jakov Smolić
2022-07-02  7:02 Jakov Smolić
2022-07-02  7:02 Jakov Smolić
2022-07-01  6:51 Florian Schmaus
2022-07-01  6:51 Florian Schmaus
2022-06-29  7:22 Florian Schmaus
2022-06-29  7:16 Florian Schmaus
2022-05-19  7:28 WANG Xuerui
2022-05-19  7:28 WANG Xuerui
2022-03-14 15:56 Sam James
2022-02-22 15:33 Lars Wendler
2022-02-22 15:33 Lars Wendler
2021-12-01 20:05 Lars Wendler
2021-11-26 19:28 Arthur Zamarin
2021-11-26  8:51 Agostino Sarubbo
2021-11-26  8:51 Agostino Sarubbo
2021-11-26  8:50 Sam James
2021-11-26  6:34 Sam James
2021-11-26  6:34 Sam James
2021-11-26  6:34 Sam James
2021-09-10 12:01 Lars Wendler
2021-09-10 12:01 Lars Wendler
2021-03-11 17:22 Lars Wendler
2021-03-11 17:21 Lars Wendler
2021-03-11 17:21 Lars Wendler
2020-12-17  0:48 Sam James
2020-11-10 17:44 Sam James
2020-11-07  3:49 Georgy Yakovlev
2020-11-06 10:26 Lars Wendler
2020-11-06 10:26 Lars Wendler
2020-10-31 19:38 Piotr Karbowski
2020-10-26  2:51 Sam James
2020-10-25 23:08 Thomas Deutschmann
2020-10-24 11:55 Sam James
2020-07-16  8:43 Lars Wendler
2020-07-16  7:22 Lars Wendler
2020-07-16  3:45 Sam James
2020-07-15  8:10 Lars Wendler
2020-07-06  9:03 Lars Wendler
2020-06-25  9:16 Lars Wendler
2020-06-21 17:13 Agostino Sarubbo
2020-06-21 16:54 Agostino Sarubbo
2020-06-06  9:37 Lars Wendler
2020-05-31  3:44 Matt Turner
2020-05-31  3:44 Matt Turner
2020-05-06  8:01 Lars Wendler
2020-05-06  6:48 Sergei Trofimovich
2020-05-06  6:41 Sergei Trofimovich
2020-05-05 13:46 Lars Wendler
2020-05-02 16:36 Mart Raudsepp
2020-04-16 22:54 Sergei Trofimovich
2020-04-13  8:05 Sergei Trofimovich
2020-04-12 23:19 Sergei Trofimovich
2020-03-02 17:10 Lars Wendler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1648495894.8aeeba04d1e08aa74cf50e402eb37477e402ec33.polynomial-c@gentoo \
    --to=polynomial-c@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox