public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Ionen Wolkens" <ionen@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: app-portage/iwdevtools/files/, app-portage/iwdevtools/
Date: Wed, 16 Mar 2022 14:21:16 +0000 (UTC)	[thread overview]
Message-ID: <1647440466.fcdde1d0bc3279dacc5bf25aed059b8b40b1efef.ionen@gentoo> (raw)

commit:     fcdde1d0bc3279dacc5bf25aed059b8b40b1efef
Author:     Ionen Wolkens <ionen <AT> gentoo <DOT> org>
AuthorDate: Wed Mar 16 14:02:00 2022 +0000
Commit:     Ionen Wolkens <ionen <AT> gentoo <DOT> org>
CommitDate: Wed Mar 16 14:21:06 2022 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fcdde1d0

app-portage/iwdevtools: backport diff output fix

Another short fix, leaving releases for later and going
straight to stable.

Kind of important fix, in some rare'ish cases a line may not
have been displayed leading to missed information. So new
output may be available.

Thanks-to: Joonas Niilola <juippis <AT> gentoo.org>
Signed-off-by: Ionen Wolkens <ionen <AT> gentoo.org>

 .../files/iwdevtools-0.10.1-diff-off-by-one.patch    | 20 ++++++++++++++++++++
 ...-0.10.1-r1.ebuild => iwdevtools-0.10.1-r2.ebuild} |  1 +
 2 files changed, 21 insertions(+)

diff --git a/app-portage/iwdevtools/files/iwdevtools-0.10.1-diff-off-by-one.patch b/app-portage/iwdevtools/files/iwdevtools-0.10.1-diff-off-by-one.patch
new file mode 100644
index 000000000000..87564b0b1445
--- /dev/null
+++ b/app-portage/iwdevtools/files/iwdevtools-0.10.1-diff-off-by-one.patch
@@ -0,0 +1,20 @@
+https://github.com/ionenwks/iwdevtools/commit/74d7b913a9bea5cfbf59e451d8db4a4c6140cba8
+From: Ionen Wolkens <ionen@gentoo.org>
+Date: Wed, 16 Mar 2022 09:51:00 -0400
+Subject: [PATCH] qa-vdb: fix off-by-one in diff output
+
+This wrongly assumed f1 array was always at least as big as f2
+
+--- a/scripts/qa-vdb
++++ b/scripts/qa-vdb
+@@ -203,8 +203,8 @@ vdb-get_libdiff() {
+ 	# create combined output
+ 	local -i len=0
+ 	local o mark changes=false
+-	for ((i=0; i < ${#f1[@]}; i++)); do
+-		: "${f2[i]:=}"
++	for ((i=0; i < (${#f1[@]}>${#f2[@]}?${#f1[@]}:${#f2[@]}); i++)); do
++		: "${f1[i]:=}${f2[i]:=}"
+ 		if [[ ${f1[i]} == "${f2[i]}" ]]; then
+ 			${O[full]} || continue
+ 			mark=' '

diff --git a/app-portage/iwdevtools/iwdevtools-0.10.1-r1.ebuild b/app-portage/iwdevtools/iwdevtools-0.10.1-r2.ebuild
similarity index 97%
rename from app-portage/iwdevtools/iwdevtools-0.10.1-r1.ebuild
rename to app-portage/iwdevtools/iwdevtools-0.10.1-r2.ebuild
index bc84297f29a9..c4d90017aac1 100644
--- a/app-portage/iwdevtools/iwdevtools-0.10.1-r1.ebuild
+++ b/app-portage/iwdevtools/iwdevtools-0.10.1-r2.ebuild
@@ -29,6 +29,7 @@ BDEPEND="
 
 PATCHES=(
 	"${FILESDIR}"/${P}-ldpath-regression.patch
+	"${FILESDIR}"/${P}-diff-off-by-one.patch
 )
 
 src_configure() {


             reply	other threads:[~2022-03-16 14:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16 14:21 Ionen Wolkens [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-11-04 16:15 [gentoo-commits] repo/gentoo:master commit in: app-portage/iwdevtools/files/, app-portage/iwdevtools/ Ionen Wolkens
2022-07-11 22:57 Ionen Wolkens
2022-02-25  9:38 Ionen Wolkens
2022-02-06 19:47 Ionen Wolkens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1647440466.fcdde1d0bc3279dacc5bf25aed059b8b40b1efef.ionen@gentoo \
    --to=ionen@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox