From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 62A6815808B for ; Thu, 10 Mar 2022 23:33:32 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id AC482E0901; Thu, 10 Mar 2022 23:33:31 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 361E1E0901 for ; Thu, 10 Mar 2022 23:33:31 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id BC3FD342F93 for ; Thu, 10 Mar 2022 23:33:28 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 1DE98318 for ; Thu, 10 Mar 2022 23:33:27 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1646955197.876646b9ee6fa84f3ed8d225e7ba3442d2da338d.sam@gentoo> Subject: [gentoo-commits] proj/devmanual:master commit in: keywording/ X-VCS-Repository: proj/devmanual X-VCS-Files: keywording/text.xml X-VCS-Directories: keywording/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 876646b9ee6fa84f3ed8d225e7ba3442d2da338d X-VCS-Branch: master Date: Thu, 10 Mar 2022 23:33:27 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 97e0c032-4370-4fcf-a2b3-023f7f7ce180 X-Archives-Hash: 4fbce0ff93a4e7e734674a5b9f8518a1 commit: 876646b9ee6fa84f3ed8d225e7ba3442d2da338d Author: Sam James gentoo org> AuthorDate: Mon Jan 24 04:20:59 2022 +0000 Commit: Sam James gentoo org> CommitDate: Thu Mar 10 23:33:17 2022 +0000 URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=876646b9 keywording: it's preferred to rekeyword packages with new deps It's preferred to rekeyword packages with their new dependencies in the same bug rather than using `package.use.mask` as this means the new code path(s) using the new dependencies get tested rather than just the new package/dependency in isolation. Also, no tooling exists for arch testers to automatically remove the relevant mask(s) once keywording is done, so often we end up with stale unnecessary masks remaining in tree. Signed-off-by: Sam James gentoo.org> Closes: https://github.com/gentoo/devmanual/pull/270 Signed-off-by: Sam James gentoo.org> keywording/text.xml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/keywording/text.xml b/keywording/text.xml index f794722..baffaaa 100644 --- a/keywording/text.xml +++ b/keywording/text.xml @@ -239,6 +239,16 @@ with repoman or pkgdev instead please commit with git commit message.

+

+Note that it is preferred to drop keywords on the package and request +rekeywording of it together with its new dependencies within the same bug to +allow the new code path(s) in your package to be tested. This won't happen if +the new dependency is requested for keywording by itself and +package.use.mask is used to mask the relevant new USE flag: only the +new package dependency will be tested by arch testers. Also, the mask has to be +manually removed during the testing process, which is cumbersome. +

+ When committing, make sure that you reference any bugs in the commit message. See for how