public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/devmanual:master commit in: keywording/
Date: Thu, 10 Mar 2022 23:33:27 +0000 (UTC)	[thread overview]
Message-ID: <1646955197.876646b9ee6fa84f3ed8d225e7ba3442d2da338d.sam@gentoo> (raw)

commit:     876646b9ee6fa84f3ed8d225e7ba3442d2da338d
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Mon Jan 24 04:20:59 2022 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Mar 10 23:33:17 2022 +0000
URL:        https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=876646b9

keywording: it's preferred to rekeyword packages with new deps

It's preferred to rekeyword packages with their new dependencies in the
same bug rather than using `package.use.mask` as this means the new
code path(s) using the new dependencies get tested rather than just
the new package/dependency in isolation.

Also, no tooling exists for arch testers to automatically remove
the relevant mask(s) once keywording is done, so often we end up
with stale unnecessary masks remaining in tree.

Signed-off-by: Sam James <sam <AT> gentoo.org>
Closes: https://github.com/gentoo/devmanual/pull/270
Signed-off-by: Sam James <sam <AT> gentoo.org>

 keywording/text.xml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/keywording/text.xml b/keywording/text.xml
index f794722..baffaaa 100644
--- a/keywording/text.xml
+++ b/keywording/text.xml
@@ -239,6 +239,16 @@ with <c>repoman</c> or <c>pkgdev</c> <d/> instead please commit with
 git commit message.
 </p>
 
+<p>
+Note that it is preferred to drop keywords on the package and request
+rekeywording of it together with its new dependencies within the same bug to
+allow the new code path(s) in your package to be tested. This won't happen if
+the new dependency is requested for keywording by itself and
+<c>package.use.mask</c> is used to mask the relevant new USE flag: only the
+new package dependency will be tested by arch testers. Also, the mask has to be
+manually removed during the testing process, which is cumbersome.
+</p>
+
 <important>
 When committing, make sure that you reference any bugs in the commit message.
 See <uri link="::ebuild-maintenance/git/#Git Commit Message Format"/> for how


             reply	other threads:[~2022-03-10 23:33 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10 23:33 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-03-16 14:52 [gentoo-commits] proj/devmanual:master commit in: keywording/ Sam James
2022-03-14 17:07 Matt Turner
2022-02-18 18:19 Sam James
2022-01-22 21:35 Sam James
2022-01-22 21:35 Sam James
2022-01-22 21:35 Sam James
2021-10-13 13:42 Ulrich Müller
2021-10-13 13:42 Ulrich Müller
2021-07-16  9:11 Ulrich Müller
2021-07-03 16:21 Ulrich Müller
2021-04-07 17:35 Ulrich Müller
2021-04-07 17:35 Ulrich Müller
2021-04-07 17:35 Ulrich Müller
2021-04-07 17:35 Ulrich Müller
2021-04-07 17:35 Ulrich Müller
2021-04-07 17:35 Ulrich Müller
2021-04-07 17:35 Ulrich Müller
2021-04-07 17:35 Ulrich Müller
2021-04-07 17:35 Ulrich Müller
2021-04-07 17:35 Ulrich Müller
2021-04-07 17:35 Ulrich Müller
2021-03-30 16:10 Ulrich Müller
2021-03-11 13:16 Ulrich Müller
2021-02-17  9:29 Ulrich Müller
2021-02-17  9:29 Ulrich Müller
2021-02-17  9:29 Ulrich Müller
2021-02-17  9:29 Ulrich Müller
2021-02-15  7:21 Ulrich Müller
2020-07-12 18:32 Ulrich Müller
2020-05-06  7:49 Ulrich Müller
2020-01-25  6:02 Ulrich Müller
2020-01-23 13:50 Ulrich Müller
2018-08-27 15:24 Göktürk Yüksek
2015-06-17 12:05 Ulrich Müller
2015-03-14  9:20 Markos Chandras
2013-02-16  0:03 Markos Chandras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1646955197.876646b9ee6fa84f3ed8d225e7ba3442d2da338d.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox