From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 638BC158086 for ; Wed, 22 Dec 2021 15:38:19 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4D8012BC047; Wed, 22 Dec 2021 15:38:18 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A29BE2BC047 for ; Wed, 22 Dec 2021 15:38:17 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id CAA08342F36 for ; Wed, 22 Dec 2021 15:38:15 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 53E42202 for ; Wed, 22 Dec 2021 15:38:14 +0000 (UTC) From: "Ulrich Müller" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Ulrich Müller" Message-ID: <1640187382.7ce5e147a7ef3b776cb3910c0c21b999f7e2839b.ulm@gentoo> Subject: [gentoo-commits] proj/devmanual:master commit in: ebuild-writing/common-mistakes/ X-VCS-Repository: proj/devmanual X-VCS-Files: ebuild-writing/common-mistakes/text.xml X-VCS-Directories: ebuild-writing/common-mistakes/ X-VCS-Committer: ulm X-VCS-Committer-Name: Ulrich Müller X-VCS-Revision: 7ce5e147a7ef3b776cb3910c0c21b999f7e2839b X-VCS-Branch: master Date: Wed, 22 Dec 2021 15:38:14 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 734ae8f6-ff48-42bc-81ca-1d394ec24a52 X-Archives-Hash: cae12eca47fa3560b6ec857b7a9ca559 commit: 7ce5e147a7ef3b776cb3910c0c21b999f7e2839b Author: Sam James gentoo org> AuthorDate: Sun Aug 1 02:50:13 2021 +0000 Commit: Ulrich Müller gentoo org> CommitDate: Wed Dec 22 15:36:22 2021 +0000 URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=7ce5e147 ebuild-writing/common-mistakes: add calling external tools without die Suggested-by: Joonas Niilola gentoo.org> Signed-off-by: Sam James gentoo.org> [Internal cross reference fixed] Signed-off-by: Ulrich Müller gentoo.org> ebuild-writing/common-mistakes/text.xml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/ebuild-writing/common-mistakes/text.xml b/ebuild-writing/common-mistakes/text.xml index e0cdd12..4e26462 100644 --- a/ebuild-writing/common-mistakes/text.xml +++ b/ebuild-writing/common-mistakes/text.xml @@ -13,6 +13,19 @@ writing ebuilds.
Common Ebuild Writing Mistakes + +Unguarded external calls + + +

+Calls to external tools should be guarded with || die (or use +assert) in almost all cases to allow failure to be detected. +See . +

+ + + + Invalid use of <c>static</c> use-flag