public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: media-gfx/scrot/, media-gfx/scrot/files/
Date: Mon, 20 Dec 2021 00:02:43 +0000 (UTC)	[thread overview]
Message-ID: <1639958534.e3fab0acfbb39f126224b70daf1927e3fe1404f8.sam@gentoo> (raw)

commit:     e3fab0acfbb39f126224b70daf1927e3fe1404f8
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Sun Dec 19 23:58:55 2021 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Mon Dec 20 00:02:14 2021 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e3fab0ac

media-gfx/scrot: respect docdir

Closes: https://bugs.gentoo.org/828928
Signed-off-by: Sam James <sam <AT> gentoo.org>

 media-gfx/scrot/files/scrot-1.7-fix-docdir.patch   | 46 ++++++++++++++++++++++
 .../{scrot-1.7-r1.ebuild => scrot-1.7-r2.ebuild}   | 11 +++++-
 2 files changed, 55 insertions(+), 2 deletions(-)

diff --git a/media-gfx/scrot/files/scrot-1.7-fix-docdir.patch b/media-gfx/scrot/files/scrot-1.7-fix-docdir.patch
new file mode 100644
index 000000000000..ebae595ac38f
--- /dev/null
+++ b/media-gfx/scrot/files/scrot-1.7-fix-docdir.patch
@@ -0,0 +1,46 @@
+https://github.com/resurrecting-open-source-projects/scrot/pull/175
+
+From: Sam James <sam@gentoo.org>
+Date: Sun, 19 Dec 2021 23:59:45 +0000
+Subject: [PATCH] build: respect docdir
+
+Before this patch with --docdir=/usr/share/doc/scrot-1.7-r1 (example downstream
+versioning for patches):
+```
+>>> /usr/share/doc/scrot-1.7-r1/
+>>> /usr/share/doc/scrot-1.7-r1/README.md.bz2
+>>> /usr/share/doc/scrot-1.7-r1/ChangeLog.bz2
+>>> /usr/share/doc/scrot-1.7-r1/AUTHORS.bz2
+>>> /usr/share/doc/scrot/
+>>> /usr/share/doc/scrot/scrot.png
+>>> /usr/share/doc/scrot/README.md.bz2
+>>> /usr/share/doc/scrot/ChangeLog.bz2
+>>> /usr/share/doc/scrot/AUTHORS.bz2
+```
+
+After:
+```
+>>> /usr/share/doc/scrot-1.7-r1/scrot.png
+>>> /usr/share/doc/scrot-1.7-r1/README.md.bz2
+>>> /usr/share/doc/scrot-1.7-r1/ChangeLog.bz2
+>>> /usr/share/doc/scrot-1.7-r1/AUTHORS.bz2
+```
+
+This avoids installing duplicate files & installs them to the
+same location but it's overridable by --docdir in ./configure which
+helps downstreams.
+
+Bug: https://bugs.gentoo.org/828928
+Signed-off-by: Sam James <sam@gentoo.org>
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -34,8 +34,7 @@ MAINTAINERCLEANFILES = Makefile.in
+ 
+ man_MANS = man/scrot.1
+ 
+-docs_DATA = README.md AUTHORS ChangeLog doc/scrot.png
+-docsdir = $(prefix)/share/doc/scrot
++doc_DATA = README.md AUTHORS ChangeLog doc/scrot.png
+ 
+ EXTRA_DIST = man/scrot.1 $(docs_DATA)
+ 

diff --git a/media-gfx/scrot/scrot-1.7-r1.ebuild b/media-gfx/scrot/scrot-1.7-r2.ebuild
similarity index 82%
rename from media-gfx/scrot/scrot-1.7-r1.ebuild
rename to media-gfx/scrot/scrot-1.7-r2.ebuild
index 80d7728667d6..3aa2ef8c7e06 100644
--- a/media-gfx/scrot/scrot-1.7-r1.ebuild
+++ b/media-gfx/scrot/scrot-1.7-r2.ebuild
@@ -3,7 +3,8 @@
 
 EAPI=8
 
-inherit bash-completion-r1
+# Need autotools for docdir patch for now
+inherit autotools bash-completion-r1
 
 DESCRIPTION="Screen capture utility using imlib2 library"
 HOMEPAGE="https://github.com/resurrecting-open-source-projects/scrot"
@@ -45,10 +46,16 @@ DOCS=(
 	AUTHORS ChangeLog README.md
 )
 
+PATCHES=(
+	"${FILESDIR}"/${PN}-1.7-fix-docdir.patch
+)
+
 src_prepare() {
 	default
 
-	[[ ${PV} == *9999* ]] && eautoreconf
+	# Needed for 1.7 for the docdir patch
+	eautoreconf
+	#[[ ${PV} == *9999* ]] && eautoreconf
 }
 
 src_install() {


             reply	other threads:[~2021-12-20  0:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-20  0:02 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-03-28 11:37 [gentoo-commits] repo/gentoo:master commit in: media-gfx/scrot/, media-gfx/scrot/files/ Ionen Wolkens
2021-12-11  1:29 Sam James
2020-08-07 11:29 Jeroen Roovers
2020-06-30  8:08 Jeroen Roovers
2019-11-05  9:29 Jeroen Roovers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1639958534.e3fab0acfbb39f126224b70daf1927e3fe1404f8.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox