From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 4C2EC158086 for ; Sat, 11 Dec 2021 02:54:15 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 7FC3FE0101; Sat, 11 Dec 2021 02:54:13 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id AC9F2E07C5 for ; Sat, 11 Dec 2021 02:54:12 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id F2F6B3431D0 for ; Sat, 11 Dec 2021 02:54:10 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 310A921E for ; Sat, 11 Dec 2021 02:54:09 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1639191240.c36f878509108c970907dc391d6562297881b400.sam@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: lib/portage/package/ebuild/ X-VCS-Repository: proj/portage X-VCS-Files: lib/portage/package/ebuild/doebuild.py X-VCS-Directories: lib/portage/package/ebuild/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: c36f878509108c970907dc391d6562297881b400 X-VCS-Branch: master Date: Sat, 11 Dec 2021 02:54:09 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 5d047b52-c77c-4961-b8a7-b1df11f2ac03 X-Archives-Hash: 74735d42749e9882a1f0e2b4679eeca0 commit: c36f878509108c970907dc391d6562297881b400 Author: Sam James gentoo org> AuthorDate: Sat Dec 11 02:47:50 2021 +0000 Commit: Sam James gentoo org> CommitDate: Sat Dec 11 02:54:00 2021 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=c36f8785 lib/portage/package/ebuild/doebuild.py: use 'eerror' for blank PROVIDES message This means that it's much harder to miss the error. Bug: https://bugs.gentoo.org/811462 Reported-by: Brian Dolbec gentoo.org> Thanks-to: Arfrever Frehtes Taifersar Arahesis Apache.Org> Signed-off-by: Sam James gentoo.org> lib/portage/package/ebuild/doebuild.py | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/lib/portage/package/ebuild/doebuild.py b/lib/portage/package/ebuild/doebuild.py index 0ff64e275..ac627f555 100644 --- a/lib/portage/package/ebuild/doebuild.py +++ b/lib/portage/package/ebuild/doebuild.py @@ -3096,13 +3096,11 @@ def _post_src_install_soname_symlinks(mysettings, out): f.write(soname_deps.provides) else: if check_dyn_libs_inconsistent(image_dir, soname_deps.provides): - portage.util._writemsg_level( - colorize( - "BAD", - "!!! Error! Installing dynamic libraries (.so) with blank PROVIDES!", - ), - noiselevel=-1, - level=logging.ERROR, + eerror( + "Error! Installing dynamic libraries (.so) with blank PROVIDES!", + phase="install", + key=mysettings.mycpv, + out=out, ) if unrecognized_elf_files: