From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 6E865158086 for ; Sat, 13 Nov 2021 04:49:22 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6C41B2BC016; Sat, 13 Nov 2021 04:49:19 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0E2C12BC016 for ; Sat, 13 Nov 2021 04:49:14 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id B15533432E8 for ; Sat, 13 Nov 2021 04:49:11 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 02B5D175 for ; Sat, 13 Nov 2021 04:49:10 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1636778946.6c4d82dde134b4e947480759c125e9389f09ae01.sam@gentoo> Subject: [gentoo-commits] proj/gcc-config:master commit in: / X-VCS-Repository: proj/gcc-config X-VCS-Files: gcc-config X-VCS-Directories: / X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 6c4d82dde134b4e947480759c125e9389f09ae01 X-VCS-Branch: master Date: Sat, 13 Nov 2021 04:49:10 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 40f9dcf9-e786-4b19-aa4b-03a83ac0997c X-Archives-Hash: 73253a4094b3573f7e91ace6cc8797ea commit: 6c4d82dde134b4e947480759c125e9389f09ae01 Author: Sam James gentoo org> AuthorDate: Sat Nov 13 04:48:00 2021 +0000 Commit: Sam James gentoo org> CommitDate: Sat Nov 13 04:49:06 2021 +0000 URL: https://gitweb.gentoo.org/proj/gcc-config.git/commit/?id=6c4d82dd gcc-config: add comment explaining SELinux-related writable check Bug: https://bugs.gentoo.org/823203 Signed-off-by: Sam James gentoo.org> gcc-config | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gcc-config b/gcc-config index 70bb388..eff9cca 100755 --- a/gcc-config +++ b/gcc-config @@ -668,6 +668,11 @@ switch_profile() { # Make sure we have write access to the dirs. Do not require `root` # so that we work with prefix/cross/etc... setups that run as user. + # + # [It's important we use ${ENV_D} and not e.g. ${EROOT} because for, say + # SELinux, we may not actually be able to write to ${EROOT}, but would + # be allowed for specific paths like the gcc wrappers we need to + # modify. bug #823203.] [[ ! -w ${ENV_D} ]] && die "need write access to ${ENV_D}" if is_cross_compiler ; then