public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/gcc-config:master commit in: /
Date: Sat, 13 Nov 2021 04:49:10 +0000 (UTC)	[thread overview]
Message-ID: <1636778946.6c4d82dde134b4e947480759c125e9389f09ae01.sam@gentoo> (raw)

commit:     6c4d82dde134b4e947480759c125e9389f09ae01
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Sat Nov 13 04:48:00 2021 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sat Nov 13 04:49:06 2021 +0000
URL:        https://gitweb.gentoo.org/proj/gcc-config.git/commit/?id=6c4d82dd

gcc-config: add comment explaining SELinux-related writable check

Bug: https://bugs.gentoo.org/823203
Signed-off-by: Sam James <sam <AT> gentoo.org>

 gcc-config | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gcc-config b/gcc-config
index 70bb388..eff9cca 100755
--- a/gcc-config
+++ b/gcc-config
@@ -668,6 +668,11 @@ switch_profile() {
 
 	# Make sure we have write access to the dirs.  Do not require `root`
 	# so that we work with prefix/cross/etc... setups that run as user.
+	#
+	# [It's important we use ${ENV_D} and not e.g. ${EROOT} because for, say
+	# SELinux, we may not actually be able to write to ${EROOT}, but would
+	# be allowed for specific paths like the gcc wrappers we need to
+	# modify. bug #823203.]
 	[[ ! -w ${ENV_D} ]] && die "need write access to ${ENV_D}"
 
 	if is_cross_compiler ; then


             reply	other threads:[~2021-11-13  4:49 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-13  4:49 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-12-08  3:26 [gentoo-commits] proj/gcc-config:master commit in: / Sam James
2024-12-08  3:19 Sam James
2024-12-08  3:18 Sam James
2023-05-31  5:55 Sam James
2023-05-31  5:54 Sam James
2023-05-14 17:25 Sam James
2023-04-30  2:59 Sam James
2023-01-05  0:16 Sam James
2022-12-28 19:12 Sam James
2022-12-28 19:12 Sam James
2022-12-28 19:12 Sam James
2022-10-10 14:09 Sam James
2022-10-09 20:55 Sam James
2022-10-08 22:02 Sam James
2022-09-29 22:36 Sam James
2022-09-29 22:36 Sam James
2022-09-22 23:46 Sam James
2021-11-13  4:49 Sam James
2021-02-26  9:36 Sergei Trofimovich
2021-02-26  9:36 Sergei Trofimovich
2021-02-26  9:36 Sergei Trofimovich
2021-02-26  9:36 Sergei Trofimovich
2021-02-26  8:40 Sergei Trofimovich
2021-01-23 17:51 Sergei Trofimovich
2020-09-05 18:11 Sergei Trofimovich
2020-06-24 20:47 Sergei Trofimovich
2020-06-21 11:53 Sergei Trofimovich
2020-06-21 11:50 Sergei Trofimovich
2020-05-23  7:28 Sergei Trofimovich
2020-05-22 13:23 Sergei Trofimovich
2020-05-22 13:20 Sergei Trofimovich
2020-05-22 11:33 Sergei Trofimovich
2020-05-22 10:39 Sergei Trofimovich
2020-05-22 10:03 Sergei Trofimovich
2020-05-22  9:40 Sergei Trofimovich
2020-04-10 10:08 Sergei Trofimovich
2020-01-26 13:44 Sergei Trofimovich
2020-01-26 13:26 Sergei Trofimovich
2019-09-08  8:37 Sergei Trofimovich
2019-09-08  8:29 Sergei Trofimovich
2019-09-07 22:08 Sergei Trofimovich
2019-09-07  9:39 Sergei Trofimovich
2019-09-07  9:39 Sergei Trofimovich
2019-09-07  9:15 Sergei Trofimovich
2019-09-07  9:01 Sergei Trofimovich
2019-09-07  8:47 Sergei Trofimovich
2019-09-07  8:22 Sergei Trofimovich
2019-09-06  7:29 Sergei Trofimovich
2019-09-06  7:23 Sergei Trofimovich
2019-09-06  6:53 Sergei Trofimovich
2019-09-06  6:53 Sergei Trofimovich
2019-09-05 22:35 Sergei Trofimovich
2019-09-05  7:24 Sergei Trofimovich
2019-09-05  6:47 Sergei Trofimovich
2019-09-05  6:42 Sergei Trofimovich
2019-09-05  6:28 Sergei Trofimovich
2019-09-04 19:00 Sergei Trofimovich
2019-09-04 19:00 Sergei Trofimovich
2018-08-24 16:40 Sergei Trofimovich
2018-08-24  8:50 Sergei Trofimovich
2018-08-24  0:23 Sergei Trofimovich
2018-08-13 22:39 Sergei Trofimovich
2018-08-13 21:55 Sergei Trofimovich
2017-12-16 21:11 Andreas Hüttel
2017-12-16 20:15 Andreas Hüttel
2017-12-15  8:33 Fabian Groffen
2015-08-05  8:12 Mike Frysinger
2015-08-05  7:52 Mike Frysinger
2015-05-13  4:26 Ryan Hill
2013-05-22 23:54 Mike Frysinger
2013-01-12 17:20 Mike Frysinger
2013-01-12 17:17 Mike Frysinger
2013-01-12 17:14 Mike Frysinger
2013-01-12 17:05 Mike Frysinger
2013-01-02 18:30 Mike Frysinger
2013-01-02  3:52 Mike Frysinger
2012-12-29 21:08 Mike Frysinger
2012-11-19  6:52 Mike Frysinger
2012-11-19  1:11 Mike Frysinger
2012-11-19  1:11 Mike Frysinger
2012-06-10  4:00 Mike Frysinger
2012-06-10  4:00 Mike Frysinger
2012-04-14  1:22 Mike Frysinger
2012-04-14  1:22 Mike Frysinger
2012-04-14  1:22 Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1636778946.6c4d82dde134b4e947480759c125e9389f09ae01.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox