public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Jakov Smolić" <jsmolic@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-util/bpftrace/
Date: Sun,  7 Nov 2021 20:59:42 +0000 (UTC)	[thread overview]
Message-ID: <1636318719.e576dd19c0e1bdc56ad8e9f356490f456f8dc604.jsmolic@gentoo> (raw)

commit:     e576dd19c0e1bdc56ad8e9f356490f456f8dc604
Author:     Jakov Smolić <jsmolic <AT> gentoo <DOT> org>
AuthorDate: Sun Nov  7 20:58:15 2021 +0000
Commit:     Jakov Smolić <jsmolic <AT> gentoo <DOT> org>
CommitDate: Sun Nov  7 20:58:39 2021 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e576dd19

dev-util/bpftrace: Statically link (partially), avoid stripping bpftrace

bpftrace is currently broken due to BEGIN_trigger symbol missing. To fix this,
we need to avoid stripping the binary since it clearly needs to have
symbols to work properly, and we also need to link some of the libraries
statically into the binary, namely some internal libraries provided by
bpftrace need to be statically linked, otherwise the binary will still
end up missing the needed symbol (upstream issue -
https://github.com/iovisor/bpftrace/issues/954). For previous versions
it was enough to skip stripping the binary, but BEGIN_trigger symbol was
moved to libbpftrace several versions ago, so even if it is present as
a .so library the symbol won't be found.

Closes: https://bugs.gentoo.org/809362
Signed-off-by: Jakov Smolić <jsmolic <AT> gentoo.org>

 dev-util/bpftrace/bpftrace-0.14.0-r3.ebuild | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dev-util/bpftrace/bpftrace-0.14.0-r3.ebuild b/dev-util/bpftrace/bpftrace-0.14.0-r3.ebuild
index efe4e68822d..4435e4c8379 100644
--- a/dev-util/bpftrace/bpftrace-0.14.0-r3.ebuild
+++ b/dev-util/bpftrace/bpftrace-0.14.0-r3.ebuild
@@ -3,7 +3,7 @@
 
 EAPI=7
 
-inherit toolchain-funcs llvm linux-info cmake
+inherit llvm linux-info cmake
 
 DESCRIPTION="High-level tracing language for eBPF"
 HOMEPAGE="https://github.com/iovisor/bpftrace"
@@ -67,6 +67,7 @@ pkg_setup() {
 src_configure() {
 	local -a mycmakeargs=(
 		-DSTATIC_LINKING:BOOL=OFF
+		-DBUILD_SHARED_LIBS:=OFF
 		-DBUILD_TESTING:BOOL=OFF
 		-DBUILD_FUZZ:BOOL=$(usex fuzzing)
 		-DENABLE_MAN:BOOL=OFF
@@ -77,5 +78,6 @@ src_configure() {
 
 src_install() {
 	cmake_src_install
+	dostrip -x /usr/bin/bpftrace
 	doman man/man8/*.?
 }


             reply	other threads:[~2021-11-07 20:59 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-07 20:59 Jakov Smolić [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-12-23 18:45 [gentoo-commits] repo/gentoo:master commit in: dev-util/bpftrace/ Jakov Smolić
2023-10-04 17:42 Patrick McLean
2023-04-20 21:09 Patrick McLean
2023-04-12 23:31 Patrick McLean
2023-02-01  1:57 Patrick McLean
2023-01-13 18:40 Patrick McLean
2022-12-07 13:52 David Seifert
2022-10-09 15:07 Yixun Lan
2022-09-27 21:41 Sam James
2022-09-22 20:11 Patrick McLean
2022-08-24 18:20 Patrick McLean
2022-06-27 17:32 Jakov Smolić
2022-02-11 19:53 Jakov Smolić
2022-01-31 19:40 Jakov Smolić
2022-01-06 17:19 Patrick McLean
2021-12-05  3:26 Sam James
2021-11-07 20:59 Jakov Smolić
2021-11-07 20:59 Jakov Smolić
2021-11-07 20:59 Jakov Smolić
2021-11-07 20:59 Jakov Smolić
2021-11-07 20:59 Jakov Smolić
2021-11-07 20:59 Jakov Smolić
2021-04-20  3:30 Patrick McLean
2021-03-24 23:59 Patrick McLean
2020-11-14 19:27 Patrick McLean
2020-11-14  1:30 Patrick McLean
2020-10-30 21:13 Patrick McLean
2020-09-22 19:26 Patrick McLean
2020-08-25  0:19 Patrick McLean
2019-07-31 23:18 Patrick McLean
2019-06-25 18:08 Patrick McLean
2019-06-20 18:25 Patrick McLean
2019-05-21 16:45 Stephen Klimaszewski
2019-04-12  4:31 Patrick McLean
2019-04-12  4:28 Patrick McLean
2019-04-05 18:03 Patrick McLean
2019-03-16 20:43 Patrick McLean
2019-03-16 20:43 Patrick McLean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1636318719.e576dd19c0e1bdc56ad8e9f356490f456f8dc604.jsmolic@gentoo \
    --to=jsmolic@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox