From: "Mike Frysinger" <vapier@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/build-docbook-catalog:master commit in: /
Date: Sat, 2 Oct 2021 06:17:01 +0000 (UTC) [thread overview]
Message-ID: <1633155259.0bb79addc38cc95fd0e98b681ea7c626f0d7d21b.vapier@gentoo> (raw)
commit: 0bb79addc38cc95fd0e98b681ea7c626f0d7d21b
Author: Mike Frysinger <vapier <AT> gentoo <DOT> org>
AuthorDate: Sat Oct 2 06:14:19 2021 +0000
Commit: Mike Frysinger <vapier <AT> gentoo <DOT> org>
CommitDate: Sat Oct 2 06:14:19 2021 +0000
URL: https://gitweb.gentoo.org/proj/build-docbook-catalog.git/commit/?id=0bb79add
handle corrupt catalogs gracefully
If the files get corrupted for any reason (i.e. are not valid XML),
the current code gets wedged and is unable to recover until the user
deletes or fixes them. Instead, let's throw them away and start over.
Signed-off-by: Mike Frysinger <vapier <AT> gentoo.org>
build-docbook-catalog | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/build-docbook-catalog b/build-docbook-catalog
index 1c7f103..6950f3e 100755
--- a/build-docbook-catalog
+++ b/build-docbook-catalog
@@ -161,6 +161,11 @@ multi_xmlcatalog_add() {
create_catalogs() {
local adds
+ # Initialize catalogs if they don't exist or are corrupt.
+ if ! xmllint "${ROOT}${ROOTCATALOG}" >&/dev/null ; then
+ rm -f "${ROOTCATALOG}"
+ echo "Deleting corrupt ${ROOT}${ROOTCATALOG} and starting over"
+ fi
if [[ ! -r ${ROOT}${ROOTCATALOG} ]] ; then
echo "Creating XML Catalog root ${ROOTCATALOG}"
xmlcatalog --noout --create "${ROOT}${ROOTCATALOG}"
@@ -174,6 +179,11 @@ create_catalogs() {
clean_catalog "file://${CATALOG}" "${ROOTCATALOG}"
fi
+ # Initialize catalogs if they don't exist or are corrupt.
+ if ! xmllint "${ROOT}${CATALOG}" >&/dev/null ; then
+ rm -f "${ROOT}${CATALOG}"
+ echo "Deleting corrupt ${CATALOG} and starting over"
+ fi
if [[ ! -r ${ROOT}${CATALOG} ]] ; then
echo "Creating DocBook XML Catalog ${CATALOG}"
xmlcatalog --noout --create "${ROOT}${CATALOG}"
next reply other threads:[~2021-10-02 6:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 6:17 Mike Frysinger [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-10-02 6:20 [gentoo-commits] proj/build-docbook-catalog:master commit in: / Mike Frysinger
2021-10-02 6:20 Mike Frysinger
2021-10-03 4:01 Mike Frysinger
2021-10-03 4:01 Mike Frysinger
2021-10-03 4:01 Mike Frysinger
2021-10-03 4:01 Mike Frysinger
2021-10-03 4:01 Mike Frysinger
2021-10-03 4:01 Mike Frysinger
2021-10-03 4:01 Mike Frysinger
2021-10-05 1:14 Mike Frysinger
2021-10-05 1:14 Mike Frysinger
2021-10-08 12:22 Mike Frysinger
2022-01-17 23:13 Andreas K. Hüttel
2022-01-27 20:28 Sam James
2023-04-25 3:43 Sam James
2023-04-25 3:43 Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1633155259.0bb79addc38cc95fd0e98b681ea7c626f0d7d21b.vapier@gentoo \
--to=vapier@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox