public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-ruby/eventmachine/
Date: Tue, 28 Sep 2021 19:34:37 +0000 (UTC)	[thread overview]
Message-ID: <1632857664.5dd88defd7f4a8482ad22e71e72ebd7740b85fd2.sam@gentoo> (raw)

commit:     5dd88defd7f4a8482ad22e71e72ebd7740b85fd2
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Tue Sep 28 19:30:32 2021 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Tue Sep 28 19:34:24 2021 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5dd88def

dev-ruby/eventmachine: skip fewer tests, backport OpenSSL 1.1.1 fixes

While I'd prefer to not mess with SSL patches where possible,
on balance, it's worth using these here:
- They're upstream patches;
- They're being used in production by Fedora and Debian (in stable too);
- This is the lesser evil given that tests fail with latest OpenSSL
(hence we can't really judge if things are working) and, in the best case,
at runtime, this will fallback to older SSL/TLS versions.

Bug: https://bugs.gentoo.org/765253
Closes: https://bugs.gentoo.org/723818
Closes: https://bugs.gentoo.org/759250
Fixes: f05cc0db4473e05d408574c23a494ce903173e8d
Signed-off-by: Sam James <sam <AT> gentoo.org>

 dev-ruby/eventmachine/Manifest                     |  1 +
 ....2.7-r2.ebuild => eventmachine-1.2.7-r3.ebuild} | 30 +++++++++++++---------
 2 files changed, 19 insertions(+), 12 deletions(-)

diff --git a/dev-ruby/eventmachine/Manifest b/dev-ruby/eventmachine/Manifest
index bcec3e811ea..81c0d1ad05a 100644
--- a/dev-ruby/eventmachine/Manifest
+++ b/dev-ruby/eventmachine/Manifest
@@ -1 +1,2 @@
+DIST eventmachine-1.2.7-openssl-patches.tar.bz2 14837 BLAKE2B 5f3280c053bd67c97db53814db3bbfd9bb3047d0fdae3972494a88bc9062e0f20b5684da8ba4264299a4fd5b0c159ad0d006fe78f6f1e8c0e9cdb531d98e3017 SHA512 9294ae918a51c2e7db098add3e793a2a57e40b223b7ee7113664245b5584af7b7bb180cf1dd83d0c30a316b6598a0a4507b953603c95482c42738099d33419d0
 DIST eventmachine-1.2.7.tar.gz 246402 BLAKE2B 3eee1e5fbb367c03e3d801cb705a0f95b7bbb461885f04820f57421019a3d61eecabe71309981eec35168395eb6d98a8c675bd0fb225497de511f2ce09a5df92 SHA512 768ec084903dce4c737cf564fce7886a3e7e5b7d4a89c2baea3e998130c53dc00488eaa2d8e9b0133d9e4d8fffbde80c3025403881486a7968c2d84425cc1f50

diff --git a/dev-ruby/eventmachine/eventmachine-1.2.7-r2.ebuild b/dev-ruby/eventmachine/eventmachine-1.2.7-r3.ebuild
similarity index 71%
rename from dev-ruby/eventmachine/eventmachine-1.2.7-r2.ebuild
rename to dev-ruby/eventmachine/eventmachine-1.2.7-r3.ebuild
index d3b2c9b344d..ce7cdf3ce6a 100644
--- a/dev-ruby/eventmachine/eventmachine-1.2.7-r2.ebuild
+++ b/dev-ruby/eventmachine/eventmachine-1.2.7-r3.ebuild
@@ -19,6 +19,8 @@ inherit ruby-fakegem
 DESCRIPTION="EventMachine is a fast, simple event-processing library for Ruby programs"
 HOMEPAGE="https://github.com/eventmachine/eventmachine"
 SRC_URI="https://github.com/eventmachine/eventmachine/archive/v${PV}.tar.gz -> ${P}.tar.gz"
+# Collection of upstream patches to fix compatibility with newer OpenSSL
+SRC_URI+=" https://dev.gentoo.org/~sam/distfiles/${CATEGORY}/${PN}/${P}-openssl-patches.tar.bz2"
 
 LICENSE="|| ( GPL-2 Ruby )"
 SLOT="0"
@@ -27,12 +29,18 @@ IUSE="test"
 RESTRICT="!test? ( test )"
 
 DEPEND="${DEPEND}
-	dev-libs/openssl:0"
+	dev-libs/openssl:0="
 RDEPEND="${RDEPEND}
 	dev-libs/openssl:0="
 
 ruby_add_bdepend "test? ( dev-ruby/test-unit:2 )"
 
+PATCHES=(
+	# Collection of upstream patches (rebased by Fedora, thanks!) to
+	# fix (mostly test) compatibility with >= OpenSSL 1.1.1.
+	"${WORKDIR}"/all/patches/
+)
+
 all_ruby_prepare() {
 	# Remove package tasks to avoid dependency on rake-compiler.
 	rm rakelib/package.rake || die
@@ -50,20 +58,18 @@ all_ruby_prepare() {
 		-e '/test_invalid_address_bind_connect_src/,/^  end/ s:^:#:' \
 		-e '/test_invalid_address_bind_connect_dst/,/^  end/ s:^:#:' \
 		-i tests/test_basic.rb || die
-	# Avoid tests for insecure SSL versions that may not be available
-	sed -e '/test_any_to_v3/,/^    end/ s:^:#:' \
-		-e '/test_v3_/,/^    end/ s:^:#:' \
-		-e '/test_tlsv1_required_with_external_client/aomit "sslv3"' \
-		-e '/test_any_to_any/,/^    end/ s:^:#:' \
-		-e '/test_case_insensitivity/,/^    end/ s:^:#:' \
-		-e '/test_default_to_default/,/^    end/ s:^:#:' \
-		-i tests/test_ssl_protocols.rb || die
-	# Those also want network
 	sed -e '/test_ipv6_udp_local_server/,/^    end/ s:^:#:' \
 		-e '/test_ipv6_tcp_local_server/,/^    end/ s:^:#:' \
 		-i tests/test_ipv6.rb || die
-
-	rm tests/test_{sock_opt,ssl_verify,ssl_methods,ssl_dhparam,ssl_ecdh_curve,idle_connection}.rb || die
+	sed -e '/test_for_real/,/^    end/ s:^:#:' -i tests/test_pending_connect_timeout.rb || die
+	sed -e '/test_connect_timeout/,/^  end/ s:^:#:' -i tests/test_unbind_reason.rb || die
+	sed -e '/test_cookie/,/^  end/ s:^:#:' \
+		-e '/test_http_client/,/^  end/ s:^:#:' \
+		-e '/test_version_1_0/,/^  end/ s:^:#:' \
+		-i tests/test_httpclient.rb || die
+	sed -e '/test_get/,/^  end/ s:^:#:' \
+		-e '/test_https_get/,/^  end/ s:^:#:' \
+		-i tests/test_httpclient2.rb || die
 
 	# Avoid test that deliberately triggers a C++ exception which causes
 	# a SEGFAULT. This does not appear to happen upstream (on travis).


             reply	other threads:[~2021-09-28 19:34 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28 19:34 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-03-29 13:04 [gentoo-commits] repo/gentoo:master commit in: dev-ruby/eventmachine/ Sam James
2023-03-29 11:48 Sam James
2023-03-29 11:38 Sam James
2023-03-12 12:09 Hans de Graaff
2022-07-30  7:46 Hans de Graaff
2022-06-26  6:44 Hans de Graaff
2022-06-18 20:25 Sam James
2022-06-18 20:25 Sam James
2021-09-28  1:09 Sam James
2021-09-28  1:08 Sam James
2021-09-28  1:01 Sam James
2021-06-22 18:19 Sam James
2020-05-23  6:34 Hans de Graaff
2019-02-02 10:36 Hans de Graaff
2018-07-15 19:05 Hans de Graaff
2018-07-15 19:05 Hans de Graaff
2018-05-18  5:56 Hans de Graaff
2018-04-26  4:57 Hans de Graaff
2018-04-17 18:29 Hans de Graaff
2018-04-16 18:32 Hans de Graaff
2018-02-25  7:47 Hans de Graaff
2018-02-25  6:47 Hans de Graaff
2016-06-26  5:38 Hans de Graaff
2016-03-17 11:56 Agostino Sarubbo
2016-03-17  6:39 Hans de Graaff
2016-03-17  6:39 Hans de Graaff
2016-03-17  6:39 Hans de Graaff
2016-01-14 20:37 Manuel Rüger
2016-01-14 20:37 Manuel Rüger
2015-10-03  9:12 Hans de Graaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1632857664.5dd88defd7f4a8482ad22e71e72ebd7740b85fd2.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox