From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 41A3E139360 for ; Tue, 3 Aug 2021 17:26:17 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 89E34E092D; Tue, 3 Aug 2021 17:26:16 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 719F1E092D for ; Tue, 3 Aug 2021 17:26:16 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 69D20342E68 for ; Tue, 3 Aug 2021 17:26:15 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id D3A6963F for ; Tue, 3 Aug 2021 17:26:13 +0000 (UTC) From: "Mike Gilbert" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Mike Gilbert" Message-ID: <1628011572.ebee474c08d6219b0a0ff88139ce0aabf3ec529c.floppym@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: sys-fs/udev/ X-VCS-Repository: repo/gentoo X-VCS-Files: sys-fs/udev/udev-249-r2.ebuild X-VCS-Directories: sys-fs/udev/ X-VCS-Committer: floppym X-VCS-Committer-Name: Mike Gilbert X-VCS-Revision: ebee474c08d6219b0a0ff88139ce0aabf3ec529c X-VCS-Branch: master Date: Tue, 3 Aug 2021 17:26:13 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 14ccffff-11b0-4d54-93c9-8e34b6f619b7 X-Archives-Hash: b49636b4cb1fef903a270543b1471891 commit: ebee474c08d6219b0a0ff88139ce0aabf3ec529c Author: Mike Gilbert gentoo org> AuthorDate: Tue Aug 3 17:21:11 2021 +0000 Commit: Mike Gilbert gentoo org> CommitDate: Tue Aug 3 17:26:12 2021 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ebee474c sys-fs/udev: adjust test logic Check EUID instead of FEATURES=userpriv. It is possible the ebuild is executing as some other user, regardless of the userpriv feature. Drop the usersandbox check: this is only relevant if the ebuild phase is running as a non-root user, and we already handle that with the EUID check. Signed-off-by: Mike Gilbert gentoo.org> sys-fs/udev/udev-249-r2.ebuild | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/sys-fs/udev/udev-249-r2.ebuild b/sys-fs/udev/udev-249-r2.ebuild index e2c3e613c5e..d22a44bf678 100644 --- a/sys-fs/udev/udev-249-r2.ebuild +++ b/sys-fs/udev/udev-249-r2.ebuild @@ -199,14 +199,9 @@ multilib_src_test() { # udev calls 'mknod' a number of times, and this interacts # badly with kernel namespaces. - if has userpriv ${FEATURES}; then - ewarn "\'FEATURES=userpriv\' detected" + if [[ ${EUID} -ne 0 ]]; then ewarn "udev tests need to run under uid 0" ewarn "Skipping tests" - elif has usersandbox ${FEATURES}; then - ewarn "\'FEATURES=usersandbox\' detected" - ewarn "udev tests needs full access to /dev" - ewarn "Skipping tests" elif has sandbox ${FEATURES}; then ewarn "\'FEATURES=sandbox\' detected" ewarn "udev tests needs full access to /dev"