From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9BE71139337 for ; Sun, 25 Jul 2021 23:57:21 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D46BAE0D12; Sun, 25 Jul 2021 23:57:20 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 6EA23E0D19 for ; Sun, 25 Jul 2021 23:57:20 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 69394342A5E for ; Sun, 25 Jul 2021 23:57:19 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id C171E7D0 for ; Sun, 25 Jul 2021 23:57:17 +0000 (UTC) From: "Alessandro Barbieri" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Alessandro Barbieri" Message-ID: <1627257269.3dbb6f90da7b02e3b85fb11e1f6b075c4f8e5d21.Alessandro-Barbieri@gentoo> Subject: [gentoo-commits] repo/proj/guru:dev commit in: / X-VCS-Repository: repo/proj/guru X-VCS-Files: CONTRIBUTING.md X-VCS-Directories: / X-VCS-Committer: Alessandro-Barbieri X-VCS-Committer-Name: Alessandro Barbieri X-VCS-Revision: 3dbb6f90da7b02e3b85fb11e1f6b075c4f8e5d21 X-VCS-Branch: dev Date: Sun, 25 Jul 2021 23:57:17 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 56117105-445e-42ba-94cc-dc6911ae444e X-Archives-Hash: 0673d657d14a1aec91138da82f4a1331 commit: 3dbb6f90da7b02e3b85fb11e1f6b075c4f8e5d21 Author: Alessandro Barbieri gmail com> AuthorDate: Sun Jul 25 23:54:29 2021 +0000 Commit: Alessandro Barbieri gmail com> CommitDate: Sun Jul 25 23:54:29 2021 +0000 URL: https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=3dbb6f90 CONTRIBUTING.md: mention to avoid colon ad sed separator Closes: https://github.com/gentoo/guru/issues/34 Signed-off-by: Alessandro Barbieri gmail.com> CONTRIBUTING.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2719cc93b..c796af744 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -91,3 +91,7 @@ The same holds for optional runtime dependencies. It is not necessary to introdu - #### Clean your patches See the [dev manual](https://devmanual.gentoo.org/ebuild-writing/misc-files/patches/#clean-patch-howto) for a guide on how to write clean patches + +- #### Avoid colon as a sed delimiter + +As seen in https://bugs.gentoo.org/685160 colon as a sed delimiter can break \*FLAGS. You must not use it to modify \*FLAGS, better if you avoid using it completely.