From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 8D5B713934F for ; Mon, 26 Jul 2021 14:05:43 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8DFC3E0964; Mon, 26 Jul 2021 14:05:42 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 33FB1E0963 for ; Mon, 26 Jul 2021 14:05:42 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id B63CD342A3C for ; Mon, 26 Jul 2021 14:05:40 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 22162850 for ; Mon, 26 Jul 2021 14:05:38 +0000 (UTC) From: "Andrew Ammerlaan" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Andrew Ammerlaan" Message-ID: <1627256971.f8caf432510f5a226f59b82de5b024cc50d2fe32.andrewammerlaan@gentoo> Subject: [gentoo-commits] repo/proj/guru:master commit in: / X-VCS-Repository: repo/proj/guru X-VCS-Files: CONTRIBUTING.md X-VCS-Directories: / X-VCS-Committer: andrewammerlaan X-VCS-Committer-Name: Andrew Ammerlaan X-VCS-Revision: f8caf432510f5a226f59b82de5b024cc50d2fe32 X-VCS-Branch: master Date: Mon, 26 Jul 2021 14:05:38 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: a4f83f4d-1139-4caa-9d19-2b4625c652b9 X-Archives-Hash: fa48ab9c43bd94ab278e43e9b064275b commit: f8caf432510f5a226f59b82de5b024cc50d2fe32 Author: Alessandro Barbieri gmail com> AuthorDate: Sun Jul 25 23:49:31 2021 +0000 Commit: Andrew Ammerlaan gentoo org> CommitDate: Sun Jul 25 23:49:31 2021 +0000 URL: https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=f8caf432 CONTRIBUTING.md: mention the clean patch guide Closes: https://github.com/gentoo/guru/issues/28 Signed-off-by: Alessandro Barbieri gmail.com> CONTRIBUTING.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 0fcc70708..2719cc93b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -87,3 +87,7 @@ See the [dev manual](https://devmanual.gentoo.org/eclass-reference/distutils-r1. Installation of small files, like documentation, completions, man pages, etc, does not have to be toggle-able with an USE flag. Instead, just install these files unconditionally. This avoids unnecessary recompilations when an user forgot to enable a flag that installs a small file. The same holds for optional runtime dependencies. It is not necessary to introduce a USE flag, that does not alter the compiled binary and just pulls in an extra optional runtime dependency. Instead, you can notify the user of these optional runtime dependencies with the `optfeature` function from the [optfeature](https://devmanual.gentoo.org/eclass-reference/optfeature.eclass/) eclass (early from currently deprecated [eutils](https://devmanual.gentoo.org/eclass-reference/eutils.eclass/) eclass). If, for whatever reason, it is still desired to introduce an USE flag for optional runtime dependencies, one can still use the `optfeature` function as well to allow the user to choose to avoid recompiling a package. + +- #### Clean your patches + +See the [dev manual](https://devmanual.gentoo.org/ebuild-writing/misc-files/patches/#clean-patch-howto) for a guide on how to write clean patches