From: "Georgy Yakovlev" <gyakovlev@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/cargo-ebuild:master commit in: src/
Date: Sat, 19 Jun 2021 22:34:21 +0000 (UTC) [thread overview]
Message-ID: <1624142027.148fc783d6c6d00ea35e56e861cb5bc42d8a49c2.gyakovlev@gentoo> (raw)
commit: 148fc783d6c6d00ea35e56e861cb5bc42d8a49c2
Author: Philip DeMonaco <phil <AT> demona <DOT> co>
AuthorDate: Sat Aug 29 16:47:13 2020 +0000
Commit: Georgy Yakovlev <gyakovlev <AT> gentoo <DOT> org>
CommitDate: Sat Jun 19 22:33:47 2021 +0000
URL: https://gitweb.gentoo.org/proj/cargo-ebuild.git/commit/?id=148fc783
feat: include all features when pulling metadata
Optional package dependencies are not included when pulling metadata. In
some cases these packages are still required to actually build even when
those flags are turned off.
This change effectively adds `--all-features` to the call of cargo
metadata.
I don't know if this is due to a change in behavior from cargo build,
however, it seems prudent to include all possible dependencies.
Signed-off-by: Georgy Yakovlev <gyakovlev <AT> gentoo.org>
src/lib.rs | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/lib.rs b/src/lib.rs
index 637846e..b7616b7 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -13,6 +13,7 @@ mod metadata;
use anyhow::{format_err, Context, Result};
use cargo_lock::Lockfile;
use cargo_metadata::MetadataCommand;
+use cargo_metadata::CargoOpt;
use std::collections::BTreeSet;
use std::fs::OpenOptions;
use std::io::Write;
@@ -56,6 +57,8 @@ fn generate_lockfile(manifest_path: Option<PathBuf>) -> Result<()> {
pub fn gen_ebuild_data(manifest_path: Option<PathBuf>) -> Result<EbuildConfig> {
let mut cmd = MetadataCommand::new();
+ cmd.features(CargoOpt::AllFeatures);
+
if let Some(path) = manifest_path.as_ref() {
cmd.manifest_path(path);
}
next reply other threads:[~2021-06-19 22:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-19 22:34 Georgy Yakovlev [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-08-02 6:57 [gentoo-commits] proj/cargo-ebuild:master commit in: src/ Georgy Yakovlev
2021-08-03 4:58 Georgy Yakovlev
2021-08-25 15:35 Georgy Yakovlev
2021-08-25 15:35 Georgy Yakovlev
2021-08-25 15:35 Georgy Yakovlev
2021-08-26 7:51 Georgy Yakovlev
2021-10-07 19:03 Georgy Yakovlev
2023-01-04 19:51 Georgy Yakovlev
2023-01-04 19:51 Georgy Yakovlev
2023-01-04 20:23 Georgy Yakovlev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1624142027.148fc783d6c6d00ea35e56e861cb5bc42d8a49c2.gyakovlev@gentoo \
--to=gyakovlev@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox