public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: app-emulation/libguestfs/
Date: Fri, 18 Jun 2021 22:51:01 +0000 (UTC)	[thread overview]
Message-ID: <1624056579.b51eac66d64d0d3aa8e26987b16db70135421a19.sam@gentoo> (raw)

commit:     b51eac66d64d0d3aa8e26987b16db70135421a19
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Fri Jun 18 22:41:00 2021 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Fri Jun 18 22:49:39 2021 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b51eac66

app-emulation/libguestfs: fix libxcrypt RPATH

We were struggling to find libxcrypt (when USE=-system) because it's buried
away in a subdir - /usr/$(get_libdir)/xcrypt.

For now, let's include a helping hand hint (RPATH) to tell binaries to look
there for libraries. This won't be an issue in future when we fully remove/disable
libcrypt from glibc and use libxcrypt[system] instead.

Thanks-to: Hank Leininger <hlein <AT> korelogic.com>
Closes: https://bugs.gentoo.org/789354
Signed-off-by: Sam James <sam <AT> gentoo.org>

 app-emulation/libguestfs/libguestfs-1.38.6-r103.ebuild | 6 ++++--
 app-emulation/libguestfs/libguestfs-1.44.1.ebuild      | 4 +++-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/app-emulation/libguestfs/libguestfs-1.38.6-r103.ebuild b/app-emulation/libguestfs/libguestfs-1.38.6-r103.ebuild
index 718edf8e60d..94ccee694c3 100644
--- a/app-emulation/libguestfs/libguestfs-1.38.6-r103.ebuild
+++ b/app-emulation/libguestfs/libguestfs-1.38.6-r103.ebuild
@@ -138,8 +138,10 @@ src_configure() {
 	# configured kernel.
 	export vmchannel_test=no
 
-	# bug #703118
-	append-ldflags "-L/usr/$(get_libdir)/xcrypt"
+	# Give a nudge to help find libxcrypt[-system]
+	# bug #703118, bug #789354
+	append-ldflags "-L${ESYSROOT}/usr/$(get_libdir)/xcrypt"
+	append-ldflags "-Wl,-R${ESYSROOT}/usr/$(get_libdir)/xcrypt"
 
 	econf \
 		--with-bashcompletiondir="$(get_bashcompdir)" \

diff --git a/app-emulation/libguestfs/libguestfs-1.44.1.ebuild b/app-emulation/libguestfs/libguestfs-1.44.1.ebuild
index d9e4983c5f5..08c3774a093 100644
--- a/app-emulation/libguestfs/libguestfs-1.44.1.ebuild
+++ b/app-emulation/libguestfs/libguestfs-1.44.1.ebuild
@@ -152,8 +152,10 @@ src_configure() {
 	# configured kernel.
 	export vmchannel_test=no
 
-	# bug #703118
+	# Give a nudge to help find libxcrypt[-system]
+	# bug #703118, bug #789354
 	append-ldflags "-L${ESYSROOT}/usr/$(get_libdir)/xcrypt"
+	append-ldflags "-Wl,-R${ESYSROOT}/usr/$(get_libdir)/xcrypt"
 
 	econf \
 		$(use_with libvirt) \


             reply	other threads:[~2021-06-18 22:51 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 22:51 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-05-05  8:14 [gentoo-commits] repo/gentoo:master commit in: app-emulation/libguestfs/ Sam James
2025-04-19  8:37 Hans de Graaff
2025-03-14 13:16 Alfredo Tupone
2025-03-02 22:55 Sam James
2025-03-02 22:55 Sam James
2025-03-02 22:55 Sam James
2025-02-20  9:16 Joonas Niilola
2025-02-20  9:16 Joonas Niilola
2025-02-20  9:16 Joonas Niilola
2025-02-20  9:16 Joonas Niilola
2024-06-19 10:33 Pacho Ramos
2024-04-28  1:01 Sam James
2024-04-24 13:47 Sam James
2023-12-02 10:56 Arthur Zamarin
2023-10-08  2:12 Sam James
2023-10-08  1:58 Sam James
2023-10-08  1:58 Sam James
2023-10-07 13:41 Joonas Niilola
2023-10-07 13:41 Joonas Niilola
2023-04-10 19:57 Sven Wegener
2023-04-10 19:57 Sven Wegener
2023-04-10 19:57 Sven Wegener
2022-12-05 19:00 Arthur Zamarin
2022-07-28 14:09 Sam James
2022-07-13  4:32 Sam James
2022-05-31  8:43 Sam James
2022-04-10 10:01 Sam James
2022-04-10 10:01 Sam James
2022-04-10 10:01 Sam James
2022-04-10 10:01 Sam James
2022-03-06  9:18 Sam James
2021-10-31 19:21 Sam James
2021-10-24 20:24 Sam James
2021-10-22  2:47 Sam James
2021-10-08  1:53 Sam James
2021-10-07  6:12 Sam James
2021-10-07  6:11 Sam James
2021-10-02 21:41 Sam James
2021-06-30 10:15 Ulrich Müller
2021-06-18 22:51 Sam James
2021-06-08  8:54 Sam James
2021-06-08  8:54 Sam James
2021-06-08  6:55 Sam James
2021-03-13 16:14 Sam James
2021-03-13 16:14 Sam James
2021-03-13 16:14 Sam James
2021-02-11 20:33 Conrad Kostecki
2021-01-27  3:55 Sam James
2021-01-22 19:50 Sam James
2021-01-22  4:57 Sam James
2021-01-22  3:34 Sam James
2021-01-15 17:05 Michał Górny
2021-01-02  1:43 Sam James
2021-01-02  0:35 Sam James
2020-12-18  9:00 Michał Górny
2020-12-09 12:12 Marek Szuba
2020-12-03 22:58 Marek Szuba
2019-11-08 13:25 Andreas K. Hüttel
2018-12-07 13:02 Gilles Dartiguelongue
2018-06-27 17:15 Pacho Ramos
2018-05-25 19:11 Aaron Bauman
2018-04-02 17:50 Gilles Dartiguelongue
2018-02-07 22:39 Gilles Dartiguelongue
2017-12-03 21:35 Matt Thode
2017-09-03 22:47 Gilles Dartiguelongue
2017-08-12  5:16 Matt Thode
2017-07-19 20:10 Ian Stakenvicius
2016-10-02  9:25 Pacho Ramos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1624056579.b51eac66d64d0d3aa8e26987b16db70135421a19.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox