From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 266371382C5 for ; Tue, 15 Jun 2021 06:56:21 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6200CE085E; Tue, 15 Jun 2021 06:56:20 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3C686E085E for ; Tue, 15 Jun 2021 06:56:20 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 06091335DB9 for ; Tue, 15 Jun 2021 06:56:19 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 9E3A1720 for ; Tue, 15 Jun 2021 06:56:17 +0000 (UTC) From: "Andrew Ammerlaan" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Andrew Ammerlaan" Message-ID: <1623740176.f5a89a542d5355496d0ac1dde6faeda00c5eaa9c.andrewammerlaan@gentoo> Subject: [gentoo-commits] repo/proj/guru:dev commit in: scripts/ X-VCS-Repository: repo/proj/guru X-VCS-Files: scripts/setup-and-run-repoman.sh X-VCS-Directories: scripts/ X-VCS-Committer: andrewammerlaan X-VCS-Committer-Name: Andrew Ammerlaan X-VCS-Revision: f5a89a542d5355496d0ac1dde6faeda00c5eaa9c X-VCS-Branch: dev Date: Tue, 15 Jun 2021 06:56:17 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 7873ec24-da7c-401e-a2d9-d2ede237c341 X-Archives-Hash: 9ad433ab8c451af03ce0a697c3bf8e62 commit: f5a89a542d5355496d0ac1dde6faeda00c5eaa9c Author: Yuan Liao gmail com> AuthorDate: Mon Jun 14 20:22:34 2021 +0000 Commit: Andrew Ammerlaan gentoo org> CommitDate: Tue Jun 15 06:56:16 2021 +0000 URL: https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=f5a89a54 scripts/setup-and-run-repoman.sh: use 'sort -V' to get latest tag Without the -V flag to enable version sort, 'sort' can falsely identify a version string like 3.0.9 to be greater than 3.0.10. This can be shown by running 'git tag | grep portage | sort -u' in the Portage Git tree. This issue is not so prominent for repoman yet because the latest version of repoman as of now is 3.0.3, but it will surface when repoman 3.0.10 is released. Signed-off-by: Yuan Liao gmail.com> Closes: https://github.com/gentoo/sci/pull/1094 Signed-off-by: Andrew Ammerlaan gentoo.org> scripts/setup-and-run-repoman.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/setup-and-run-repoman.sh b/scripts/setup-and-run-repoman.sh index f9e45a9cf..471a05181 100755 --- a/scripts/setup-and-run-repoman.sh +++ b/scripts/setup-and-run-repoman.sh @@ -16,7 +16,7 @@ git clone https://github.com/gentoo/portage.git cd portage # Get all versions, and read into array -mapfile -t RM_VERSIONS < <( git tag | grep repoman | sort -u ) +mapfile -t RM_VERSIONS < <( git tag | grep repoman | sort -uV ) # Select latests version (last element in array) RM_VERS="${RM_VERSIONS[-1]}" From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 4E2911382C5 for ; Tue, 15 Jun 2021 07:11:26 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E378FE0891; Tue, 15 Jun 2021 07:11:24 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id BB790E0893 for ; Tue, 15 Jun 2021 07:11:24 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 4F826340E64 for ; Tue, 15 Jun 2021 07:11:22 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id C5FFB7C4 for ; Tue, 15 Jun 2021 07:11:18 +0000 (UTC) From: "Andrew Ammerlaan" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Andrew Ammerlaan" Message-ID: <1623740176.f5a89a542d5355496d0ac1dde6faeda00c5eaa9c.andrewammerlaan@gentoo> Subject: [gentoo-commits] repo/proj/guru:master commit in: scripts/ X-VCS-Repository: repo/proj/guru X-VCS-Files: scripts/setup-and-run-repoman.sh X-VCS-Directories: scripts/ X-VCS-Committer: andrewammerlaan X-VCS-Committer-Name: Andrew Ammerlaan X-VCS-Revision: f5a89a542d5355496d0ac1dde6faeda00c5eaa9c X-VCS-Branch: master Date: Tue, 15 Jun 2021 07:11:18 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: d2eb9805-07df-4e40-a216-dc986a76ff29 X-Archives-Hash: 9128154fdf3e87ea1357400c24439815 Message-ID: <20210615071118.D8jxu9dAxfWnQltx9rnGPaoYVLcPk5IgEuJiqTQpjr4@z> commit: f5a89a542d5355496d0ac1dde6faeda00c5eaa9c Author: Yuan Liao gmail com> AuthorDate: Mon Jun 14 20:22:34 2021 +0000 Commit: Andrew Ammerlaan gentoo org> CommitDate: Tue Jun 15 06:56:16 2021 +0000 URL: https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=f5a89a54 scripts/setup-and-run-repoman.sh: use 'sort -V' to get latest tag Without the -V flag to enable version sort, 'sort' can falsely identify a version string like 3.0.9 to be greater than 3.0.10. This can be shown by running 'git tag | grep portage | sort -u' in the Portage Git tree. This issue is not so prominent for repoman yet because the latest version of repoman as of now is 3.0.3, but it will surface when repoman 3.0.10 is released. Signed-off-by: Yuan Liao gmail.com> Closes: https://github.com/gentoo/sci/pull/1094 Signed-off-by: Andrew Ammerlaan gentoo.org> scripts/setup-and-run-repoman.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/setup-and-run-repoman.sh b/scripts/setup-and-run-repoman.sh index f9e45a9cf..471a05181 100755 --- a/scripts/setup-and-run-repoman.sh +++ b/scripts/setup-and-run-repoman.sh @@ -16,7 +16,7 @@ git clone https://github.com/gentoo/portage.git cd portage # Get all versions, and read into array -mapfile -t RM_VERSIONS < <( git tag | grep repoman | sort -u ) +mapfile -t RM_VERSIONS < <( git tag | grep repoman | sort -uV ) # Select latests version (last element in array) RM_VERS="${RM_VERSIONS[-1]}"