public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Alexey Shvetsov" <alexxy@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: media-gfx/freecad/
Date: Mon, 31 May 2021 19:26:18 +0000 (UTC)	[thread overview]
Message-ID: <1622489162.b83b3eaf0c8423672624c1cb06cc0ff5bc4aa360.alexxy@gentoo> (raw)

commit:     b83b3eaf0c8423672624c1cb06cc0ff5bc4aa360
Author:     Bernd Waibel <waebbl-gentoo <AT> posteo <DOT> net>
AuthorDate: Tue May 18 18:40:01 2021 +0000
Commit:     Alexey Shvetsov <alexxy <AT> gentoo <DOT> org>
CommitDate: Mon May 31 19:26:02 2021 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b83b3eaf

media-gfx/freecad: fix opencascade issue

Fix an issue with sci-libs/opencascade:7.4.0, where a wrong options
has been passed to cmake.
Additionally improves testing which version of opencascade has been
installed and adds some guards to select correct options.

Closes: https://bugs.gentoo.org/789705
Package-Manager: Portage-3.0.18, Repoman-3.0.3
Signed-off-by: Bernd Waibel <waebbl-gentoo <AT> posteo.net>
Signed-off-by: Alexey Shvetsov <alexxy <AT> gentoo.org>

 media-gfx/freecad/freecad-0.19.2.ebuild | 27 +++++++++++++++++++--------
 1 file changed, 19 insertions(+), 8 deletions(-)

diff --git a/media-gfx/freecad/freecad-0.19.2.ebuild b/media-gfx/freecad/freecad-0.19.2.ebuild
index 7e191a22a02..4719298feb3 100644
--- a/media-gfx/freecad/freecad-0.19.2.ebuild
+++ b/media-gfx/freecad/freecad-0.19.2.ebuild
@@ -141,11 +141,20 @@ src_prepare() {
 	rm "${S}/cMake/FindCoin3D.cmake" || die
 
 	# Fix OpenCASCADE lookup
-	# TODO: check this for opencascade-7.5.1 locations, which have
-	# changed since 7.4.0 after that package has merged
-	sed -e 's|/usr/include/opencascade|${CASROOT}/include/opencascade|' \
-		-e 's|/usr/lib|${CASROOT}/'$(get_libdir)' NO_DEFAULT_PATH|' \
-		-i cMake/FindOpenCasCade.cmake || die
+	local OCC_P=$(best_version sci-libs/opencascade[vtk])
+	OCC_P=${OCC_P#sci-libs/}
+	local OCC_PV=${OCC_P#opencascade-}
+	OCC_PV=$(ver_cut 1-2 ${OCC_PV})
+	# check for CASROOT needed to ensure occ-7.5 is eselected and profile resourced
+	if [[ ${OCC_PV} = 7.5 && ${CASROOT} = "/usr" ]]; then
+		sed -e 's|/usr/include/opencascade|'${CASROOT}'/include/'${OCC_P}'|' \
+			-e 's|/usr/lib|'${CASROOT}'/'$(get_libdir)'/'${OCC_P}' NO_DEFAULT_PATH|' \
+			-i cMake/FindOpenCasCade.cmake || die
+	else
+		sed -e 's|/usr/include/opencascade|${CASROOT}/include/opencascade|' \
+			-e 's|/usr/lib|${CASROOT}/'$(get_libdir)' NO_DEFAULT_PATH|' \
+			-i cMake/FindOpenCasCade.cmake || die
+	fi
 
 	# Fix desktop file
 	sed -e 's/Exec=FreeCAD/Exec=freecad/' -i src/XDGData/org.freecadweb.FreeCAD.desktop || die
@@ -227,14 +236,16 @@ src_configure() {
 
 	if has_version ">=sci-libs/opencascade-7.5"; then
 		# bug https://bugs.gentoo.org/788274
+		local OCC_P=$(best_version sci-libs/opencascade[vtk])
+		OCC_P=${OCC_P#sci-libs/}
 		mycmakeargs+=(
-			-DOCC_INCLUDE_DIR="${CASROOT}"/include/opencascade-7.5.1
-			-DOCC_LIBRARY_DIR="${CASROOT}"/$(get_libdir)/opencascade-7.5.1
+			-DOCC_INCLUDE_DIR="${CASROOT}"/include/${OCC_P}
+			-DOCC_LIBRARY_DIR="${CASROOT}"/$(get_libdir)/${OCC_P}
 		)
 	else
 		# <occ-7.5 uses different layout
 		mycmakeargs+=(
-			-DOCC_INCLUDEDIR="${CASROOT}"/include/opencascade
+			-DOCC_INCLUDE_DIR="${CASROOT}"/include/opencascade
 			-DOCC_LIBRARY_DIR="${CASROOT}"/$(get_libdir)
 		)
 	fi


             reply	other threads:[~2021-05-31 19:26 UTC|newest]

Thread overview: 128+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-31 19:26 Alexey Shvetsov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-01-10 16:43 [gentoo-commits] repo/gentoo:master commit in: media-gfx/freecad/ Nowa Ammerlaan
2024-12-20 16:09 Nowa Ammerlaan
2024-12-01 16:15 Sam James
2024-12-01 16:04 Sam James
2024-11-27 23:26 Sam James
2024-11-25 15:32 Andreas Sturmlechner
2024-11-25 15:32 Andreas Sturmlechner
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-24 20:25 Sam James
2024-11-23 19:40 Andreas Sturmlechner
2024-11-22 18:39 Joonas Niilola
2024-11-20 10:31 Nowa Ammerlaan
2024-10-11  9:36 Andrew Ammerlaan
2024-09-30 13:37 Andrew Ammerlaan
2024-09-23  9:01 Andrew Ammerlaan
2024-09-15 15:42 Andrew Ammerlaan
2024-09-14 19:59 Alexey Shvetsov
2024-04-15  9:42 Andrew Ammerlaan
2024-04-15  8:38 Joonas Niilola
2024-03-27  2:57 Sam James
2024-03-24 13:54 Andrew Ammerlaan
2024-03-23 11:21 Andrew Ammerlaan
2024-03-09 10:17 Andrew Ammerlaan
2024-03-09  7:23 Andrew Ammerlaan
2024-01-05 13:12 Andrew Ammerlaan
2024-01-05 10:23 Andrew Ammerlaan
2023-11-25  9:11 Miroslav Šulc
2023-11-20 19:43 Andrew Ammerlaan
2023-05-08  8:19 Joonas Niilola
2023-05-08  8:19 Joonas Niilola
2023-05-07  8:44 Joonas Niilola
2023-02-23 17:30 Miroslav Šulc
2023-02-23 11:25 Andrew Ammerlaan
2023-02-21  6:18 Joonas Niilola
2023-01-09 19:23 Joonas Niilola
2022-11-27 13:23 Piotr Karbowski
2022-11-22 15:03 Joonas Niilola
2022-09-28  9:55 Joonas Niilola
2022-09-02 16:50 Joonas Niilola
2022-08-31  4:57 Joonas Niilola
2022-07-29  3:16 Sam James
2022-07-09 12:26 Matthew Smith
2022-05-19 12:12 Joonas Niilola
2022-04-18 11:35 Joonas Niilola
2022-04-14  8:54 Joonas Niilola
2022-04-06 17:30 Piotr Karbowski
2022-04-02 12:58 Andreas Sturmlechner
2022-02-03 15:52 John Helmert III
2022-01-28  8:24 Sam James
2022-01-10  1:04 Sam James
2022-01-10  1:04 Sam James
2021-12-04 21:52 Sam James
2021-12-04 21:52 Sam James
2021-11-30 12:50 Joonas Niilola
2021-11-30 12:50 Joonas Niilola
2021-11-02 10:04 Sam James
2021-11-02 10:04 Sam James
2021-07-10  9:17 Ionen Wolkens
2021-06-21 22:26 Sam James
2021-06-21 22:26 Sam James
2021-06-21 22:26 Sam James
2021-06-18 19:18 David Seifert
2021-06-16 14:02 Sam James
2021-06-15 14:42 Sam James
2021-06-05 14:14 Andrew Ammerlaan
2021-06-05 11:56 Andrew Ammerlaan
2021-06-03 19:15 Sam James
2021-05-31 19:26 Alexey Shvetsov
2021-05-24 12:30 Andrew Ammerlaan
2021-05-06 21:45 Sam James
2021-05-06 21:45 Sam James
2021-03-16 17:12 Michał Górny
2021-03-14 11:41 Joonas Niilola
2021-02-15  9:04 Joonas Niilola
2018-05-11 19:36 Andreas Sturmlechner
2018-03-13  9:33 Andreas Sturmlechner
2018-03-13  9:33 Andreas Sturmlechner
2018-03-13  9:33 Andreas Sturmlechner
2018-03-13  9:33 Andreas Sturmlechner
2018-03-02 22:08 Andreas Sturmlechner
2018-03-02 22:08 Andreas Sturmlechner
2018-03-02 22:08 Andreas Sturmlechner
2018-03-02 22:08 Andreas Sturmlechner
2018-01-05  0:35 Andreas Sturmlechner
2017-12-29 19:06 Miroslav Šulc
2017-12-29 19:06 Miroslav Šulc
2017-11-06  1:58 Andreas Sturmlechner
2017-11-06  1:58 Andreas Sturmlechner
2017-11-06  1:58 Andreas Sturmlechner
2017-11-06  1:58 Andreas Sturmlechner
2017-07-26 17:08 Alexey Shvetsov
2017-07-26 17:08 Alexey Shvetsov
2017-07-26 17:08 Alexey Shvetsov
2017-04-30 19:46 Davide Pesavento
2017-04-13 19:33 Patrice Clement
2017-01-20 14:21 David Seifert
2017-01-18 21:19 David Seifert
2017-01-18 21:19 David Seifert
2016-02-20 12:45 Michael Weber
2015-09-18 15:26 Michael Weber
2015-08-11  9:32 Michael Weber
2015-08-11  9:18 Michael Weber
2015-08-11  9:08 Michael Weber
2015-08-11  9:08 Michael Weber
2015-08-11  6:18 Michael Weber
2015-08-09 14:03 Michael Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1622489162.b83b3eaf0c8423672624c1cb06cc0ff5bc4aa360.alexxy@gentoo \
    --to=alexxy@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox