From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 8F4C713835A for ; Mon, 31 May 2021 16:36:03 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id CE02BE0827; Mon, 31 May 2021 16:36:02 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B2DDEE0827 for ; Mon, 31 May 2021 16:36:02 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id D0672335DB3 for ; Mon, 31 May 2021 16:36:00 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id B8A04720 for ; Mon, 31 May 2021 16:35:58 +0000 (UTC) From: "Michał Górny" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Michał Górny" Message-ID: <1622478929.5ee55de6c7547a68327cb3d57cd0e536d40b41e7.mgorny@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: bin/ X-VCS-Repository: proj/portage X-VCS-Files: bin/misc-functions.sh X-VCS-Directories: bin/ X-VCS-Committer: mgorny X-VCS-Committer-Name: Michał Górny X-VCS-Revision: 5ee55de6c7547a68327cb3d57cd0e536d40b41e7 X-VCS-Branch: master Date: Mon, 31 May 2021 16:35:58 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: a84a40ce-4a17-43f8-a9d0-0fc8411ace58 X-Archives-Hash: 534f138f29298bb163b7e038b10155fd commit: 5ee55de6c7547a68327cb3d57cd0e536d40b41e7 Author: Michał Górny gentoo org> AuthorDate: Mon May 31 12:36:01 2021 +0000 Commit: Michał Górny gentoo org> CommitDate: Mon May 31 16:35:29 2021 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=5ee55de6 Detect and report incorrect use of Report a QA warning when is used on a package installing ELF files. We can easily check this through presence of (non-empty) NEEDED build-info files. Signed-off-by: Michał Górny gentoo.org> Reviewed-by: Zac Medico gentoo.org> Closes: https://github.com/gentoo/portage/pull/723 bin/misc-functions.sh | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/bin/misc-functions.sh b/bin/misc-functions.sh index d7009d7eb..ddf53beea 100755 --- a/bin/misc-functions.sh +++ b/bin/misc-functions.sh @@ -201,10 +201,15 @@ install_qa_check() { echo "${QA_SONAME_NO_SYMLINK}" > \ "${PORTAGE_BUILDDIR}"/build-info/QA_SONAME_NO_SYMLINK - if has binchecks ${RESTRICT} && \ - [ -s "${PORTAGE_BUILDDIR}/build-info/NEEDED.ELF.2" ] ; then - eqawarn "QA Notice: RESTRICT=binchecks prevented checks on these ELF files:" - eqawarn "$(while read -r x; do x=${x#*;} ; x=${x%%;*} ; echo "${x#${EPREFIX}}" ; done < "${PORTAGE_BUILDDIR}"/build-info/NEEDED.ELF.2)" + if [[ -s ${PORTAGE_BUILDDIR}/build-info/NEEDED.ELF.2 ]]; then + if grep -qs '' "${EBUILD%/*}/metadata.xml"; then + eqawarn "QA Notice: stabilize-allarches/> found on package installing ELF files" + fi + + if has binchecks ${RESTRICT}; then + eqawarn "QA Notice: RESTRICT=binchecks prevented checks on these ELF files:" + eqawarn "$(while read -r x; do x=${x#*;} ; x=${x%%;*} ; echo "${x#${EPREFIX}}" ; done < "${PORTAGE_BUILDDIR}"/build-info/NEEDED.ELF.2)" + fi fi fi