From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 423B71382C5 for ; Wed, 12 May 2021 08:12:51 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6C7E7E0829; Wed, 12 May 2021 08:12:50 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 43352E0829 for ; Wed, 12 May 2021 08:12:50 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 8BF78340CD0 for ; Wed, 12 May 2021 08:12:48 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 193B35D2 for ; Wed, 12 May 2021 08:12:47 +0000 (UTC) From: "Andreas Sturmlechner" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Andreas Sturmlechner" Message-ID: <1620807159.8ad7c2e0f13807f5037ffa4c7fa18a5ee5127dfd.asturm@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: kde-apps/dolphin/, kde-apps/dolphin/files/ X-VCS-Repository: repo/gentoo X-VCS-Files: kde-apps/dolphin/dolphin-20.12.3-r1.ebuild kde-apps/dolphin/dolphin-21.04.0.ebuild kde-apps/dolphin/files/dolphin-21.04.0-fix-no-semantic-desktop.patch kde-apps/dolphin/files/dolphin-21.04.1-fix-no-semantic-desktop.patch X-VCS-Directories: kde-apps/dolphin/ kde-apps/dolphin/files/ X-VCS-Committer: asturm X-VCS-Committer-Name: Andreas Sturmlechner X-VCS-Revision: 8ad7c2e0f13807f5037ffa4c7fa18a5ee5127dfd X-VCS-Branch: master Date: Wed, 12 May 2021 08:12:47 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: d29d6013-a23a-42b1-b2b6-3fe54e6c9cb4 X-Archives-Hash: 97a4d513954194ea5ce62b544fe88586 commit: 8ad7c2e0f13807f5037ffa4c7fa18a5ee5127dfd Author: Andreas Sturmlechner gentoo org> AuthorDate: Wed May 12 07:42:48 2021 +0000 Commit: Andreas Sturmlechner gentoo org> CommitDate: Wed May 12 08:12:39 2021 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8ad7c2e0 kde-apps/dolphin: Update fix-no-semantic-desktop.patch w/ upstream MR Package-Manager: Portage-3.0.18, Repoman-3.0.3 Signed-off-by: Andreas Sturmlechner gentoo.org> kde-apps/dolphin/dolphin-20.12.3-r1.ebuild | 4 +-- kde-apps/dolphin/dolphin-21.04.0.ebuild | 4 +-- .../dolphin-21.04.0-fix-no-semantic-desktop.patch | 23 ------------ .../dolphin-21.04.1-fix-no-semantic-desktop.patch | 41 ++++++++++++++++++++++ 4 files changed, 45 insertions(+), 27 deletions(-) diff --git a/kde-apps/dolphin/dolphin-20.12.3-r1.ebuild b/kde-apps/dolphin/dolphin-20.12.3-r1.ebuild index 84ed6041e31..76be41e62f6 100644 --- a/kde-apps/dolphin/dolphin-20.12.3-r1.ebuild +++ b/kde-apps/dolphin/dolphin-20.12.3-r1.ebuild @@ -64,8 +64,8 @@ RDEPEND="${DEPEND} PATCHES=( "${FILESDIR}/${P}-fix-session-restore-w-o-tabs.patch" # KDE-bug 434911 - # TODO: Downstream hack, track upstream bug for better solution - "${FILESDIR}/${PN}-21.04.0-fix-no-semantic-desktop.patch" # KDE-bug 435586 + # pending https://invent.kde.org/system/dolphin/-/merge_requests/208 + "${FILESDIR}/${PN}-21.04.1-fix-no-semantic-desktop.patch" # KDE-bug 435586 ) src_configure() { diff --git a/kde-apps/dolphin/dolphin-21.04.0.ebuild b/kde-apps/dolphin/dolphin-21.04.0.ebuild index c9439d4dddc..6c4eb30ae3d 100644 --- a/kde-apps/dolphin/dolphin-21.04.0.ebuild +++ b/kde-apps/dolphin/dolphin-21.04.0.ebuild @@ -62,8 +62,8 @@ RDEPEND="${DEPEND} >=kde-apps/kio-extras-${PVCUT}:5 " -# TODO: Downstream hack, track upstream bug for better solution -PATCHES=( "${FILESDIR}/${P}-fix-no-semantic-desktop.patch" ) # KDE-bug 435586 +# pending https://invent.kde.org/system/dolphin/-/merge_requests/208 +PATCHES=( "${FILESDIR}/${PN}-21.04.1-fix-no-semantic-desktop.patch" ) # KDE-bug 435586 src_configure() { local mycmakeargs=( diff --git a/kde-apps/dolphin/files/dolphin-21.04.0-fix-no-semantic-desktop.patch b/kde-apps/dolphin/files/dolphin-21.04.0-fix-no-semantic-desktop.patch deleted file mode 100644 index 4f97a53c523..00000000000 --- a/kde-apps/dolphin/files/dolphin-21.04.0-fix-no-semantic-desktop.patch +++ /dev/null @@ -1,23 +0,0 @@ -diff --git a/src/search/dolphinfacetswidget.cpp b/src/search/dolphinfacetswidget.cpp -index d52d146a8..9f0078631 100644 ---- a/src/search/dolphinfacetswidget.cpp -+++ b/src/search/dolphinfacetswidget.cpp -@@ -7,6 +7,8 @@ - - #include "dolphinfacetswidget.h" - -+#include -+ - #include - - #include -@@ -257,7 +259,9 @@ void DolphinFacetsWidget::updateTagsSelector() - void DolphinFacetsWidget::updateTagsMenu() - { - updateTagsMenuItems({}, {}); -+#ifdef HAVE_BALOO - m_tagsLister.openUrl(QUrl(QStringLiteral("tags:/")), KCoreDirLister::OpenUrlFlag::Reload); -+#endif - } - - void DolphinFacetsWidget::updateTagsMenuItems(const QUrl&, const KFileItemList& items) diff --git a/kde-apps/dolphin/files/dolphin-21.04.1-fix-no-semantic-desktop.patch b/kde-apps/dolphin/files/dolphin-21.04.1-fix-no-semantic-desktop.patch new file mode 100644 index 00000000000..5636d0532ed --- /dev/null +++ b/kde-apps/dolphin/files/dolphin-21.04.1-fix-no-semantic-desktop.patch @@ -0,0 +1,41 @@ +From 29636baff0f0cf8d769aa75b1c458b96cf83b828 Mon Sep 17 00:00:00 2001 +From: Ismael Asensio +Date: Sun, 9 May 2021 21:10:44 +0200 +Subject: [PATCH] search/facetswidget: Check for protocol before trying to + fetch tags + +This was causing an error when trying to list items from the +non-existent `tags:` protocol. + +BUG: 435586 +FIXED-IN: 21.04.1 +--- + src/search/dolphinfacetswidget.cpp | 5 ++++- + 1 file changed, 4 insertions(+), 1 deletion(-) + +diff --git a/src/search/dolphinfacetswidget.cpp b/src/search/dolphinfacetswidget.cpp +index d4079f1eb..e8a43101f 100644 +--- a/src/search/dolphinfacetswidget.cpp ++++ b/src/search/dolphinfacetswidget.cpp +@@ -8,6 +8,7 @@ + #include "dolphinfacetswidget.h" + + #include ++#include + + #include + #include +@@ -245,7 +246,9 @@ void DolphinFacetsWidget::updateTagsSelector() + void DolphinFacetsWidget::updateTagsMenu() + { + updateTagsMenuItems({}, {}); +- m_tagsLister.openUrl(QUrl(QStringLiteral("tags:/")), KCoreDirLister::OpenUrlFlag::Reload); ++ if (KProtocolInfo::isKnownProtocol(QStringLiteral("tags"))) { ++ m_tagsLister.openUrl(QUrl(QStringLiteral("tags:/")), KCoreDirLister::OpenUrlFlag::Reload); ++ } + } + + void DolphinFacetsWidget::updateTagsMenuItems(const QUrl&, const KFileItemList& items) +-- +GitLab +