public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Andreas Sturmlechner" <asturm@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/kde:master commit in: kde-plasma/drkonqi/
Date: Fri,  7 May 2021 15:24:21 +0000 (UTC)	[thread overview]
Message-ID: <1620401024.a7e18f5f014f363c64c8353d191c1ee65ad3a18f.asturm@gentoo> (raw)

commit:     a7e18f5f014f363c64c8353d191c1ee65ad3a18f
Author:     Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
AuthorDate: Fri May  7 12:37:20 2021 +0000
Commit:     Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
CommitDate: Fri May  7 15:23:44 2021 +0000
URL:        https://gitweb.gentoo.org/proj/kde.git/commit/?id=a7e18f5f

kde-plasma/drkonqi: Unconditionally RDEPEND on sys-devel/gdb

This might have made sense back when it was part of
kde-plasma/plasma-workspace, but these days we can make
kde-plasma/drkonqi optional instead.

Package-Manager: Portage-3.0.18, Repoman-3.0.3
Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org>

 kde-plasma/drkonqi/drkonqi-5.21.5.ebuild | 16 +++++-----------
 kde-plasma/drkonqi/drkonqi-9999.ebuild   | 15 +++++----------
 2 files changed, 10 insertions(+), 21 deletions(-)

diff --git a/kde-plasma/drkonqi/drkonqi-5.21.5.ebuild b/kde-plasma/drkonqi/drkonqi-5.21.5.ebuild
index 1dd8639885..36714ea93c 100644
--- a/kde-plasma/drkonqi/drkonqi-5.21.5.ebuild
+++ b/kde-plasma/drkonqi/drkonqi-5.21.5.ebuild
@@ -15,7 +15,7 @@ SLOT="5"
 KEYWORDS="~amd64 ~arm ~arm64 ~ppc64 ~x86"
 IUSE="X"
 
-RDEPEND="
+COMMON_DEPEND="
 	>=dev-qt/qtdbus-${QTMIN}:5
 	>=dev-qt/qtgui-${QTMIN}:5
 	>=dev-qt/qtwidgets-${QTMIN}:5
@@ -38,9 +38,12 @@ RDEPEND="
 	>=kde-frameworks/syntax-highlighting-${KFMIN}:5
 	X? ( >=dev-qt/qtx11extras-${QTMIN}:5 )
 "
-DEPEND="${RDEPEND}
+DEPEND="${COMMON_DEPEND}
 	>=dev-qt/qtconcurrent-${QTMIN}:5
 "
+RDEPEND="${COMMON_DEPEND}
+	sys-devel/gdb
+"
 
 src_configure() {
 	local mycmakeargs=(
@@ -54,14 +57,5 @@ src_test() {
 	local myctestargs=(
 		-E "(connectiontest)"
 	)
-
 	ecm_src_test
 }
-
-pkg_postinst() {
-	ecm_pkg_postinst
-	if ! has_version "sys-devel/gdb"; then
-		elog "For more usability consider installing the following package:"
-		elog "    sys-devel/gdb - Easier debugging support"
-	fi
-}

diff --git a/kde-plasma/drkonqi/drkonqi-9999.ebuild b/kde-plasma/drkonqi/drkonqi-9999.ebuild
index 8d40a65e1a..c2d8927fd9 100644
--- a/kde-plasma/drkonqi/drkonqi-9999.ebuild
+++ b/kde-plasma/drkonqi/drkonqi-9999.ebuild
@@ -15,7 +15,7 @@ SLOT="5"
 KEYWORDS=""
 IUSE=""
 
-RDEPEND="
+COMMON_DEPEND="
 	>=dev-qt/qtdbus-${QTMIN}:5
 	>=dev-qt/qtgui-${QTMIN}:5
 	>=dev-qt/qtwidgets-${QTMIN}:5
@@ -37,9 +37,12 @@ RDEPEND="
 	>=kde-frameworks/kwindowsystem-${KFMIN}:5
 	>=kde-frameworks/syntax-highlighting-${KFMIN}:5
 "
-DEPEND="${RDEPEND}
+DEPEND="${COMMON_DEPEND}
 	>=dev-qt/qtconcurrent-${QTMIN}:5
 "
+RDEPEND="${COMMON_DEPEND}
+	sys-devel/gdb
+"
 
 src_test() {
 	# needs network access, bug #698510
@@ -48,11 +51,3 @@ src_test() {
 	)
 	ecm_src_test
 }
-
-pkg_postinst() {
-	ecm_pkg_postinst
-	if ! has_version "sys-devel/gdb"; then
-		elog "For more usability consider installing the following package:"
-		elog "    sys-devel/gdb - Easier debugging support"
-	fi
-}


             reply	other threads:[~2021-05-07 15:24 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-07 15:24 Andreas Sturmlechner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-02-02 21:38 [gentoo-commits] proj/kde:master commit in: kde-plasma/drkonqi/ Andreas Sturmlechner
2024-12-11 16:07 Andreas Sturmlechner
2024-10-07 17:23 Sam James
2024-07-03 20:31 Andreas Sturmlechner
2024-06-18 20:13 Andreas Sturmlechner
2024-01-13 16:36 Sam James
2024-01-13 16:36 Sam James
2023-12-16 13:32 Andreas Sturmlechner
2023-09-19 14:12 Andreas Sturmlechner
2023-09-19 14:12 Andreas Sturmlechner
2023-03-26 11:15 Andreas Sturmlechner
2023-02-22 10:21 Andreas Sturmlechner
2022-12-27 10:52 Andreas Sturmlechner
2022-10-26 13:21 Andreas Sturmlechner
2022-10-09 16:39 Andreas Sturmlechner
2022-09-24 20:56 Andreas Sturmlechner
2022-06-21 11:28 Andreas Sturmlechner
2021-05-12  7:50 Andreas Sturmlechner
2021-05-07 15:24 Andreas Sturmlechner
2020-09-04  8:43 Andreas Sturmlechner
2020-05-19 11:20 Andreas Sturmlechner
2020-04-25 16:06 Andreas Sturmlechner
2020-04-25 16:06 Andreas Sturmlechner
2020-04-25 16:06 Andreas Sturmlechner
2019-10-26 11:02 Andreas Sturmlechner
2019-10-24 18:37 Andreas Sturmlechner
2017-12-25 10:05 Michael Palimaka
2017-10-09 19:17 Andreas Sturmlechner
2017-08-11 18:14 Andreas Sturmlechner
2017-08-11 14:16 Andreas Sturmlechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1620401024.a7e18f5f014f363c64c8353d191c1ee65ad3a18f.asturm@gentoo \
    --to=asturm@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox