public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Marco Scardovi" <marco@scardovi.com>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/proj/guru:dev commit in: app-editors/atom-bin/
Date: Wed, 14 Apr 2021 08:55:10 +0000 (UTC)	[thread overview]
Message-ID: <1618390499.e8f93073b5aa09273fa5ba1770002c55827d7d41.marco@gentoo> (raw)

commit:     e8f93073b5aa09273fa5ba1770002c55827d7d41
Author:     Marco Scardovi <marco <AT> scardovi <DOT> com>
AuthorDate: Wed Apr 14 08:54:59 2021 +0000
Commit:     Marco Scardovi <marco <AT> scardovi <DOT> com>
CommitDate: Wed Apr 14 08:54:59 2021 +0000
URL:        https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=e8f93073

app-editors/atom-bin: drop nodejs

The package itself already comes with npm/node.
Providing a custom flag for nodejs is unuseful.
This will not make any trouble if you use nodejs as atom
will call it internally.

Package-Manager: Portage-3.0.18, Repoman-3.0.3
Signed-off-by: Marco Scardovi <marco <AT> scardovi.com>

 app-editors/atom-bin/atom-bin-1.56.0.ebuild | 17 ++++-------------
 app-editors/atom-bin/metadata.xml           |  3 ---
 2 files changed, 4 insertions(+), 16 deletions(-)

diff --git a/app-editors/atom-bin/atom-bin-1.56.0.ebuild b/app-editors/atom-bin/atom-bin-1.56.0.ebuild
index 40dab62ac..c8b51001d 100644
--- a/app-editors/atom-bin/atom-bin-1.56.0.ebuild
+++ b/app-editors/atom-bin/atom-bin-1.56.0.ebuild
@@ -12,7 +12,7 @@ SRC_URI="https://github.com/atom/atom/releases/download/v${PV}/atom-amd64.tar.gz
 LICENSE="MIT"
 SLOT="0"
 KEYWORDS="~amd64"
-IUSE="alsa cups nodejs ssl test X"
+IUSE="alsa cups ssl test X"
 RESTRICT="!test? ( test )"
 
 S="${WORKDIR}/atom-${PV}-amd64"
@@ -26,7 +26,6 @@ RDEPEND="
 	dev-vcs/git
 	alsa? ( media-libs/alsa-lib )
 	cups? ( net-print/cups )
-	nodejs? ( net-libs/nodejs[npm] )
 	ssl? (
 		dev-libs/openssl
 		dev-libs/openssl-compat
@@ -67,18 +66,10 @@ src_install(){
 	dosym ../../opt/"${PN}"/atom "${EPREFIX}"/usr/bin/atom
 	fperms +x /opt/"${PN}"/atom
 
-	if use nodejs; then
-		rm resources/app/apm/bin/npm
-		rm resources/app/apm/BUNDLED_NODE_VERSION
-
-		#Fix apm to use nodejs binary
-		sed -i "s#\$binDir\/\$nodeBin#\$\(which \$nodeBin\)#" resources/app/apm/bin/apm
-	else
-		fperms +x /opt/"${PN}"/resources/app/apm/bin/npm
-	fi
-
-	fperms +x /opt/"${PN}"/resources/app/apm/bin/node
+	# I will use only npm provided with package itself
 	fperms +x /opt/"${PN}"/resources/app/apm/bin/apm
+	fperms +x /opt/"${PN}"/resources/app/apm/bin/node
+	fperms +x /opt/"${PN}"/resources/app/apm/bin/npm
 
 	doicon atom.png
 	make_desktop_entry "/opt/atom-bin/atom %U" "Atom" "atom" \

diff --git a/app-editors/atom-bin/metadata.xml b/app-editors/atom-bin/metadata.xml
index ada38d070..a0b29038e 100644
--- a/app-editors/atom-bin/metadata.xml
+++ b/app-editors/atom-bin/metadata.xml
@@ -8,7 +8,4 @@
 	<upstream>
 		<remote-id type="github">atom/atom</remote-id>
 	</upstream>
-	<use>
-		<flag name="nodejs">Enable nodejs support in USE</flag>
-	</use>
 </pkgmetadata>


             reply	other threads:[~2021-04-14  8:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-14  8:55 Marco Scardovi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-05-27 16:46 [gentoo-commits] repo/proj/guru:dev commit in: app-editors/atom-bin/ Rahul Sandhu
2022-05-25 19:38 Alessandro Barbieri
2022-01-23 13:28 Marco Scardovi
2021-12-16  7:10 Marco Scardovi
2021-12-16  7:09 Marco Scardovi
2021-07-17 13:31 Marco Scardovi
2021-07-05 15:57 Marco Scardovi
2021-05-12  7:32 Marco Scardovi
2021-04-19  5:29 Marco Scardovi
2021-04-16 18:08 Marco Scardovi
2021-04-15 18:48 Marco Scardovi
2021-04-14 15:16 Marco Scardovi
2021-04-14  8:23 Marco Scardovi
2021-04-11  6:49 Marco Scardovi
2021-04-10 12:51 Marco Scardovi
2021-04-09 11:48 Marco Scardovi
2021-04-09 11:47 Marco Scardovi
2021-04-08  6:25 Marco Scardovi
2021-04-06 20:13 Marco Scardovi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1618390499.e8f93073b5aa09273fa5ba1770002c55827d7d41.marco@gentoo \
    --to=marco@scardovi.com \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox