From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 3F4A513835A for ; Tue, 30 Mar 2021 18:15:55 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 847F4E0BC4; Tue, 30 Mar 2021 18:15:54 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 690C2E0BC4 for ; Tue, 30 Mar 2021 18:15:54 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 889CF340D3E for ; Tue, 30 Mar 2021 18:15:53 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 1845263E for ; Tue, 30 Mar 2021 18:15:51 +0000 (UTC) From: "Ulrich Müller" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Ulrich Müller" Message-ID: <1617128096.f72795c60b475cc36501ed03b7b3a03c38bcf851.ulm@gentoo> Subject: [gentoo-commits] proj/devmanual:master commit in: ebuild-writing/common-mistakes/ X-VCS-Repository: proj/devmanual X-VCS-Files: ebuild-writing/common-mistakes/text.xml X-VCS-Directories: ebuild-writing/common-mistakes/ X-VCS-Committer: ulm X-VCS-Committer-Name: Ulrich Müller X-VCS-Revision: f72795c60b475cc36501ed03b7b3a03c38bcf851 X-VCS-Branch: master Date: Tue, 30 Mar 2021 18:15:51 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 1ebdd86c-3bda-4952-885b-225198aa376b X-Archives-Hash: c8d35dbb8779ac0e1e8e9ccf24a1944b commit: f72795c60b475cc36501ed03b7b3a03c38bcf851 Author: Sam James gentoo org> AuthorDate: Sun Mar 21 02:50:27 2021 +0000 Commit: Ulrich Müller gentoo org> CommitDate: Tue Mar 30 18:14:56 2021 +0000 URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=f72795c6 ebuild-writing/common-mistakes: mention "the compiler", not only GCC Signed-off-by: Sam James gentoo.org> Signed-off-by: Ulrich Müller gentoo.org> ebuild-writing/common-mistakes/text.xml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/ebuild-writing/common-mistakes/text.xml b/ebuild-writing/common-mistakes/text.xml index 6f33248..9455688 100644 --- a/ebuild-writing/common-mistakes/text.xml +++ b/ebuild-writing/common-mistakes/text.xml @@ -176,13 +176,14 @@ Always check that it's really gone in the build log.

Specific -Werror=... flags

-GCC can turn any specific warning into an error. A specific -Werror flag would -be "-Werror=implicit-function-declaration" for example and will only affect -warnings about implicit function declarations. It's mostly safe to leave these -untouched, cause they are pinned to this issue and should not cause random -build time breakage. Also, we can expect that upstream did this on purpose to -avoid known runtime errors and not just for testing their builds. However you -should check the specified warnings yourself or ask other developers if unsure. +The compiler (e.g. GCC) can turn any specific warning into an error. A +specific -Werror flag would be "-Werror=implicit-function-declaration" for +example and will only affect warnings about implicit function declarations. It's +mostly safe to leave these untouched, cause they are pinned to this issue and +should not cause random build time breakage. Also, we can expect that upstream +did this on purpose to avoid known runtime errors and not just for testing their +builds. However, you should check the specified warnings yourself or ask other +developers if unsure.

Exceptions