From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id B75AC13835B for ; Thu, 25 Mar 2021 14:39:37 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 11810E083D; Thu, 25 Mar 2021 14:39:37 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id F10A1E083D for ; Thu, 25 Mar 2021 14:39:36 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 2590433BE14 for ; Thu, 25 Mar 2021 14:39:36 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id CFCA0632 for ; Thu, 25 Mar 2021 14:39:34 +0000 (UTC) From: "Sam James" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" Message-ID: <1616683162.8e9639e43323449a7193ef717c85b47c70a82877.sam@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: dev-libs/hyperscan/ X-VCS-Repository: repo/gentoo X-VCS-Files: dev-libs/hyperscan/hyperscan-5.3.0.ebuild dev-libs/hyperscan/hyperscan-5.4.0.ebuild X-VCS-Directories: dev-libs/hyperscan/ X-VCS-Committer: sam X-VCS-Committer-Name: Sam James X-VCS-Revision: 8e9639e43323449a7193ef717c85b47c70a82877 X-VCS-Branch: master Date: Thu, 25 Mar 2021 14:39:34 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 2c66b85c-bb99-4f4f-a41a-b32d65166cdc X-Archives-Hash: 2765fa04ff3a885c8653b0c5acef96f3 commit: 8e9639e43323449a7193ef717c85b47c70a82877 Author: Sam James gentoo org> AuthorDate: Thu Mar 25 14:36:38 2021 +0000 Commit: Sam James gentoo org> CommitDate: Thu Mar 25 14:39:22 2021 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8e9639e4 dev-libs/hyperscan: fix cpu_flags_* default (disable) We shouldn't enable CPU_FLAGS_* by default. Users don't mask or explicitly disable flags they don't have, they just enable the ones they _do_ have. Even in this case, where we NEED SSSE3, it's wrong to default it on rather than making the user aware of the requirement. Reported-by: ggabriel Signed-off-by: Sam James gentoo.org> dev-libs/hyperscan/hyperscan-5.3.0.ebuild | 4 +++- dev-libs/hyperscan/hyperscan-5.4.0.ebuild | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/dev-libs/hyperscan/hyperscan-5.3.0.ebuild b/dev-libs/hyperscan/hyperscan-5.3.0.ebuild index 84f3d508c03..e05b00364aa 100644 --- a/dev-libs/hyperscan/hyperscan-5.3.0.ebuild +++ b/dev-libs/hyperscan/hyperscan-5.3.0.ebuild @@ -14,7 +14,7 @@ HOMEPAGE="https://www.hyperscan.io/ https://github.com/intel/hyperscan" LICENSE="BSD" SLOT="0" KEYWORDS="amd64 x86" -IUSE="cpu_flags_x86_avx2 +cpu_flags_x86_ssse3 static-libs" +IUSE="cpu_flags_x86_avx2 cpu_flags_x86_ssse3 static-libs" RDEPEND="dev-libs/boost" DEPEND="${RDEPEND}" @@ -23,6 +23,8 @@ BDEPEND=" dev-util/ragel " +# We can't default this to on as it's against the expectation of +# how CPU_FLAGS_* work for users. REQUIRED_USE="cpu_flags_x86_ssse3" src_prepare() { diff --git a/dev-libs/hyperscan/hyperscan-5.4.0.ebuild b/dev-libs/hyperscan/hyperscan-5.4.0.ebuild index 6e40c26f0f8..9cd4cf02b42 100644 --- a/dev-libs/hyperscan/hyperscan-5.4.0.ebuild +++ b/dev-libs/hyperscan/hyperscan-5.4.0.ebuild @@ -14,7 +14,7 @@ HOMEPAGE="https://www.hyperscan.io/ https://github.com/intel/hyperscan" LICENSE="BSD" SLOT="0" KEYWORDS="amd64 x86" -IUSE="cpu_flags_x86_avx2 +cpu_flags_x86_ssse3 static-libs" +IUSE="cpu_flags_x86_avx2 cpu_flags_x86_ssse3 static-libs" RDEPEND="dev-libs/boost:=" DEPEND="${RDEPEND}" @@ -23,6 +23,8 @@ BDEPEND=" dev-util/ragel " +# We can't default this to on as it's against the expectation of +# how CPU_FLAGS_* work for users. REQUIRED_USE="cpu_flags_x86_ssse3" src_prepare() {