From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-commits+bounces-1261172-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id CB6111382C5
	for <garchives@archives.gentoo.org>; Mon, 15 Mar 2021 01:26:06 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 043E0E085A;
	Mon, 15 Mar 2021 01:26:06 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id DA0ACE085A
	for <gentoo-commits@lists.gentoo.org>; Mon, 15 Mar 2021 01:26:05 +0000 (UTC)
Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.gentoo.org (Postfix) with ESMTPS id 79DF3335D16
	for <gentoo-commits@lists.gentoo.org>; Mon, 15 Mar 2021 01:26:04 +0000 (UTC)
Received: from localhost.localdomain (localhost [IPv6:::1])
	by oystercatcher.gentoo.org (Postfix) with ESMTP id D79064A6
	for <gentoo-commits@lists.gentoo.org>; Mon, 15 Mar 2021 01:26:02 +0000 (UTC)
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Content-Transfer-Encoding: 8bit
Content-type: text/plain; charset=UTF-8
Reply-To: gentoo-dev@lists.gentoo.org, "Sam James" <sam@gentoo.org>
Message-ID: <1615771533.0a0d469ed446b082600e3f4c7db0472dccd87d58.sam@gentoo>
Subject: [gentoo-commits] repo/gentoo:master commit in: app-admin/sagan/
X-VCS-Repository: repo/gentoo
X-VCS-Files: app-admin/sagan/sagan-2.0.1-r4.ebuild
X-VCS-Directories: app-admin/sagan/
X-VCS-Committer: sam
X-VCS-Committer-Name: Sam James
X-VCS-Revision: 0a0d469ed446b082600e3f4c7db0472dccd87d58
X-VCS-Branch: master
Date: Mon, 15 Mar 2021 01:26:02 +0000 (UTC)
Precedence: bulk
List-Post: <mailto:gentoo-commits@lists.gentoo.org>
List-Help: <mailto:gentoo-commits+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org>
X-BeenThere: gentoo-commits@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-Archives-Salt: 903147f1-bade-4ef1-8db7-f9a08a70d3d5
X-Archives-Hash: f3796cee8407f0ca8f2dde000fc0cbc3

commit:     0a0d469ed446b082600e3f4c7db0472dccd87d58
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Mon Mar 15 01:25:33 2021 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Mon Mar 15 01:25:33 2021 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0a0d469e

app-admin/sagan: add warning to fix permissions for older installs

Bug: https://bugs.gentoo.org/775902
Signed-off-by: Sam James <sam <AT> gentoo.org>

 app-admin/sagan/sagan-2.0.1-r4.ebuild | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/app-admin/sagan/sagan-2.0.1-r4.ebuild b/app-admin/sagan/sagan-2.0.1-r4.ebuild
index 50e4eef4484..aa3ce608b68 100644
--- a/app-admin/sagan/sagan-2.0.1-r4.ebuild
+++ b/app-admin/sagan/sagan-2.0.1-r4.ebuild
@@ -102,9 +102,27 @@ src_install() {
 	dodoc -r extra/*
 }
 
+pkg_preinst() {
+	# bug #775902 revealed that we need 750 on /var/log/sagan or e.g.
+	# logrotate will fail. Let's inform the user to fix up permissions
+	# in such a case.
+	#  (fperms won't modify the live filesystem.)
+	HAD_BROKEN_PERMS=0
+
+	if has_version "<app-admin/sagan-2.0.1-r4" ; then
+		HAD_BROKEN_PERMS=1
+	fi
+}
+
 pkg_postinst() {
 	tmpfiles_process sagan.conf
 
+	if [[ "${HAD_BROKEN_PERMS}" -eq 1 ]] ; then
+		ewarn "Please fix the permissions on ${EPREFIX}/var/log/sagan:"
+		ewarn "e.g. chmod 750 /var/log/sagan"
+		ewarn "See bug #775902"
+	fi
+
 	if use smtp; then
 		ewarn "You have enabled smtp use flag. If you plan on using Sagan with"
 		ewarn "email, create valid writable home directory for user 'sagan'"