public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-lang/ocaml/
Date: Fri, 12 Mar 2021 18:23:00 +0000 (UTC)	[thread overview]
Message-ID: <1615573355.4bbb6a45f6d3e0193703828d6cdf04b46babc7b9.sam@gentoo> (raw)

commit:     4bbb6a45f6d3e0193703828d6cdf04b46babc7b9
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Fri Mar 12 18:13:26 2021 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Fri Mar 12 18:22:35 2021 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4bbb6a45

dev-lang/ocaml: don't warn on textrels on 32-bit arches

We can't do anything about it on 32-bit arches and it causes
unnecessary test failures in OCaml-based packages
(because of the diff in output).

Closes: https://bugs.gentoo.org/773226
Signed-off-by: Sam James <sam <AT> gentoo.org>

 dev-lang/ocaml/ocaml-4.05.0-r3.ebuild |  8 ++++++++
 dev-lang/ocaml/ocaml-4.09.0.ebuild    | 11 +++++++++++
 dev-lang/ocaml/ocaml-4.10.0.ebuild    | 11 +++++++++++
 dev-lang/ocaml/ocaml-4.10.2.ebuild    | 11 +++++++++++
 dev-lang/ocaml/ocaml-4.11.1.ebuild    | 11 +++++++++++
 dev-lang/ocaml/ocaml-4.11.2.ebuild    | 11 +++++++++++
 6 files changed, 63 insertions(+)

diff --git a/dev-lang/ocaml/ocaml-4.05.0-r3.ebuild b/dev-lang/ocaml/ocaml-4.05.0-r3.ebuild
index c05a2cadaf4..69094b6cb10 100644
--- a/dev-lang/ocaml/ocaml-4.05.0-r3.ebuild
+++ b/dev-lang/ocaml/ocaml-4.05.0-r3.ebuild
@@ -66,6 +66,14 @@ src_configure() {
 	# -ggdb3 & co makes it behave weirdly, breaks sexplib
 	replace-flags -ggdb* -ggdb
 
+	# OCaml generates textrels on 32-bit arches
+	# We can't do anything about it, but disabling it means that tests
+	# for OCaml-based packages won't fail on unexpected output
+	# bug #773226
+	if use arm || use ppc || use x86 ; then
+		append-ldflags "-Wl,-z,notext"
+	fi
+
 	# It doesn't compile on alpha without this LDFLAGS
 	use alpha && append-ldflags "-Wl,--no-relax"
 

diff --git a/dev-lang/ocaml/ocaml-4.09.0.ebuild b/dev-lang/ocaml/ocaml-4.09.0.ebuild
index 181f30b8fef..f74988668b8 100644
--- a/dev-lang/ocaml/ocaml-4.09.0.ebuild
+++ b/dev-lang/ocaml/ocaml-4.09.0.ebuild
@@ -3,6 +3,8 @@
 
 EAPI=7
 
+inherit flag-o-matic
+
 HOMEPAGE="https://ocaml.org/"
 SRC_URI="https://github.com/ocaml/ocaml/archive/${PV}.tar.gz -> ${P}.tar.gz"
 DESCRIPTION="Programming language supporting functional, imperative & object-oriented styles"
@@ -23,6 +25,15 @@ PATCHES=("${FILESDIR}"/${PN}-4.09.0-gcc-10.patch)
 
 src_prepare() {
 	default
+
+	# OCaml generates textrels on 32-bit arches
+	# We can't do anything about it, but disabling it means that tests
+	# for OCaml-based packages won't fail on unexpected output
+	# bug #773226
+	if use arm || use ppc || use x86 ; then
+		append-ldflags "-Wl,-z,notext"
+	fi
+
 	# Upstream build ignores LDFLAGS in several places.
 	sed -i -e 's/\(^MKDLL=.*\)/\1 $(LDFLAGS)/' \
 		-e 's/\(^OC_CFLAGS=.*\)/\1 $(LDFLAGS)/' \

diff --git a/dev-lang/ocaml/ocaml-4.10.0.ebuild b/dev-lang/ocaml/ocaml-4.10.0.ebuild
index 903534e88c8..a91786e0301 100644
--- a/dev-lang/ocaml/ocaml-4.10.0.ebuild
+++ b/dev-lang/ocaml/ocaml-4.10.0.ebuild
@@ -3,6 +3,8 @@
 
 EAPI=7
 
+inherit flag-o-matic
+
 HOMEPAGE="https://ocaml.org/"
 SRC_URI="https://github.com/ocaml/ocaml/archive/${PV}.tar.gz -> ${P}.tar.gz"
 DESCRIPTION="Programming language supporting functional, imperative & object-oriented styles"
@@ -23,6 +25,15 @@ PDEPEND="emacs? ( app-emacs/ocaml-mode )
 
 src_prepare() {
 	default
+
+	# OCaml generates textrels on 32-bit arches
+	# We can't do anything about it, but disabling it means that tests
+	# for OCaml-based packages won't fail on unexpected output
+	# bug #773226
+	if use arm || use ppc || use x86 ; then
+		append-ldflags "-Wl,-z,notext"
+	fi
+
 	# Upstream build ignores LDFLAGS in several places.
 	sed -i -e 's/\(^MKDLL=.*\)/\1 $(LDFLAGS)/' \
 		-e 's/\(^OC_CFLAGS=.*\)/\1 $(LDFLAGS)/' \

diff --git a/dev-lang/ocaml/ocaml-4.10.2.ebuild b/dev-lang/ocaml/ocaml-4.10.2.ebuild
index f29e4ae7220..208d8612d6a 100644
--- a/dev-lang/ocaml/ocaml-4.10.2.ebuild
+++ b/dev-lang/ocaml/ocaml-4.10.2.ebuild
@@ -3,6 +3,8 @@
 
 EAPI=7
 
+inherit flag-o-matic
+
 HOMEPAGE="https://ocaml.org/"
 SRC_URI="https://github.com/ocaml/ocaml/archive/${PV}.tar.gz -> ${P}.tar.gz"
 DESCRIPTION="Programming language supporting functional, imperative & object-oriented styles"
@@ -21,6 +23,15 @@ PDEPEND="emacs? ( app-emacs/ocaml-mode )
 
 src_prepare() {
 	default
+
+	# OCaml generates textrels on 32-bit arches
+	# We can't do anything about it, but disabling it means that tests
+	# for OCaml-based packages won't fail on unexpected output
+	# bug #773226
+	if use arm || use ppc || use x86 ; then
+		append-ldflags "-Wl,-z,notext"
+	fi
+
 	# Upstream build ignores LDFLAGS in several places.
 	sed -i -e 's/\(^MKDLL=.*\)/\1 $(LDFLAGS)/' \
 		-e 's/\(^OC_CFLAGS=.*\)/\1 $(LDFLAGS)/' \

diff --git a/dev-lang/ocaml/ocaml-4.11.1.ebuild b/dev-lang/ocaml/ocaml-4.11.1.ebuild
index 280d813184b..b9fe45e6172 100644
--- a/dev-lang/ocaml/ocaml-4.11.1.ebuild
+++ b/dev-lang/ocaml/ocaml-4.11.1.ebuild
@@ -3,6 +3,8 @@
 
 EAPI=7
 
+inherit flag-o-matic
+
 HOMEPAGE="https://ocaml.org/"
 SRC_URI="https://github.com/ocaml/ocaml/archive/${PV}.tar.gz -> ${P}.tar.gz"
 DESCRIPTION="Programming language supporting functional, imperative & object-oriented styles"
@@ -21,6 +23,15 @@ PDEPEND="emacs? ( app-emacs/ocaml-mode )
 
 src_prepare() {
 	default
+
+	# OCaml generates textrels on 32-bit arches
+	# We can't do anything about it, but disabling it means that tests
+	# for OCaml-based packages won't fail on unexpected output
+	# bug #773226
+	if use arm || use ppc || use x86 ; then
+		append-ldflags "-Wl,-z,notext"
+	fi
+
 	# Upstream build ignores LDFLAGS in several places.
 	sed -i -e 's/\(^MKDLL=.*\)/\1 $(LDFLAGS)/' \
 		-e 's/\(^OC_CFLAGS=.*\)/\1 $(LDFLAGS)/' \

diff --git a/dev-lang/ocaml/ocaml-4.11.2.ebuild b/dev-lang/ocaml/ocaml-4.11.2.ebuild
index 280d813184b..e3298bdfc89 100644
--- a/dev-lang/ocaml/ocaml-4.11.2.ebuild
+++ b/dev-lang/ocaml/ocaml-4.11.2.ebuild
@@ -3,6 +3,8 @@
 
 EAPI=7
 
+inherit flag-o-matic
+
 HOMEPAGE="https://ocaml.org/"
 SRC_URI="https://github.com/ocaml/ocaml/archive/${PV}.tar.gz -> ${P}.tar.gz"
 DESCRIPTION="Programming language supporting functional, imperative & object-oriented styles"
@@ -21,6 +23,15 @@ PDEPEND="emacs? ( app-emacs/ocaml-mode )
 
 src_prepare() {
 	default
+
+	# OCaml generates textrels on 32-bit arches
+	# We can't do anything about it, but disabling it means that tests
+	# for OCaml-based packages won't fail on unexpected output
+	# bug #773226
+	#if use arm || use ppc || use x86 ; then
+		append-ldflags "-Wl,-z,notext"
+	#fi
+
 	# Upstream build ignores LDFLAGS in several places.
 	sed -i -e 's/\(^MKDLL=.*\)/\1 $(LDFLAGS)/' \
 		-e 's/\(^OC_CFLAGS=.*\)/\1 $(LDFLAGS)/' \


             reply	other threads:[~2021-03-12 18:23 UTC|newest]

Thread overview: 117+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12 18:23 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-12-30  9:42 [gentoo-commits] repo/gentoo:master commit in: dev-lang/ocaml/ Alfredo Tupone
2024-10-15 15:25 Arthur Zamarin
2024-10-11 20:39 Alfredo Tupone
2024-06-09 10:45 Alfredo Tupone
2024-06-09 10:45 Alfredo Tupone
2024-06-02  8:21 Alfredo Tupone
2024-04-29 20:33 Alfredo Tupone
2023-10-28  0:24 Sam James
2023-06-24  2:59 Sam James
2023-04-03 19:09 Arthur Zamarin
2023-04-03 19:09 Arthur Zamarin
2023-03-17 11:41 Arthur Zamarin
2023-03-17 11:27 Arthur Zamarin
2023-03-17  8:52 Arthur Zamarin
2023-03-17  3:21 Sam James
2023-03-17  2:29 Sam James
2023-03-17  2:29 Sam James
2023-03-17  2:29 Sam James
2023-03-16 23:20 Sam James
2023-03-16 23:16 Sam James
2023-03-16 23:16 Sam James
2023-02-15 18:38 Matt Turner
2023-02-10 19:11 Alfredo Tupone
2022-09-29  7:03 Alfredo Tupone
2022-02-28 19:31 Alfredo Tupone
2022-02-27  8:57 Agostino Sarubbo
2022-02-27  8:56 Agostino Sarubbo
2022-02-26 12:33 Arthur Zamarin
2022-02-26 12:08 Arthur Zamarin
2022-02-26 11:53 Arthur Zamarin
2021-10-17 19:09 Sam James
2021-10-17  0:13 Sam James
2021-10-16 10:31 Sam James
2021-10-16 10:14 Sam James
2021-10-13  6:02 Agostino Sarubbo
2021-10-13  5:54 Agostino Sarubbo
2021-10-09  5:56 Sam James
2021-10-07  6:37 Sam James
2021-10-02  5:23 Sam James
2021-10-02  5:23 Sam James
2021-09-15 19:42 Alfredo Tupone
2021-06-18 21:09 Sam James
2021-06-09 21:45 Sam James
2021-06-08  4:59 Sam James
2021-03-08 15:09 Sam James
2021-02-24 16:22 Sam James
2021-02-17 18:04 Alfredo Tupone
2021-02-17  6:58 Alfredo Tupone
2021-01-17 17:38 Sam James
2020-12-28 11:49 Sam James
2020-04-12 21:52 Mart Raudsepp
2020-03-20  8:07 Sergei Trofimovich
2020-03-02 11:49 Sergei Trofimovich
2020-02-11 12:15 Agostino Sarubbo
2020-02-11 11:44 Agostino Sarubbo
2020-02-11 11:36 Agostino Sarubbo
2020-02-10  8:18 Agostino Sarubbo
2020-02-10  8:16 Agostino Sarubbo
2020-02-09 10:31 Agostino Sarubbo
2019-12-28 13:40 Mikle Kolyada
2019-12-27 13:39 Mikle Kolyada
2019-01-04 18:39 Tim Harder
2018-04-28  1:16 Matt Turner
2017-11-04  9:53 Alexis Ballier
2017-11-04  9:53 Alexis Ballier
2017-10-14 11:41 Alexis Ballier
2017-10-14 11:13 Alexis Ballier
2017-10-04 11:09 Alexis Ballier
2017-10-04 11:09 Alexis Ballier
2017-09-27  9:25 Sergei Trofimovich
2017-07-13 22:09 Alexis Ballier
2017-07-13 20:42 Alexis Ballier
2017-07-13 12:38 Alexis Ballier
2017-07-07  6:18 Markus Meier
2017-06-30  8:14 Sergei Trofimovich
2017-06-29 20:28 Alexis Ballier
2017-06-29 20:28 Alexis Ballier
2017-06-29  8:06 Agostino Sarubbo
2017-06-25 14:42 Alexis Ballier
2017-06-20 13:35 Fabian Groffen
2017-06-15 13:44 Alexis Ballier
2017-04-27 10:40 Alexis Ballier
2017-04-15 10:27 Alexis Ballier
2017-03-27 10:10 Alexis Ballier
2017-03-03 11:28 Alexis Ballier
2017-02-21 14:20 Alexis Ballier
2017-02-21 14:20 Alexis Ballier
2017-02-14  9:31 Alexis Ballier
2017-02-12 19:56 Markus Meier
2017-01-29 23:02 Jeroen Roovers
2017-01-26 15:28 Agostino Sarubbo
2017-01-26 11:00 Agostino Sarubbo
2017-01-26 10:22 Agostino Sarubbo
2017-01-25 19:21 Tobias Klausmann
2017-01-25 15:52 Agostino Sarubbo
2017-01-25 15:35 Agostino Sarubbo
2017-01-25 14:29 Agostino Sarubbo
2017-01-14 15:41 Mikle Kolyada
2017-01-14 15:40 Mikle Kolyada
2016-11-29 15:05 Alexis Ballier
2016-11-15  9:36 Alexis Ballier
2016-11-15  9:36 Alexis Ballier
2016-09-06  8:29 Alexis Ballier
2016-04-30 14:18 Alexis Ballier
2016-04-30 14:18 Alexis Ballier
2016-04-02  9:06 Alexis Ballier
2016-04-02  9:06 Alexis Ballier
2016-03-03 10:58 Alexis Ballier
2016-03-01 19:17 Alexis Ballier
2016-02-04 17:24 Tobias Klausmann
2015-11-21 14:23 Markus Meier
2015-11-12 11:21 Agostino Sarubbo
2015-11-11  9:54 Agostino Sarubbo
2015-11-10 12:01 Agostino Sarubbo
2015-11-03  4:14 Jeroen Roovers
2015-11-01 11:12 Jeroen Roovers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1615573355.4bbb6a45f6d3e0193703828d6cdf04b46babc7b9.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox