public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Andreas Sturmlechner" <asturm@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: app-emulation/faudio/
Date: Sat,  6 Mar 2021 17:02:42 +0000 (UTC)	[thread overview]
Message-ID: <1615050142.c9a875a5033ae3bf563c9136d0dd120f9c696e2e.asturm@gentoo> (raw)

commit:     c9a875a5033ae3bf563c9136d0dd120f9c696e2e
Author:     Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
AuthorDate: Thu Feb 25 11:19:44 2021 +0000
Commit:     Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
CommitDate: Sat Mar  6 17:02:22 2021 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c9a875a5

app-emulation/faudio: Switch to cmake.eclass

Drop superfluous COMMON_DEPEND
Drop superfluous CMAKE_INSTALL_PREFIX, set by cmake.eclass

Use of CMAKE_INSTALL_<dir> variables looks like a workaround of wrong upstream
usage of GNUInstallDirs but should be fixed upstream.

Closes: https://bugs.gentoo.org/770532
Package-Manager: Portage-3.0.15, Repoman-3.0.2
Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org>

 app-emulation/faudio/faudio-21.01.ebuild | 15 ++++++---------
 app-emulation/faudio/faudio-9999.ebuild  | 15 ++++++---------
 2 files changed, 12 insertions(+), 18 deletions(-)

diff --git a/app-emulation/faudio/faudio-21.01.ebuild b/app-emulation/faudio/faudio-21.01.ebuild
index 52c652a5959..51ecd606fc2 100644
--- a/app-emulation/faudio/faudio-21.01.ebuild
+++ b/app-emulation/faudio/faudio-21.01.ebuild
@@ -4,6 +4,7 @@
 # shellcheck disable=SC2034
 EAPI=7
 
+CMAKE_ECLASS=cmake
 CMAKE_MAKEFILE_GENERATOR="emake"
 MULTILIB_COMPAT=( abi_x86_{32,64} )
 
@@ -31,24 +32,20 @@ IUSE="+abi_x86_32 +abi_x86_64 debug dumpvoices gstreamer xnasong test utils"
 RESTRICT="!test? ( test )"
 REQUIRED_USE="|| ( abi_x86_32 abi_x86_64 )"
 
-COMMON_DEPEND="
+DEPEND="
 	>=media-libs/libsdl2-2.0.9[sound,${MULTILIB_USEDEP}]
 	gstreamer? (
 		media-libs/gstreamer:1.0[${MULTILIB_USEDEP}]
 		media-libs/gst-plugins-base:1.0[${MULTILIB_USEDEP}]
 	)
 "
-RDEPEND="${COMMON_DEPEND}
-"
-DEPEND="${COMMON_DEPEND}
-"
+RDEPEND="${DEPEND}"
 
 multilib_src_configure() {
 	local mycmakeargs=(
 		"-DCMAKE_INSTALL_BINDIR=bin"
 		"-DCMAKE_INSTALL_INCLUDEDIR=include/${FAUDIO_PN}"
 		"-DCMAKE_INSTALL_LIBDIR=$(get_libdir)"
-		"-DCMAKE_INSTALL_PREFIX=${EPREFIX}/usr"
 		"-DCMAKE_BUILD_TYPE=$(usex debug Debug Release)"
 		"-DFORCE_ENABLE_DEBUGCONFIGURATION=$(usex debug ON OFF)"
 		"-DBUILD_TESTS=$(usex test ON OFF)"
@@ -57,7 +54,7 @@ multilib_src_configure() {
 		"-DGSTREAMER=$(usex gstreamer ON OFF)"
 		"-DXNASONG=$(usex xnasong ON OFF)"
 	)
-	cmake-utils_src_configure
+	cmake_src_configure
 }
 
 src_configure() {
@@ -65,13 +62,13 @@ src_configure() {
 }
 
 multilib_src_compile() {
-	cmake-utils_src_make
+	cmake_build
 	emake -C "${BUILD_DIR}" all
 }
 
 multilib_src_install() {
 	# FIXME: do we want to install the FAudio tools?
-	cmake-utils_src_install
+	cmake_src_install
 
 	sed -e "s@%LIB%@$(get_libdir)@g" -e "s@%PREFIX%@${EPREFIX}/usr@g" \
 		"${FILESDIR}/faudio.pc" > "${T}/faudio.pc" \

diff --git a/app-emulation/faudio/faudio-9999.ebuild b/app-emulation/faudio/faudio-9999.ebuild
index 52c652a5959..51ecd606fc2 100644
--- a/app-emulation/faudio/faudio-9999.ebuild
+++ b/app-emulation/faudio/faudio-9999.ebuild
@@ -4,6 +4,7 @@
 # shellcheck disable=SC2034
 EAPI=7
 
+CMAKE_ECLASS=cmake
 CMAKE_MAKEFILE_GENERATOR="emake"
 MULTILIB_COMPAT=( abi_x86_{32,64} )
 
@@ -31,24 +32,20 @@ IUSE="+abi_x86_32 +abi_x86_64 debug dumpvoices gstreamer xnasong test utils"
 RESTRICT="!test? ( test )"
 REQUIRED_USE="|| ( abi_x86_32 abi_x86_64 )"
 
-COMMON_DEPEND="
+DEPEND="
 	>=media-libs/libsdl2-2.0.9[sound,${MULTILIB_USEDEP}]
 	gstreamer? (
 		media-libs/gstreamer:1.0[${MULTILIB_USEDEP}]
 		media-libs/gst-plugins-base:1.0[${MULTILIB_USEDEP}]
 	)
 "
-RDEPEND="${COMMON_DEPEND}
-"
-DEPEND="${COMMON_DEPEND}
-"
+RDEPEND="${DEPEND}"
 
 multilib_src_configure() {
 	local mycmakeargs=(
 		"-DCMAKE_INSTALL_BINDIR=bin"
 		"-DCMAKE_INSTALL_INCLUDEDIR=include/${FAUDIO_PN}"
 		"-DCMAKE_INSTALL_LIBDIR=$(get_libdir)"
-		"-DCMAKE_INSTALL_PREFIX=${EPREFIX}/usr"
 		"-DCMAKE_BUILD_TYPE=$(usex debug Debug Release)"
 		"-DFORCE_ENABLE_DEBUGCONFIGURATION=$(usex debug ON OFF)"
 		"-DBUILD_TESTS=$(usex test ON OFF)"
@@ -57,7 +54,7 @@ multilib_src_configure() {
 		"-DGSTREAMER=$(usex gstreamer ON OFF)"
 		"-DXNASONG=$(usex xnasong ON OFF)"
 	)
-	cmake-utils_src_configure
+	cmake_src_configure
 }
 
 src_configure() {
@@ -65,13 +62,13 @@ src_configure() {
 }
 
 multilib_src_compile() {
-	cmake-utils_src_make
+	cmake_build
 	emake -C "${BUILD_DIR}" all
 }
 
 multilib_src_install() {
 	# FIXME: do we want to install the FAudio tools?
-	cmake-utils_src_install
+	cmake_src_install
 
 	sed -e "s@%LIB%@$(get_libdir)@g" -e "s@%PREFIX%@${EPREFIX}/usr@g" \
 		"${FILESDIR}/faudio.pc" > "${T}/faudio.pc" \


             reply	other threads:[~2021-03-06 17:02 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-06 17:02 Andreas Sturmlechner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-11-02 12:06 [gentoo-commits] repo/gentoo:master commit in: app-emulation/faudio/ Conrad Kostecki
2024-10-15 22:13 Conrad Kostecki
2024-10-15 22:13 Conrad Kostecki
2024-10-15 22:13 Conrad Kostecki
2024-10-05 23:00 Conrad Kostecki
2024-09-15 13:35 Conrad Kostecki
2024-08-04 14:03 Conrad Kostecki
2024-07-26 20:45 Conrad Kostecki
2024-07-26 20:45 Conrad Kostecki
2024-07-26 20:45 Conrad Kostecki
2024-07-26 20:45 Conrad Kostecki
2024-07-26 20:45 Conrad Kostecki
2024-04-04 11:52 Matt Jolly
2024-04-04 11:52 Matt Jolly
2023-03-22 18:46 Andreas Sturmlechner
2023-03-15 12:55 Arthur Zamarin
2023-03-15 12:54 Arthur Zamarin
2023-02-19  6:28 Ionen Wolkens
2023-02-19  5:22 Ionen Wolkens
2023-02-19  5:22 Ionen Wolkens
2023-02-19  5:22 Ionen Wolkens
2021-04-17 13:37 Andreas Sturmlechner
2021-03-08 10:25 Sam James
2021-03-07 14:45 Agostino Sarubbo
2021-01-10  0:21 Nick Sarnie
2020-09-12 22:02 Nick Sarnie
2020-06-04  6:33 Matt Turner
2020-04-13 16:53 Agostino Sarubbo
2020-04-12  7:30 Agostino Sarubbo
2020-02-10  1:57 Nick Sarnie
2020-02-08 17:06 David Seifert
2019-10-01  1:17 Nick Sarnie
2019-09-15 15:27 Nick Sarnie
2019-08-08  6:41 Guilherme Amadio
2019-06-16 14:22 Nick Sarnie
2019-06-16 14:22 Nick Sarnie
2019-03-17 14:16 Nick Sarnie
2019-03-16 20:49 Nick Sarnie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1615050142.c9a875a5033ae3bf563c9136d0dd120f9c696e2e.asturm@gentoo \
    --to=asturm@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox