From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id F3A071382C5 for ; Tue, 1 Dec 2020 23:05:31 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id BECE3E0895; Tue, 1 Dec 2020 23:05:29 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A8040E088D for ; Tue, 1 Dec 2020 23:05:29 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 4F64E340D06 for ; Tue, 1 Dec 2020 23:05:28 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id C7A4646F for ; Tue, 1 Dec 2020 23:05:26 +0000 (UTC) From: "Marek Szuba" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Marek Szuba" Message-ID: <1606863233.2e1834613e434ec0700d888a7c63bf53da39903b.marecki@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: games-strategy/naev/ X-VCS-Repository: repo/gentoo X-VCS-Files: games-strategy/naev/naev-0.7.0.ebuild X-VCS-Directories: games-strategy/naev/ X-VCS-Committer: marecki X-VCS-Committer-Name: Marek Szuba X-VCS-Revision: 2e1834613e434ec0700d888a7c63bf53da39903b X-VCS-Branch: master Date: Tue, 1 Dec 2020 23:05:26 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 8234693b-6289-4583-a0ad-57188db6af1f X-Archives-Hash: 911d58b8a19b7bce7088520b66b9f5e1 commit: 2e1834613e434ec0700d888a7c63bf53da39903b Author: Marek Szuba gentoo org> AuthorDate: Tue Dec 1 22:39:04 2020 +0000 Commit: Marek Szuba gentoo org> CommitDate: Tue Dec 1 22:53:53 2020 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2e183461 games-strategy/naev-0.7.0: fix SRC_URI, explain BDEPEND/src_unpack pkgcheck complains about the lack of app-arch/unzip in BDEPEND but that is not correct - the data file is supposed to be installed zipped, and the custom src_unpack ensures only the source tarball is actually unpacked. Add a comment explaining this. More importantly, both SRC_URI wrong had '/${P}/' where '/v${PV}/' should be according to the layout of GitHub upstream as of 5 minutes ago. Signed-off-by: Marek Szuba gentoo.org> games-strategy/naev/naev-0.7.0.ebuild | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/games-strategy/naev/naev-0.7.0.ebuild b/games-strategy/naev/naev-0.7.0.ebuild index 20d6fd69fb5..1b20e968fdd 100644 --- a/games-strategy/naev/naev-0.7.0.ebuild +++ b/games-strategy/naev/naev-0.7.0.ebuild @@ -2,12 +2,13 @@ # Distributed under the terms of the GNU General Public License v2 EAPI=7 + inherit xdg-utils DESCRIPTION="A 2D space trading and combat game, in a similar vein to Escape Velocity" HOMEPAGE="https://naev.org/ https://github.com/naev/naev" -SRC_URI="https://github.com/naev/naev/releases/download/${P}/${P}.tar.bz2 - https://github.com/naev/naev/releases/download/${P}/${P}-ndata.zip" +SRC_URI="https://github.com/naev/naev/releases/download/v${PV}/${P}.tar.bz2 + https://github.com/naev/naev/releases/download/v${PV}/${P}-ndata.zip" LICENSE="GPL-2 GPL-3 public-domain CC-BY-3.0 CC-BY-SA-3.0" SLOT="0" @@ -30,6 +31,9 @@ RDEPEND=" DEPEND="${RDEPEND}" BDEPEND="virtual/pkgconfig" +# This is so that only the source tarball is unpacked - the data file +# is supposed to be installed *zipped*. This is why we do not need unzip +# in BDEPEND in spite of what repoman/pkgcheck might say. src_unpack() { unpack ${P}.tar.bz2 }