public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Marek Szuba" <marecki@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: games-strategy/naev/
Date: Tue,  1 Dec 2020 23:05:26 +0000 (UTC)	[thread overview]
Message-ID: <1606863233.2e1834613e434ec0700d888a7c63bf53da39903b.marecki@gentoo> (raw)

commit:     2e1834613e434ec0700d888a7c63bf53da39903b
Author:     Marek Szuba <marecki <AT> gentoo <DOT> org>
AuthorDate: Tue Dec  1 22:39:04 2020 +0000
Commit:     Marek Szuba <marecki <AT> gentoo <DOT> org>
CommitDate: Tue Dec  1 22:53:53 2020 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2e183461

games-strategy/naev-0.7.0: fix SRC_URI, explain BDEPEND/src_unpack

pkgcheck complains about the lack of app-arch/unzip in BDEPEND but
that is not correct - the data file is supposed to be installed zipped,
and the custom src_unpack ensures only the source tarball is actually
unpacked. Add a comment explaining this.

More importantly, both SRC_URI wrong had '/${P}/' where '/v${PV}/' should
be according to the layout of GitHub upstream as of 5 minutes ago.

Signed-off-by: Marek Szuba <marecki <AT> gentoo.org>

 games-strategy/naev/naev-0.7.0.ebuild | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/games-strategy/naev/naev-0.7.0.ebuild b/games-strategy/naev/naev-0.7.0.ebuild
index 20d6fd69fb5..1b20e968fdd 100644
--- a/games-strategy/naev/naev-0.7.0.ebuild
+++ b/games-strategy/naev/naev-0.7.0.ebuild
@@ -2,12 +2,13 @@
 # Distributed under the terms of the GNU General Public License v2
 
 EAPI=7
+
 inherit xdg-utils
 
 DESCRIPTION="A 2D space trading and combat game, in a similar vein to Escape Velocity"
 HOMEPAGE="https://naev.org/ https://github.com/naev/naev"
-SRC_URI="https://github.com/naev/naev/releases/download/${P}/${P}.tar.bz2
-	https://github.com/naev/naev/releases/download/${P}/${P}-ndata.zip"
+SRC_URI="https://github.com/naev/naev/releases/download/v${PV}/${P}.tar.bz2
+	https://github.com/naev/naev/releases/download/v${PV}/${P}-ndata.zip"
 
 LICENSE="GPL-2 GPL-3 public-domain CC-BY-3.0 CC-BY-SA-3.0"
 SLOT="0"
@@ -30,6 +31,9 @@ RDEPEND="
 DEPEND="${RDEPEND}"
 BDEPEND="virtual/pkgconfig"
 
+# This is so that only the source tarball is unpacked - the data file
+# is supposed to be installed *zipped*. This is why we do not need unzip
+# in BDEPEND in spite of what repoman/pkgcheck might say.
 src_unpack() {
 	unpack ${P}.tar.bz2
 }


             reply	other threads:[~2020-12-01 23:05 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01 23:05 Marek Szuba [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-02-26  8:47 [gentoo-commits] repo/gentoo:master commit in: games-strategy/naev/ Ionen Wolkens
2025-02-22  3:07 Ionen Wolkens
2025-01-09  8:39 Ionen Wolkens
2024-12-27 22:16 Ionen Wolkens
2024-12-24  6:15 Ionen Wolkens
2024-06-28 14:45 Ionen Wolkens
2024-06-21 12:49 Ionen Wolkens
2024-02-22  6:16 Ionen Wolkens
2024-02-02  8:13 Ionen Wolkens
2024-01-23  9:11 Ionen Wolkens
2024-01-15  7:29 Ionen Wolkens
2024-01-08 12:59 Ionen Wolkens
2023-12-24 10:02 Ionen Wolkens
2023-08-06  4:32 Ionen Wolkens
2023-07-20 12:02 Ionen Wolkens
2023-05-11 17:01 Ionen Wolkens
2023-04-24  3:43 Ionen Wolkens
2023-02-13 11:46 Ionen Wolkens
2023-02-05 12:11 Ionen Wolkens
2023-01-20 22:48 Ionen Wolkens
2023-01-20 22:48 Ionen Wolkens
2023-01-17  6:03 Ionen Wolkens
2023-01-14 14:42 Ionen Wolkens
2023-01-13  0:51 Ionen Wolkens
2023-01-11 11:26 Ionen Wolkens
2022-12-30  7:19 Ionen Wolkens
2022-12-23  9:13 Ionen Wolkens
2022-08-11  7:37 Ionen Wolkens
2022-07-21  5:38 Ionen Wolkens
2022-04-18 14:38 Ionen Wolkens
2022-04-03  1:37 Ionen Wolkens
2022-02-16  6:58 Ionen Wolkens
2022-02-05 23:39 Ionen Wolkens
2022-01-21 14:35 Ionen Wolkens
2022-01-03  2:08 Ionen Wolkens
2021-12-02 12:21 Ionen Wolkens
2021-05-27 21:06 David Seifert
2021-05-27 21:06 David Seifert
2021-03-30 11:53 David Seifert
2021-03-30 10:47 David Seifert
2021-03-30 10:47 David Seifert
2021-02-17  9:37 David Seifert
2021-02-17  9:37 David Seifert
2021-01-17  7:49 Sam James
2020-12-01 23:05 Marek Szuba
2019-12-06 20:32 David Seifert
2018-05-02 19:28 Pacho Ramos
2018-05-02 19:28 Pacho Ramos
2017-12-21  1:57 David Seifert
2016-03-14 15:23 Michael Sterrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1606863233.2e1834613e434ec0700d888a7c63bf53da39903b.marecki@gentoo \
    --to=marecki@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox