public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Zac Medico" <zmedico@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/portage:master commit in: repoman/lib/repoman/
Date: Sat, 15 Aug 2020 23:56:36 +0000 (UTC)	[thread overview]
Message-ID: <1597535761.a6f90ba17202518ab0c976a32cb216a8e719f8fa.zmedico@gentoo> (raw)

commit:     a6f90ba17202518ab0c976a32cb216a8e719f8fa
Author:     Zac Medico <zmedico <AT> gentoo <DOT> org>
AuthorDate: Sat Aug 15 23:55:50 2020 +0000
Commit:     Zac Medico <zmedico <AT> gentoo <DOT> org>
CommitDate: Sat Aug 15 23:56:01 2020 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=a6f90ba1

repoman/lib/repoman/scanner.py: Fix useless-return

Signed-off-by: Zac Medico <zmedico <AT> gentoo.org>

 repoman/lib/repoman/scanner.py | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/repoman/lib/repoman/scanner.py b/repoman/lib/repoman/scanner.py
index f9df73d83..f9663e013 100644
--- a/repoman/lib/repoman/scanner.py
+++ b/repoman/lib/repoman/scanner.py
@@ -365,7 +365,6 @@ class Scanner:
 			dynamic_data["changelog_modified"] = changelog_path in self.changed.changelogs
 
 			self._scan_ebuilds(ebuildlist, dynamic_data)
-		return
 
 
 	def _scan_ebuilds(self, ebuildlist, dynamic_data):
@@ -408,7 +407,6 @@ class Scanner:
 		# Final checks
 		# initialize per pkg plugin final checks here
 		# need to set it up for ==> self.modules_list or some other ordered list
-		xpkg_complete = False
 		for mod in self.moduleconfig.final_loop:
 			if mod:
 				mod_class = self.moduleconfig.controller.get_class(mod)
@@ -423,10 +421,5 @@ class Scanner:
 					logging.debug("\tRunning function: %s", func)
 					_continue = func(**self.set_func_kwargs(mod, dynamic_data))
 					if _continue:
-						xpkg_complete = True
 						# logging.debug("\t>>> Continuing")
 						break
-
-		if xpkg_complete:
-			return
-		return


             reply	other threads:[~2020-08-15 23:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-15 23:56 Zac Medico [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-03-31  6:34 [gentoo-commits] proj/portage:master commit in: repoman/lib/repoman/ Zac Medico
2021-03-31  6:28 Zac Medico
2021-03-28 22:59 Zac Medico
2021-03-28 18:48 Zac Medico
2020-08-16  0:43 Zac Medico
2020-03-23 22:02 Zac Medico
2019-12-03 23:18 Zac Medico
2019-12-03 23:07 Zac Medico
2019-05-26  4:29 Zac Medico
2018-10-27 23:39 Zac Medico
2018-09-30 20:38 Mike Gilbert
2018-09-30 20:38 Mike Gilbert
2018-09-22  9:44 Zac Medico
2018-08-16 20:05 Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1597535761.a6f90ba17202518ab0c976a32cb216a8e719f8fa.zmedico@gentoo \
    --to=zmedico@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox