From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 7E2D5138359 for ; Wed, 5 Aug 2020 02:15:26 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A840EE08ED; Wed, 5 Aug 2020 02:15:25 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 572F0E08ED for ; Wed, 5 Aug 2020 02:15:25 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 78AD534E835 for ; Wed, 5 Aug 2020 02:15:24 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 076AE301 for ; Wed, 5 Aug 2020 02:15:23 +0000 (UTC) From: "Zac Medico" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Zac Medico" Message-ID: <1596593514.7b3896ccf0001eedc02735b4379bbd7d78bb2449.zmedico@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: / X-VCS-Repository: proj/portage X-VCS-Files: DEVELOPING X-VCS-Directories: / X-VCS-Committer: zmedico X-VCS-Committer-Name: Zac Medico X-VCS-Revision: 7b3896ccf0001eedc02735b4379bbd7d78bb2449 X-VCS-Branch: master Date: Wed, 5 Aug 2020 02:15:23 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 05f2881c-15a7-4921-bc60-6228533186d8 X-Archives-Hash: 55a7c506d3618bfb3fdf9ced2341f171 commit: 7b3896ccf0001eedc02735b4379bbd7d78bb2449 Author: Aaron Bauman gentoo org> AuthorDate: Wed Aug 5 01:05:15 2020 +0000 Commit: Zac Medico gentoo org> CommitDate: Wed Aug 5 02:11:54 2020 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=7b3896cc DEVELOPING: Update minimum python version * Other style/readability fixes Signed-off-by: Aaron Bauman gentoo.org> Signed-off-by: Zac Medico gentoo.org> DEVELOPING | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/DEVELOPING b/DEVELOPING index 31b559402..7bc559125 100644 --- a/DEVELOPING +++ b/DEVELOPING @@ -1,17 +1,15 @@ Code Guidelines --------------- + A few code guidelines to try to stick to, please comment if none of these make sense, they are pretty basic and mostly apply to old code. -However for people who are looking at current code, they make take up +However for people who are looking at current code, they may take up bad habits that exist in the current codebase. Python Version -------------- -Python 2.7 is the minimum supported version as it eases 3.x compatibility. -All exception handling should use Python 3 'except' syntax, and the print -function should be used instead of Python 2's print statement (use "from -__future__ import print_function" everywhere). +Python 3.6 is the minimum supported version. Dependencies ------------ @@ -30,7 +28,7 @@ width. Line-Wrapping ------------- -Lines should typically not be longer than 80 characters; if they are an +Lines should typically not be longer than 80 characters; if they are, an attempt should be made to wrap them. Move code to the line below and indent once (\t). @@ -47,7 +45,7 @@ errors.append(MalformedMetadata( attr='DESCRIPTION.toolong') The mixing of tabs and spaces means other developers can't read what you -did. This is why the python peps state spaces over tabs; because with +did. This is why the Python PEPs state spaces over tabs; because with spaces the line wrapping is always clear (but you cannot convert spaces as easily as tabwidth). @@ -189,12 +187,18 @@ at 72. Prefix the message with the component you touched if this makes sense. Postfix the message with the bug it fixes, if it does. Feel free to use the following notes (if applicable): + Signed-off-by: Wrote (a substantial portion of) the patch + Reviewed-by: Reviewed the patch thoroughly + Tested-by: Tested the patch thoroughly + Acked-by: Approved the concept but did not read the patch in detail (typically used by the maintainer of a specific portion, or a lead) + Suggested-by: Designed the implementation + Requested-by: Reported the bug/made the feature request Example: