public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sergei Trofimovich" <slyfox@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/gcc-patches:master commit in: 10.1.0/gentoo/
Date: Fri,  3 Jul 2020 22:12:45 +0000 (UTC)	[thread overview]
Message-ID: <1593814330.6e1df9589fa94fb616529fbd7908b8f3076f1f19.slyfox@gentoo> (raw)

commit:     6e1df9589fa94fb616529fbd7908b8f3076f1f19
Author:     Sergei Trofimovich <slyfox <AT> gentoo <DOT> org>
AuthorDate: Fri Jul  3 22:12:10 2020 +0000
Commit:     Sergei Trofimovich <slyfox <AT> gentoo <DOT> org>
CommitDate: Fri Jul  3 22:12:10 2020 +0000
URL:        https://gitweb.gentoo.org/proj/gcc-patches.git/commit/?id=6e1df958

10.1.0: Disable -fdelayed-branch by default.

From https://gcc.gnu.org/PR96015 / https://bugs.gentoo.org/729570.
delayed branches are known to generate invalid code around
__builtin_unreachable(); and mis-compiles python.

Use blunt hammer and disable delayed slots until we have better fix.

Reported-by: Jeroen Roovers
Bug: From https://gcc.gnu.org/PR96015
Bug: https://bugs.gentoo.org/729570.
Signed-off-by: Sergei Trofimovich <slyfox <AT> gentoo.org>

 10.1.0/gentoo/36_all_fno-delayed-branch.patch | 40 +++++++++++++++++++++++++++
 10.1.0/gentoo/README.history                  |  1 +
 2 files changed, 41 insertions(+)

diff --git a/10.1.0/gentoo/36_all_fno-delayed-branch.patch b/10.1.0/gentoo/36_all_fno-delayed-branch.patch
new file mode 100644
index 0000000..bc19974
--- /dev/null
+++ b/10.1.0/gentoo/36_all_fno-delayed-branch.patch
@@ -0,0 +1,40 @@
+From 6d0d3ae914bf19706550a539ef304c5875535ffc Mon Sep 17 00:00:00 2001
+From: Sergei Trofimovich <siarheit@google.com>
+Date: Fri, 3 Jul 2020 22:50:33 +0100
+Subject: [PATCH] Disable -fdelayed-branch by default.
+
+From https://gcc.gnu.org/PR96015 / https://bugs.gentoo.org/729570.
+delayed branches are known to generate invalid code around
+__builtin_unreachable(); and mis-compiles python.
+
+Use blunt hammer and disable delayed slots until we have better fix.
+
+Reported-by: Jeroen Roovers
+Bug: From https://gcc.gnu.org/PR96015
+Bug: https://bugs.gentoo.org/729570.
+Signed-off-by: Sergei Trofimovich <siarheit@google.com>
+---
+ gcc/opts.c | 9 ++++++++-
+ 1 file changed, 8 insertions(+), 1 deletion(-)
+
+--- a/gcc/opts.c
++++ b/gcc/opts.c
+@@ -458,7 +458,14 @@ static const struct default_options default_options_table[] =
+     /* -O1 (and not -Og) optimizations.  */
+     { OPT_LEVELS_1_PLUS_NOT_DEBUG, OPT_fbranch_count_reg, NULL, 1 },
+ #if DELAY_SLOTS
+-    { OPT_LEVELS_1_PLUS_NOT_DEBUG, OPT_fdelayed_branch, NULL, 1 },
++    /*
++     * From https://gcc.gnu.org/PR96015 / https://bugs.gentoo.org/729570.
++     * delayed branches are known to generate invalid code around
++     * __builtin_unreachable(); and mis-compiles python.
++     *
++     * Use blunt hammer and disable delayed slots until we have better fix.
++     */
++    /* { OPT_LEVELS_1_PLUS_NOT_DEBUG, OPT_fdelayed_branch, NULL, 1 }, */
+ #endif
+     { OPT_LEVELS_1_PLUS_NOT_DEBUG, OPT_fdse, NULL, 1 },
+     { OPT_LEVELS_1_PLUS_NOT_DEBUG, OPT_fif_conversion, NULL, 1 },
+-- 
+2.27.0
+

diff --git a/10.1.0/gentoo/README.history b/10.1.0/gentoo/README.history
index 72e0086..6b6324c 100644
--- a/10.1.0/gentoo/README.history
+++ b/10.1.0/gentoo/README.history
@@ -2,6 +2,7 @@
 	33_all_avx512-scalar-PR95528.patch
 	34_all_cet-cross-x86.patch
 	35_all_ICE-array-subscript-PR95508.patch
+	36_all_fno-delayed-branch.patch
 
 2		11 June 2020
 	+ 29_all_fix-float-hang-PR95118.patch


             reply	other threads:[~2020-07-03 22:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-03 22:12 Sergei Trofimovich [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-07-23  8:50 [gentoo-commits] proj/gcc-patches:master commit in: 10.1.0/gentoo/ Sergei Trofimovich
2020-07-19 21:35 Sergei Trofimovich
2020-07-14  7:17 Sergei Trofimovich
2020-07-04  7:56 Sergei Trofimovich
2020-07-04  7:56 Sergei Trofimovich
2020-06-24 20:15 Sergei Trofimovich
2020-06-23  6:34 Sergei Trofimovich
2020-06-14 11:07 Sergei Trofimovich
2020-06-11 23:00 Sergei Trofimovich
2020-06-11 22:49 Sergei Trofimovich
2020-06-05 21:02 Sergei Trofimovich
2020-05-19 22:02 Sergei Trofimovich
2020-05-14 17:58 Sergei Trofimovich
2020-05-07 20:51 Sergei Trofimovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1593814330.6e1df9589fa94fb616529fbd7908b8f3076f1f19.slyfox@gentoo \
    --to=slyfox@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox