public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Zac Medico" <zmedico@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/portage:master commit in: lib/portage/util/_async/
Date: Sun, 14 Jun 2020 00:02:17 +0000 (UTC)	[thread overview]
Message-ID: <1592092816.54cdf7e6cf9ec2030283ab23d659e10562267c6b.zmedico@gentoo> (raw)

commit:     54cdf7e6cf9ec2030283ab23d659e10562267c6b
Author:     Zac Medico <zmedico <AT> gentoo <DOT> org>
AuthorDate: Sat Jun 13 23:59:43 2020 +0000
Commit:     Zac Medico <zmedico <AT> gentoo <DOT> org>
CommitDate: Sun Jun 14 00:00:16 2020 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=54cdf7e6

PipeLogger: fix FEATURES=compress-build-logs (bug 709746)

For FEATURES=compress-build-logs, use log_file.write since data written
directly to the file descriptor bypasses compression.

Fixes: 3e46825a0470 ("PipeLogger: non-blocking write to pipe (bug 709746)")
Bug: https://bugs.gentoo.org/709746
Signed-off-by: Zac Medico <zmedico <AT> gentoo.org>

 lib/portage/util/_async/PipeLogger.py | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/lib/portage/util/_async/PipeLogger.py b/lib/portage/util/_async/PipeLogger.py
index 83669e05e..1776cc860 100644
--- a/lib/portage/util/_async/PipeLogger.py
+++ b/lib/portage/util/_async/PipeLogger.py
@@ -131,6 +131,13 @@ class PipeLogger(AbstractPollTask):
 								fcntl.F_GETFL) ^ os.O_NONBLOCK)
 
 				if log_file is not None:
+					if isinstance(log_file, gzip.GzipFile):
+						# Use log_file.write since data written directly
+						# to the file descriptor bypasses compression.
+						log_file.write(buf)
+						log_file.flush()
+						continue
+
 					write_buf = buf
 					while write_buf:
 						try:


             reply	other threads:[~2020-06-14  0:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-14  0:02 Zac Medico [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-02-14 15:45 [gentoo-commits] proj/portage:master commit in: lib/portage/util/_async/ Zac Medico
2024-02-07  2:35 Zac Medico
2024-02-03 22:54 Zac Medico
2023-12-06 16:25 Zac Medico
2023-10-05  6:28 Zac Medico
2023-10-04  4:01 Zac Medico
2023-10-04  3:25 Zac Medico
2023-10-03 14:48 Zac Medico
2023-10-03 14:48 Zac Medico
2021-09-21  5:51 Zac Medico
2021-05-02  0:00 Zac Medico
2021-03-07 15:17 Zac Medico
2021-03-07 15:17 Zac Medico
2021-02-15  4:38 Zac Medico
2020-08-09  0:46 Zac Medico
2020-08-03 23:28 Zac Medico
2020-06-24  4:36 Zac Medico
2020-04-08  5:56 Zac Medico
2020-03-01  1:22 Zac Medico
2020-02-29  7:51 Zac Medico
2020-02-29  7:51 Zac Medico

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1592092816.54cdf7e6cf9ec2030283ab23d659e10562267c6b.zmedico@gentoo \
    --to=zmedico@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox