From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id BD9EE1382C5 for ; Mon, 25 May 2020 11:20:55 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id DB90CE0391; Mon, 25 May 2020 11:20:54 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id C2023E0391 for ; Mon, 25 May 2020 11:20:54 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 7AC9D34F013 for ; Mon, 25 May 2020 11:20:53 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id F027C242 for ; Mon, 25 May 2020 11:20:51 +0000 (UTC) From: "Fabian Groffen" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Fabian Groffen" Message-ID: <1590405449.650ad6f9415e229d3ac8680ca8f8c6c12a3f43c4.grobian@gentoo> Subject: [gentoo-commits] proj/portage-utils:master commit in: / X-VCS-Repository: proj/portage-utils X-VCS-Files: qmerge.c X-VCS-Directories: / X-VCS-Committer: grobian X-VCS-Committer-Name: Fabian Groffen X-VCS-Revision: 650ad6f9415e229d3ac8680ca8f8c6c12a3f43c4 X-VCS-Branch: master Date: Mon, 25 May 2020 11:20:51 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: ebcd4263-8431-4254-a640-b0a0bc5244f6 X-Archives-Hash: 9a6f3feaeefc8fc5e90ec0fb6584b4bd commit: 650ad6f9415e229d3ac8680ca8f8c6c12a3f43c4 Author: Fabian Groffen gentoo org> AuthorDate: Mon May 25 11:17:29 2020 +0000 Commit: Fabian Groffen gentoo org> CommitDate: Mon May 25 11:17:29 2020 +0000 URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=650ad6f9 qmerge: fix Coverity 210533 ensure todo != NULL when attempting to turn into a list Signed-off-by: Fabian Groffen gentoo.org> qmerge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qmerge.c b/qmerge.c index 554e3dc..49c4b5d 100644 --- a/qmerge.c +++ b/qmerge.c @@ -1975,7 +1975,7 @@ qmerge_run(set *todo) if (uninstall) { return unmerge_packages(todo); } else { - if (todo == NULL && search_pkgs) { + if (todo == NULL || search_pkgs) { /* disputable, this should be qlist -kIv or something */ warn("please use qlist -kI");