public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Zac Medico" <zmedico@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/portage:master commit in: lib/portage/tests/emerge/
Date: Sun,  8 Mar 2020 07:33:07 +0000 (UTC)	[thread overview]
Message-ID: <1583652710.0552665627bf85f01ae28cafebc885dcb6d26ef3.zmedico@gentoo> (raw)

commit:     0552665627bf85f01ae28cafebc885dcb6d26ef3
Author:     Zac Medico <zmedico <AT> gentoo <DOT> org>
AuthorDate: Sun Mar  8 07:31:08 2020 +0000
Commit:     Zac Medico <zmedico <AT> gentoo <DOT> org>
CommitDate: Sun Mar  8 07:31:50 2020 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=05526656

SimpleEmergeTestCase: run tests in coroutine method

Signed-off-by: Zac Medico <zmedico <AT> gentoo.org>

 lib/portage/tests/emerge/test_simple.py | 25 ++++++++++++++++++-------
 1 file changed, 18 insertions(+), 7 deletions(-)

diff --git a/lib/portage/tests/emerge/test_simple.py b/lib/portage/tests/emerge/test_simple.py
index f5cd6f3d2..6aafff180 100644
--- a/lib/portage/tests/emerge/test_simple.py
+++ b/lib/portage/tests/emerge/test_simple.py
@@ -1,4 +1,4 @@
-# Copyright 2011-2019 Gentoo Authors
+# Copyright 2011-2020 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
 import subprocess
@@ -14,6 +14,9 @@ from portage.tests import TestCase
 from portage.tests.resolver.ResolverPlayground import ResolverPlayground
 from portage.util import (ensure_dirs, find_updated_config_files,
 	shlex_split)
+from portage.util.futures import asyncio
+from portage.util.futures.compat_coroutine import coroutine
+
 
 class SimpleEmergeTestCase(TestCase):
 
@@ -201,6 +204,15 @@ call_has_and_best_version() {
 
 		playground = ResolverPlayground(
 			ebuilds=ebuilds, installed=installed, debug=debug)
+
+		loop = asyncio._wrap_loop()
+		loop.run_until_complete(asyncio.ensure_future(
+			self._async_test_simple(playground, metadata_xml_files), loop=loop))
+
+	@coroutine
+	def _async_test_simple(self, playground, metadata_xml_files):
+
+		debug = playground.debug
 		settings = playground.settings
 		eprefix = settings["EPREFIX"]
 		eroot = settings["EROOT"]
@@ -487,15 +499,14 @@ move dev-util/git dev-vcs/git
 				else:
 					local_env = env
 
-				proc = subprocess.Popen(args,
-					env=local_env, stdout=stdout)
+				proc = yield asyncio.create_subprocess_exec(*args,
+					env=local_env, stderr=None, stdout=stdout)
 
 				if debug:
-					proc.wait()
+					yield proc.wait()
 				else:
-					output = proc.stdout.readlines()
-					proc.wait()
-					proc.stdout.close()
+					output, _err = yield proc.communicate()
+					yield proc.wait()
 					if proc.returncode != os.EX_OK:
 						for line in output:
 							sys.stderr.write(_unicode_decode(line))


             reply	other threads:[~2020-03-08  7:33 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-08  7:33 Zac Medico [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-03-08 22:29 [gentoo-commits] proj/portage:master commit in: lib/portage/tests/emerge/ Zac Medico
2020-08-03 19:30 Zac Medico
2020-08-03 23:28 Zac Medico
2020-10-12 18:03 Zac Medico
2020-10-17  9:21 Zac Medico
2021-01-18 12:20 Zac Medico
2022-09-25 19:12 Mike Gilbert
2023-05-26 15:45 Sam James
2023-05-26 15:45 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2023-10-30  3:14 Sam James
2024-01-03 19:59 Sam James
2024-02-24  3:36 Zac Medico
2024-02-25  8:25 Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1583652710.0552665627bf85f01ae28cafebc885dcb6d26ef3.zmedico@gentoo \
    --to=zmedico@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox